summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorArnold D. Robbins <arnold@skeeve.com>2015-04-05 10:51:51 +0300
committerArnold D. Robbins <arnold@skeeve.com>2015-04-05 10:51:51 +0300
commitdbf9d5a4fc4b6d6340912395f020019576ed37f6 (patch)
tree4b3540a5be9ec18187647cbdef462558a9cdfef2
parentf82aa0619d803ebe0dc1710edf1a3e108a4210c8 (diff)
parente7ee504434e315852ebd449e20d72929de63cfe6 (diff)
downloadgawk-dbf9d5a4fc4b6d6340912395f020019576ed37f6.tar.gz
Merge branch 'gawk-4.1-stable'
-rw-r--r--ChangeLog10
-rw-r--r--awkgram.c14
-rw-r--r--awkgram.y14
3 files changed, 32 insertions, 6 deletions
diff --git a/ChangeLog b/ChangeLog
index 9b9b114c..d50e7c2d 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,13 @@
+2015-04-05 Arnold D. Robbins <arnold@skeeve.com>
+
+ * awkgram.y (install_builtins): If do_traditional is true, do not
+ install gawk extensions flagged with GAWKX. Similarly, if do_posix
+ is true, do not install functions flagged with NOT_POSIX.
+ This fixes a problem with spurious lint complaints about shadowing
+ a global variable that is not valid in traditional or posix mode.
+ Thanks to Andrew Schorr for finding the problem and supplying
+ initial code; I did it slightly differently.
+
2015-04-02 Andrew J. Schorr <aschorr@telemetry-investments.com>
* NEWS: Rename div to intdiv.
diff --git a/awkgram.c b/awkgram.c
index 67c8feae..52a17cb0 100644
--- a/awkgram.c
+++ b/awkgram.c
@@ -8234,12 +8234,20 @@ void
install_builtins(void)
{
int i, j;
+ int flags_that_must_be_clear = DEBUG_USE;
+
+ if (do_traditional)
+ flags_that_must_be_clear |= GAWKX;
+
+ if (do_posix)
+ flags_that_must_be_clear |= NOT_POSIX;
+
j = sizeof(tokentab) / sizeof(tokentab[0]);
for (i = 0; i < j; i++) {
- if ( (tokentab[i].class == LEX_BUILTIN
- || tokentab[i].class == LEX_LENGTH)
- && (tokentab[i].flags & DEBUG_USE) == 0) {
+ if ( (tokentab[i].class == LEX_BUILTIN
+ || tokentab[i].class == LEX_LENGTH)
+ && (tokentab[i].flags & flags_that_must_be_clear) == 0) {
(void) install_symbol(tokentab[i].operator, Node_builtin_func);
}
}
diff --git a/awkgram.y b/awkgram.y
index e04c2c65..d429c9cd 100644
--- a/awkgram.y
+++ b/awkgram.y
@@ -5896,12 +5896,20 @@ void
install_builtins(void)
{
int i, j;
+ int flags_that_must_be_clear = DEBUG_USE;
+
+ if (do_traditional)
+ flags_that_must_be_clear |= GAWKX;
+
+ if (do_posix)
+ flags_that_must_be_clear |= NOT_POSIX;
+
j = sizeof(tokentab) / sizeof(tokentab[0]);
for (i = 0; i < j; i++) {
- if ( (tokentab[i].class == LEX_BUILTIN
- || tokentab[i].class == LEX_LENGTH)
- && (tokentab[i].flags & DEBUG_USE) == 0) {
+ if ( (tokentab[i].class == LEX_BUILTIN
+ || tokentab[i].class == LEX_LENGTH)
+ && (tokentab[i].flags & flags_that_must_be_clear) == 0) {
(void) install_symbol(tokentab[i].operator, Node_builtin_func);
}
}