diff options
author | Allan Saddi <allan@saddi.com> | 2006-06-27 18:53:04 +0000 |
---|---|---|
committer | Allan Saddi <allan@saddi.com> | 2006-06-27 18:53:04 +0000 |
commit | 6dfbb9aaf339f56d4415c3b8b49638b2cd6e1b75 (patch) | |
tree | 4d4b1e4d777468d40b74f155c06ff10eb5e26fb9 /flup/server/preforkserver.py | |
parent | d54e587fe69ae54a3ef83c5a7994ef2e44b2139f (diff) | |
download | flup-6dfbb9aaf339f56d4415c3b8b49638b2cd6e1b75.tar.gz |
Set close-on-exec flag on all server sockets.
Diffstat (limited to 'flup/server/preforkserver.py')
-rw-r--r-- | flup/server/preforkserver.py | 16 |
1 files changed, 16 insertions, 0 deletions
diff --git a/flup/server/preforkserver.py b/flup/server/preforkserver.py index a544f47..d7c4bf4 100644 --- a/flup/server/preforkserver.py +++ b/flup/server/preforkserver.py @@ -53,6 +53,15 @@ if not hasattr(socket, 'socketpair'): socket.socketpair = socketpair +try: + import fcntl +except ImportError: + def setCloseOnExec(sock): + pass +else: + def setCloseOnExec(sock): + fcntl.fcntl(sock.fileno(), fcntl.F_SETFD, fcntl.FD_CLOEXEC) + class PreforkServer(object): """ A preforked server model conceptually similar to Apache httpd(2). At @@ -102,6 +111,9 @@ class PreforkServer(object): # Don't want operations on main socket to block. sock.setblocking(0) + # Set close-on-exec + setCloseOnExec(sock) + # Main loop. while self._keepGoing: # Maintain minimum number of children. @@ -255,7 +267,9 @@ class PreforkServer(object): # the parent and its children. parent, child = socket.socketpair() parent.setblocking(0) + setCloseOnExec(parent) child.setblocking(0) + setCloseOnExec(child) try: pid = os.fork() except OSError, e: @@ -317,6 +331,8 @@ class PreforkServer(object): continue raise + setCloseOnExec(clientSock) + # Check if this client is allowed. if not self._isClientAllowed(addr): clientSock.close() |