diff options
author | Will Thompson <wjt@endlessos.org> | 2021-11-11 15:53:10 +0000 |
---|---|---|
committer | Simon McVittie <smcv@debian.org> | 2021-11-11 16:38:11 +0000 |
commit | eabbff6fefb879d6726a31afa8ae17ee144855a7 (patch) | |
tree | 30cf1be6cb356ded3263ee3691167a4ef4e71923 | |
parent | bcc114383b744e3dc32c0b859fc900f9793ce6c7 (diff) | |
download | flatpak-eabbff6fefb879d6726a31afa8ae17ee144855a7.tar.gz |
run: Document shortcomings of PulseAudio server string parsing
These are just based on a cursory reading of the spec.
-rw-r--r-- | common/flatpak-run.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/common/flatpak-run.c b/common/flatpak-run.c index 88fd481a..b1226728 100644 --- a/common/flatpak-run.c +++ b/common/flatpak-run.c @@ -591,6 +591,10 @@ flatpak_run_parse_pulse_server (const char *value) const char *server = servers[i]; if (g_str_has_prefix (server, "{")) { + /* + * TODO: compare the value within {} to the local hostname and D-Bus machine ID, + * and skip if it matches neither. + */ const char * closing = strstr (server, "}"); if (closing == NULL) continue; @@ -601,6 +605,8 @@ flatpak_run_parse_pulse_server (const char *value) return g_strdup (server + 5); if (server[0] == '/') return g_strdup (server); + + /* TODO: Support TCP connections? */ } return NULL; |