| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| |
|
|
|
|
|
|
| |
When using reusable content, genlist preserves old object's state and is
expecting reusable_content_get callback to change all needed properties.
But there was an inconsistency: it was silently re-enabling the old content.
@fix
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Broken by careless backport:
commit b97783d4c400f8a2c0bf3bc6c649079798d14068
Author: Jean-Philippe Andre <jp.andre@samsung.com>
Date: Wed Oct 18 21:40:01 2017 +0900
evas: Prevent crash with image_data_get
Yeah, it's me. Also no one else has tested 1.20 since, it seems :)
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary:
When ctxpopup's content is removed,
ctxpopup doesn't recalculate its size, so empty space is remaind.
To fix this problem, ctxpopup recalculate its size when content is removed.
This patch is about T6327
@fix
Test Plan:
1. run elementary_test -to ctxpopup
2. select 10st item
3. click button in ctxpopup
Reviewers: jpeg, Jaehyun_Cho, zmike
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D5462
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit e67aa661a0077f4069b67eefcb016424a630ab55.
I accidentally flagged this as a fix when it should've been a ref,
the bug (T6250) this was related to was actually fixed by the
previous 1.21 commit (a revert, returning the code to its 1.20 state).
The bug didn't exist on stable branch.
The patch was actually an optimization that requires all of my
1.21 wayland work. Ironically, backporting it to stable will
introduce the bug in T6250 there.
@ref T6250
|
| |
|
|
|
|
|
|
|
| |
if proxy fails are too many then give up on queued lookups as they
likely will continue. i noticed a process continually spawning efl net
proxy helper because one queued lookup failed and could be looked up
so it kept trying again and again.
@fix
|
| |
|
|
|
|
|
| |
Wrong position was used while going through the array of
points
@fix
|
| |
|
|
|
|
|
| |
It actually invoked SIGSEGV when trying to load SVG file with Radial
Gradient
@fix
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Coverity reports that we access vfmapped here without holding a lock.
This patch implements eina_lock_take/release while accessing
priv->vfmapped.
Fixes Coverity CID1381624
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
|
| |
|
|
|
|
|
|
|
|
|
| |
In most engines which inherit from software_generic, they do not
implement the outbuf_free_region_for_update function. Most engines
have it as an unused function. If we simply add a check here, then we
can reduce the need for having useless function in multiple engines.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
|
| |
|
|
|
|
|
|
|
|
|
| |
If we pass in screen geometry here when trying to set an output mode,
we can encounter "out of memory" errors from libdrm with outputs
that have a high resolution. As it turns out, we should be passing 0, 0 for
the x/y values when trying to set an output mode.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
|
| |
|
|
|
|
| |
It is now possible to set item.max back to default value (-1 -1).
@fix
|
| |
|
|
| |
@fix
|
| |
|
|
| |
@fix
|
| |
|
|
| |
@fix
|
| |
|
|
|
|
|
| |
Documentation comments for properties should be near parser
implementation.
@fix
|
| |
|
|
|
|
| |
All colors now accept 4 ints or hex string.
@fix
|
| |
|
|
| |
@fix
|
| |
|
|
| |
@fix
|
| |
|
|
|
|
|
|
| |
If you have undefined color_class, edje will use solid white for its
colors. If you define color_class name without colors edje_cc now has
same defaults instead of 0 0 0 0.
@fix
|
| |
|
|
|
|
| |
These properties belong to group, but were in part's block in edcref.
@fix
|
| |
|
|
|
|
|
| |
It can't be overridden by color values in state. Colors can only be
modified.
@fix
|
| |
|
|
| |
@fix
|
| |
|
|
| |
@fix
|
| |
|
|
| |
@fix
|
| |
|
|
|
|
|
| |
color2 is used for outline
color3 is used for shadow
@fix
|
| |
|
|
| |
@fix
|
| |
|
|
| |
@fix
|
| |
|
|
|
|
|
|
| |
The backspace key is supposed to send an ASCII code of 0x08, not 0x7F
(this would be the delete key). This has not be seen before as it is is
rare to use the ASCII code for the BackSpace key.
@fix
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Reviewers: cedric, ajwillia.ms
Reviewed By: cedric
Subscribers: segfaultxavi, jpeg
Differential Revision: https://phab.enlightenment.org/D5395
Signed-off-by: Cedric Bail <cedric@osg.samsung.com>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary:
Change the first letter of the sentence from lowercase to uppercase,
and fix typo "top be" to "to be"
Reviewers: cedric, jpeg, stefan_schmidt, myoungwoon, Jaehyun_Cho, conr2d
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D5398
Signed-off-by: Cedric Bail <cedric@osg.samsung.com>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary:
elm_index.h uses legacy keyword for ref tag.
The patch update each keywords for widgets.
And colon ":" character should be seperated from reference keyword.
It will remove doxygen warning messages from elm_index.h file.
Test Plan: N/A
Reviewers: cedric, raster, jpeg
Differential Revision: https://phab.enlightenment.org/D5387
|
| |
|
|
|
|
| |
avoid invalid reads later
@fix
|
| |
|
|
| |
@fix
|
| |
|
|
|
|
| |
wayland popup surfaces must have a parent in order to be visible
@fix
|
| | |
|
| |
|
|
|
|
| |
The elementary examples were built before, but not now.
I guess it was missed when we merged elementary to efl source tree.
This enables it and fixes some references.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary: Printing Address detail with Position. Label added to show the
detail of address.
Test Plan:
Compiled with cmd:
gcc -o location_example_01 \
location_example_01.c -g `pkg-config --cflags --libs elementary \
elocation`
Reviewers: raster, cedric
Subscribers: rajeshps, jpeg
Differential Revision: https://phab.enlightenment.org/D5356
|
| |
|
|
|
|
|
|
|
|
| |
Flushing should be done where it's needed now, but we still
need the rest of the idle handler as something like mesa may
have dispatched its queue, which reads all the pending wayland
events. In that case we have events to process but the fd will
not poll readable.
@fix T6250
|
| |
|
|
|
| |
This ensures the widget is clearer if the file has been cleared.
@fix T6185
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If the image has no data, it may get an allocated surface of 1x1 but it
is not sane to return the pointer to that data, as the user would expect
a normally sized image (in my case, 1920x1080).
I do not fully understand what is going on with this image. But at least
this transforms a crash into a simple ERR in ~/.xessions-errors
Two similar crashes happened:
- SIGSEGV by writing data outside of the image data
- abort() in free() because the malloc metadata has been overridden
when writing outside of the image data (newly allocated 1x1).
Fixes T5957
@fix
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use content_region_show instead of content_pos_set in _key_action_move
Summary:
When user keep pressing key down or else on scroller content, scroller
animation is lagging because of elm_interface_scrollable_content_pos_set
by step_x or step_y value. When focus moved to next object by press key
down or else, content_pos_set by ecore_animator continuously. In this
time, content_pos_set in _key_action_move by step_x or step_y value
caused animation lagging problem. I fixed to use content_region_show
instead of content_pos_set in _key_action_move for remove exist
animator.
Test Plan:
1. elementary_test -> Scroller3
2. Press 3 times "Append 10 Items in 3s" button
3. focus to Item1 and keep pressing key_down
Reviewers: jpeg, woohyun
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D5278
|
| |
|
|
|
|
|
|
| |
pointer.
Before this patch, the key would always be zero and the hash would solely
rely on the rbtree to be efficient. This improve the situation by using the pointer
as the key during hash computation.
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Summary: local variable "bp" assigned twice unnecessarily. The duplicate assignment is removed.
Reviewers: raster, cedric, jpeg
Subscribers: jpeg, rajeshps
Differential Revision: https://phab.enlightenment.org/D5323
Signed-off-by: Cedric Bail <cedric@osg.samsung.com>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary:
Putting local variable "d" under preprocessor flag "EINA_SAFETY_CHECKS" to avoid below warning, if "EINA_SAFETY_CHECKS" is disabled.
1. local variable "d" is assigned but not used.
2. If warning 1 is resolved then variable "d" will be unused.
Reviewers: raster, cedric
Reviewed By: cedric
Subscribers: jpeg, rajeshps
Differential Revision: https://phab.enlightenment.org/D5321
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary:
Fix assigned value is never used.
@fix
Reviewers: cedric
Subscribers: shilpasingh, jpeg
Differential Revision: https://phab.enlightenment.org/D5283
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary:
Avoid duplicate assignment to same variable.
@fix
Reviewers: cedric, jpeg
Reviewed By: cedric, jpeg
Subscribers: shilpasingh, jpeg
Differential Revision: https://phab.enlightenment.org/D5275
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
|
| |
|
|
|
|
| |
this should fix T6158
@fix
|
| |
|
|
|
|
|
| |
Because of a typo in generator source (and overlooked error in
tests) we were previously generating incorrect code for setters
with the @auto qualifier. This was brought up in D5306 and is
now fixed.
|
