| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| ... | |
| |
|
|
|
|
|
|
|
|
|
|
| |
Summary: @fix 1371128: DIVIDE_BY_ZERO
Reviewers: ajwillia.ms
Reviewed By: ajwillia.ms
Subscribers: ajwillia.ms, cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D4771
|
| |
|
|
| |
@fix
|
| |
|
|
|
|
|
| |
webp has slightly change since we registered this test and even if the
output is visually still close, as we do a perfect pixels comparison,
we are impacted by the slightest change. It would be nice to introduce
a function that does a more fuzzy comparison.
|
| |
|
|
| |
@fix
|
| |
|
|
|
|
| |
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D4766
|
| |
|
|
| |
See 5da4c96087260ff50e0e76fe69e5de5121a9accc
|
| |
|
|
|
|
|
|
| |
Test Plan: elementary_test -to "color classes"
Reviewers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D4741
|
| |
|
|
| |
Signed-off-by: JEONGHYUN YUN <jh0506.yun@samsung.com>
|
| | |
|
| |
|
|
|
|
|
|
| |
this will stop proxies, maps, and other filter object content from
being dropped whenever elm calls elm_cache_all_flush() to flush all
caches.
@fix
|
| |
|
|
| |
@fix
|
| |
|
|
|
| |
Fixes crashes when dragging selection out of widget.
@fix
|
| |
|
|
|
|
|
|
| |
The "access,activated" smart callback is called when "Activate the selected item"
gesture occurs.
Application could do the activation action using elm_access_action_cb_set.
But we recommend not to use elm_access_action_cb_set for this purpose on atspi
environment. And this would be usual widget behavior as elm_button does.
|
| |
|
|
|
|
| |
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D4729
|
| |
|
|
|
|
|
|
|
|
| |
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D4730
|
| |
|
|
|
|
|
|
|
|
| |
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: devilhorns, cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D4737
|
| |
|
|
|
|
|
|
|
|
| |
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D4736
|
| |
|
|
|
|
|
|
|
|
| |
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D4735
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary:
valign tag is for handling vertical align according to line's height and
text's height. But, it worked in a line which has only one font and
one font size, too. And the result was abnormal depending its font.
The line's height is [ascent + descent]. But, Textblock uses max ascent and
items's height(could be used max ascent + max descent according to its position)
when Textblock calculates item's yoff.
So, If Textblock calculate yoff based on line's height,
it should use only ascent and descent instead of max ascent and max descent.
@fix
Test Plan: Will attached in comment section.
Reviewers: raster, herdsman, jpeg, woohyun
Reviewed By: raster
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D4760
|
| |
|
|
|
|
|
|
|
| |
On Windows, fd and sockets are different. Sockets are actually HANDLES, hence
_get_osfhandle() should not be used with sockets, and GetHandleInformation()
and SetHandleInformation() can be used directly with sockets.
This is fixed by adding a function to test if the 'fd passed to fcntl() is a
socket or not.
|
| |
|
|
|
|
|
|
|
|
| |
the height of a item is 0 because the item is not realized, so if no
item is realized we are waiting until one is realized, until then we
just take 1px as a height, so at minimum one item needs to be realized.
If there is a realized item (or we are getting the event that there is
one) we are just calling _table_resize again, and are getting the size
for real.
|
| |
|
|
|
|
| |
in cases where a ui is using layers other objects could overlap the
hover object. Which is wrong, the genlist should stay above the rest of
the content, in any case.
|
| |
|
|
|
|
|
|
| |
if the parent is not a window the elm hover is created for the parent of
the combobox, which is a problem because the hover will not expand to
its full size of the window, and will stay in the size of the parent.
Adding the top widget instead of the parent widget fixes that.
|
| | |
|
| |
|
|
|
|
|
| |
when calling pixels_get during a render callback, another render would trigger
which would cause a deadlock from evas spinlock usage
@fix
|
| | |
|
| |
|
|
|
| |
C functions that take no arguments need to have void in the arg
list. Otherwise, it would mean taking any number of arguments.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, elementary programs crash on termination on macOS (seems
Sierra-specific). This is very nasty, looks like deep memory corruption...
Without valgrind (or like) support on Sierra, it is difficult to
pinpoint the origin of the problem.
Due to the imminient release, and after discussion with @stefan, this
kludge will allow the release to happen.
This commit MUST be reverted just after the release, so we don't
blindfold ourselves!
Ref T5245
|
| |
|
|
| |
ecore_job_del was missing in a4d2c51d1404c1d8563dd7ac37e64ee105aa6226
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
flipselector item destructor had a severe drawback and this patch fixes it.
when deleting multiple items at once, the view needs to be updated only once.
however, the destructor updated the view on deletion of
every single item and it caused a severe performance issue.
the worst case happened when deleting a flipselector object -
with 10000 items, it took 10 seconds to finish deletion.
this patch has two points:
1. if a flipselector object is on deletion, item destructor doesn't update the view
2. otherwise, view update is handled in one job for multiple item deletion
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary:
eina_file_virtualize is causing issues.
memfile_set is better but see attached bt.
What to do???
Reviewers: raster, cedric
Subscribers: jpeg
Differential Revision: https://phab.enlightenment.org/D4743
|
| |
|
|
| |
@fix
|
| |
|
|
|
|
|
| |
If the given string is not null-terminated, then strlen() will go out
of boundaries, we must limit the lookup to given 'n' parameter.
To do so use strnlen(), that is a strlen() bounded by a maximum size.
|
| |
|
|
|
|
|
| |
currently it's being defined in evil_fcntl.h, but the actual
implementation of fcntl() in evil_fcntl.c is causing problems with
sockets. So one possibility is to remove the ifdef, another is to
change the implementation.
|
| |
|
|
|
| |
Eina.h will include Evil.h, but those using direct include of internal
headers must include it as well.
|
| |
|
|
|
| |
these are not working on windows yet due other factors, anyway add the
proper ifdefs
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the local socket for windows, analogous to AF_UNIX.
`Efl_Net_Socket_Windows` is the base class doing `ReadFile()` and
`WriteFile()` using overlapped I/O, as well as the close procedure
(`FlushFileBuffers()`, `DisconnectNamedPipe()` and
`CloseHandle()`). These are done on top of an existing HANDLE that is
set by `Efl_Net_Dialer_Windows` (from `CreateFile()`) or
`Efl_Net_Server_Windows` (from `CreateNamedPipe()`).
The overlapped I/O will return immediately, either with operation
completed or `ERROR_IO_PENDING`, which means the kernel will execute
that asynchronously and will later `SetEvent(overlapped.hEvent)` which
is an event we wait on our main loop. That `overlapped` handle must
exist during the call lifetime, thus cannot be bound to `pd`, as we
may call `CancelIo()` but there is no guarantee the memory won't be
touched, in that case we keep the overlapped around, but without an
associated object.
Windows provides no notification "can read without blocking" or
non-blocking calls that returns partial data. The way to go is to use
these overlapped I/O, with an initial `ReadFile()` to an internal
buffer, once that operation finishes, we callback the user to says
there is something to read (`efl_io_reader_can_read_set()`) and wait
until `efl_io_reader_read()` is called to consume the available data,
then `ReadFile()` is called again to read more data to the same
internal buffer.
Likewise, there is no "can write without blocking" or non-blocking
calls that sends only partial data. The way to go is to get user bytes
in `efl_io_writer_write()` and copy them in an internal buffer, then
call `WriteFile()` on that and inform the user nothing else can be
written until that operation completes
(`efl_io_writer_can_write_set()`).
This is cumbersome since we say we "sent" stuff when we actually
didn't, it's still in our internal buffer (`pd->send.bytes`), but
nonetheless the kernel and the other peer may be adding even more
buffers, in this case we need to do a best effort to get it
delivery. A particular case is troublesome: `write() -> close()`, this
may result in `WriteFile()` pending, in this case we wait using
`GetOverlappedResult()`, *this is nasty and may block*, but it's the
only way I see to cope with such common use case.
Other operations, like ongoing `ReadFile()` or `ConnectNamedPipe()`
will be canceled using `CancelIo()`.
Q: Why no I/O Completion Port (IOCP) was used? Why no
CreateThreadpoolIo()? These perform much better!
A: These will call back from secondary threads, but in EFL we must
report back to the user in order to process incoming data or get
more data to send. That is, we serialize everything to the main
thread, making it impossible to use the benefits of IOCP and
similar such as CreateThreadpoolIo(). Since we'd need to wakeup the
main thread anyways, using `OVERLAPPED.hEvent` with
`ecore_main_win32_handler_add()` does the job as we expect.
Thanks to Vincent Torri (vtorri) for his help getting this code done
with an example on how to do the NamedPipe handling on Windows.
|
| |
|
|
|
| |
- win32 doesn't provide getline().
- _write() exists, use _write_() instead
|
| | |
|
| |
|
|
|
|
|
| |
While in UNIX we use 'select()/poll()' to query for read fds and this
will eventually callback with "can_read" event, use the loop to match
other implementations where can_read keeps true if not all data was
read.
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
| |
We have a tag for unstable API, use it. It'll be visible in the
doc and force users to add the macro before being able to compile
code.
This amends d8dd685966858dcc393302.
|
| |
|
|
| |
until settled, make these as beta for now.
|
| |
|
|
|
| |
the starting time has always been "now" like in timers (loop time). it
would appear some people don't know this.
|
| | |
|
| | |
|
