diff options
author | Carsten Haitzler (Rasterman) <raster@rasterman.com> | 2018-02-27 14:10:12 +0900 |
---|---|---|
committer | Carsten Haitzler (Rasterman) <raster@rasterman.com> | 2018-03-03 13:40:33 +0900 |
commit | 1c74aaa7e9c9fa1732b467aca5ee1458e3721f0a (patch) | |
tree | aa8cfdf82e579b61cec0ca3d08d2d9cfc4eab651 /src/tests/eio | |
parent | 6f092071ac54d10dde39889571518e4b9d17308f (diff) | |
download | efl-1c74aaa7e9c9fa1732b467aca5ee1458e3721f0a.tar.gz |
Revert "cxx: Fix manual code after efl_app change."
This reverts commit 135154303bea691c6f7f9472a5dec32d9103c38d.
Revert "efl: move signal events from efl.loop to efl.app"
This reverts commit 3dbca39f98288580c62a43c179ac11621433ec88.
Revert "efl: add test suite for efl_app"
This reverts commit 3e94be5d73256a7f5c02d3a9474173226be7beff.
Revert "efl: create Efl.App class, the parent of Efl.Loop"
This reverts commit 28fe00b94e55575c15684959b89a614d5a579309.
Go back to before efl.app because I think this should be done with
superclassing here not a parent object. reasons?
1. multiple loops per single thread make no sense. so if multilpe loop
objects they wont be contained in a single app object and then deleted
like this.
2. the app object is not really sharable in this design so it cant be
accessed from other threads
3. it makes it harder to get the main loop or app object (well 2 func
calls one calling the other and more typing. it is longer to type and
more work where it is not necessary, and again it can't work from
other threads unless we go duplicating efl.app per thread and then
what is the point of splittyign out the signal events from efl.loop
then?)
etc.
Diffstat (limited to 'src/tests/eio')
-rw-r--r-- | src/tests/eio/eio_model_test_file.c | 2 | ||||
-rw-r--r-- | src/tests/eio/eio_model_test_monitor_add.c | 2 | ||||
-rw-r--r-- | src/tests/eio/eio_test_manager.c | 12 | ||||
-rw-r--r-- | src/tests/eio/eio_test_manager_xattr.c | 2 |
4 files changed, 9 insertions, 9 deletions
diff --git a/src/tests/eio/eio_model_test_file.c b/src/tests/eio/eio_model_test_file.c index abbd7405de..81ab19d2c7 100644 --- a/src/tests/eio/eio_model_test_file.c +++ b/src/tests/eio/eio_model_test_file.c @@ -114,7 +114,7 @@ START_TEST(eio_model_test_test_file) fail_if(!efl_object_init(), "ERROR: Cannot init EO!\n"); fail_if(!eio_init(), "ERROR: Cannot init EIO!\n"); - filemodel = efl_add(EIO_MODEL_CLASS, efl_app_main_loop_get(efl_app_get()), eio_model_path_set(efl_added, EFL_MODEL_TEST_FILENAME_PATH)); + filemodel = efl_add(EIO_MODEL_CLASS, efl_main_loop_get(), eio_model_path_set(efl_added, EFL_MODEL_TEST_FILENAME_PATH)); fail_if(!filemodel, "ERROR: Cannot init model!\n"); handler = ecore_event_handler_add(ECORE_EVENT_SIGNAL_EXIT, exit_func, NULL); diff --git a/src/tests/eio/eio_model_test_monitor_add.c b/src/tests/eio/eio_model_test_monitor_add.c index b78b297157..e6b14d57b8 100644 --- a/src/tests/eio/eio_model_test_monitor_add.c +++ b/src/tests/eio/eio_model_test_monitor_add.c @@ -112,7 +112,7 @@ START_TEST(eio_model_test_test_monitor_add) tmpdir = eina_environment_tmp_get(); - filemodel = efl_add(EIO_MODEL_CLASS, efl_app_main_loop_get(efl_app_get()), eio_model_path_set(efl_added, tmpdir)); + filemodel = efl_add(EIO_MODEL_CLASS, efl_main_loop_get(), eio_model_path_set(efl_added, tmpdir)); fail_if(!filemodel, "ERROR: Cannot init model!\n"); efl_event_callback_add(filemodel, EFL_MODEL_EVENT_CHILD_ADDED, &_children_added_cb, filemodel); diff --git a/src/tests/eio/eio_test_manager.c b/src/tests/eio/eio_test_manager.c index 198117dc22..2e396c1ad6 100644 --- a/src/tests/eio/eio_test_manager.c +++ b/src/tests/eio/eio_test_manager.c @@ -156,7 +156,7 @@ _test_ls(Efl_Future *(*func)(Eo *obj, const char *path, Eina_Bool recursive), uint64_t expected_test_count, const char* test_dirname) { - Efl_Io_Manager *job = efl_add(EFL_IO_MANAGER_CLASS, efl_app_main_loop_get(efl_app_get())); + Efl_Io_Manager *job = efl_add(EFL_IO_MANAGER_CLASS, efl_main_loop_get()); Efl_Future *f = NULL; uint64_t main_files = 0; @@ -206,7 +206,7 @@ START_TEST(efl_io_manager_test_stat) nested_dirname = create_test_dirs(test_dirname); nested_filename = get_full_path(test_dirname, files[3]); - job = efl_add(EFL_IO_MANAGER_CLASS, efl_app_main_loop_get(efl_app_get())); + job = efl_add(EFL_IO_MANAGER_CLASS, efl_main_loop_get()); fail_if(!job); // Start testing @@ -257,7 +257,7 @@ START_TEST(efl_io_manager_test_ls) nested_filename = get_full_path(test_dirname, files[3]); // Start testing - job = efl_add(EFL_IO_MANAGER_CLASS, efl_app_main_loop_get(efl_app_get())); + job = efl_add(EFL_IO_MANAGER_CLASS, efl_main_loop_get()); fail_if(!job); f = efl_io_manager_ls(job, test_dirname, &main_files, _access_cb, NULL); @@ -311,7 +311,7 @@ START_TEST(efl_io_manager_test_open) nested_dirname = create_test_dirs(test_dirname); nested_filename = get_full_path(test_dirname, files[3]); - job = efl_add(EFL_IO_MANAGER_CLASS, efl_app_main_loop_get(efl_app_get())); + job = efl_add(EFL_IO_MANAGER_CLASS, efl_main_loop_get()); f = efl_io_manager_open(job, nested_filename, EINA_FALSE); eina_future_then(f, _open_done_cb, &opened_file); @@ -340,11 +340,11 @@ START_TEST(efl_io_instantiated) ecore_init(); - fail_if(efl_provider_find(efl_app_main_loop_get(efl_app_get()), EFL_IO_MANAGER_CLASS) != NULL); + fail_if(efl_provider_find(efl_main_loop_get(), EFL_IO_MANAGER_CLASS) != NULL); eio_init(); - manager = efl_provider_find(efl_app_main_loop_get(efl_app_get()), EFL_IO_MANAGER_CLASS); + manager = efl_provider_find(efl_main_loop_get(), EFL_IO_MANAGER_CLASS); fail_if(manager == NULL); fail_if(!efl_isa(manager, EFL_IO_MANAGER_CLASS)); diff --git a/src/tests/eio/eio_test_manager_xattr.c b/src/tests/eio/eio_test_manager_xattr.c index 186d28939f..136ae4dc16 100644 --- a/src/tests/eio/eio_test_manager_xattr.c +++ b/src/tests/eio/eio_test_manager_xattr.c @@ -130,7 +130,7 @@ START_TEST(eio_test_job_xattr_set) eina_init(); eio_init(); - job = efl_add(EFL_IO_MANAGER_CLASS, efl_app_main_loop_get(efl_app_get())); + job = efl_add(EFL_IO_MANAGER_CLASS, efl_main_loop_get()); test_file_path = get_full_path(XATTR_TEST_DIR, filename); fd = open(test_file_path, |