diff options
| author | Chris Michael <cp.michael@samsung.com> | 2013-07-08 08:01:58 +0100 |
|---|---|---|
| committer | Chris Michael <cp.michael@samsung.com> | 2013-07-08 08:01:58 +0100 |
| commit | bb30cd58ce5e1e1ce171acf6ef51f530d31458ab (patch) | |
| tree | 71ea45511407ecf683ffdc26c0c7839d8cfad94b /src/lib/ethumb | |
| parent | b0fa8b65639c5a8f72b29f8b86814224537ef936 (diff) | |
| download | efl-bb30cd58ce5e1e1ce171acf6ef51f530d31458ab.tar.gz | |
We cannot use dname in the error message if we have already freed it
above, so fix. On a mkpath failure, print out the message, Then free
dname. Be sure to also free dname if we do not error.
NB: Fixes Coverity CID1039893
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Diffstat (limited to 'src/lib/ethumb')
| -rw-r--r-- | src/lib/ethumb/ethumb.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/lib/ethumb/ethumb.c b/src/lib/ethumb/ethumb.c index ad49444031..eab57a2d8f 100644 --- a/src/lib/ethumb/ethumb.c +++ b/src/lib/ethumb/ethumb.c @@ -1354,12 +1354,13 @@ ethumb_image_save(Ethumb *e) dname = ecore_file_dir_get(e->thumb_path); r = ecore_file_mkpath(dname); - free(dname); if (!r) { ERR("could not create directory '%s'", dname); + free(dname); return EINA_FALSE; } + free(dname); snprintf(flags, sizeof(flags), "quality=%d compress=%d", e->quality, e->compress); |