diff options
| author | Carsten Haitzler (Rasterman) <raster@rasterman.com> | 2020-09-19 23:59:59 +0100 |
|---|---|---|
| committer | Carsten Haitzler (Rasterman) <raster@rasterman.com> | 2020-09-20 00:20:42 +0100 |
| commit | ca4b9393644f142cbe26cab6734f81f6d891b535 (patch) | |
| tree | c8a69f8e7bf6415512122ef49caa779bbbd98667 | |
| parent | 568dd7e45ba05eca7c3be58d1f778daf3c565d6b (diff) | |
| download | efl-ca4b9393644f142cbe26cab6734f81f6d891b535.tar.gz | |
ecore - efl exe - check returns of open and dup2 for stdin etc. fds
check returns - fix CID 1397002
| -rw-r--r-- | src/lib/ecore/efl_exe.c | 13 |
1 files changed, 8 insertions, 5 deletions
diff --git a/src/lib/ecore/efl_exe.c b/src/lib/ecore/efl_exe.c index 03c52ab845..7239bcdf6f 100644 --- a/src/lib/ecore/efl_exe.c +++ b/src/lib/ecore/efl_exe.c @@ -537,13 +537,14 @@ _efl_exe_efl_task_run(Eo *obj, Efl_Exe_Data *pd) { // hide stdin devnull = open("/dev/null", O_RDONLY); - dup2(devnull, STDIN_FILENO); + if (devnull < 0) _exit(1); + if (dup2(devnull, STDIN_FILENO) < 0) _exit(1); close(devnull); } else if ((td->flags & EFL_TASK_FLAGS_USE_STDIN)) { // hook up stdin to the pipe going to the parent - dup2(pipe_stdin[0], STDIN_FILENO); + if (dup2(pipe_stdin[0], STDIN_FILENO) < 0) _exit(1); close(pipe_stdin[0]); } @@ -552,13 +553,14 @@ _efl_exe_efl_task_run(Eo *obj, Efl_Exe_Data *pd) { // hide stdout devnull = open("/dev/null", O_WRONLY); - dup2(devnull, STDOUT_FILENO); + if (devnull < 0) _exit(1); + if (dup2(devnull, STDOUT_FILENO) < 0) _exit(1); close(devnull); } else if ((td->flags & EFL_TASK_FLAGS_USE_STDOUT)) { // hook up stdout to the pipe going to the parent - dup2(pipe_stdout[1], STDOUT_FILENO); + if (dup2(pipe_stdout[1], STDOUT_FILENO) < 0) _exit(1); close(pipe_stdout[1]); } @@ -566,7 +568,8 @@ _efl_exe_efl_task_run(Eo *obj, Efl_Exe_Data *pd) { // hide stderr devnull = open("/dev/null", O_WRONLY); - dup2(devnull, STDERR_FILENO); + if (devnull < 0) _exit(1); + if (dup2(devnull, STDERR_FILENO) < 0) _exit(1); close(devnull); } |