diff options
| author | Marcel Hollerbach <mail@marcel-hollerbach.de> | 2020-03-24 15:45:22 +0100 |
|---|---|---|
| committer | Marcel Hollerbach <mail@marcel-hollerbach.de> | 2020-03-24 20:41:34 +0100 |
| commit | 670cfb14fcf03ba25221c630d5237750cca52acb (patch) | |
| tree | e82759b250c53b667d0ba3da4911a6a788271c5b | |
| parent | d533bdbbac3531234854db99aa8ca885d49e96a4 (diff) | |
| download | efl-670cfb14fcf03ba25221c630d5237750cca52acb.tar.gz | |
eo: do not check this here
as coverity points out, _obj_is_override is already dereferencing
obj->opt so this was the wrong spot to check this.
CID 1422014
CID 1422013
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11579
| -rw-r--r-- | src/lib/eo/eo.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/src/lib/eo/eo.c b/src/lib/eo/eo.c index 63a73fae51..2bdf284f5f 100644 --- a/src/lib/eo/eo.c +++ b/src/lib/eo/eo.c @@ -1255,10 +1255,9 @@ _eo_free(_Eo_Object *obj, Eina_Bool manual_free EINA_UNUSED) } } #endif - if (_obj_is_override(obj)) + if (obj->opt && _obj_is_override(obj)) { - if (obj->opt) - _vtable_free(obj->opt->vtable, &obj->klass->vtable); + _vtable_free(obj->opt->vtable, &obj->klass->vtable); EO_OPTIONAL_COW_SET(obj, vtable, NULL); } |