diff options
| author | Wonki Kim <wonki_.kim@samsung.com> | 2019-12-06 08:30:51 +0000 |
|---|---|---|
| committer | Marcel Hollerbach <mail@marcel-hollerbach.de> | 2019-12-06 15:35:46 +0100 |
| commit | 1aa5b0c2e88b417c86c3db7ed69874ae02b79137 (patch) | |
| tree | 150878622490fe087a918b4dbb9ca5b6e63462bc | |
| parent | 5894d384f26b5ebd192eb3e659265e4f6c639272 (diff) | |
| download | efl-1aa5b0c2e88b417c86c3db7ed69874ae02b79137.tar.gz | |
collection_view: fix a potentional error
assign signed int value on bigger unsigned variable
can make information of the varaible lost.
this patch fix the problem.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10723
| -rw-r--r-- | src/lib/elementary/efl_ui_collection_view.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/lib/elementary/efl_ui_collection_view.c b/src/lib/elementary/efl_ui_collection_view.c index e5cff428b4..4aca77ceb2 100644 --- a/src/lib/elementary/efl_ui_collection_view.c +++ b/src/lib/elementary/efl_ui_collection_view.c @@ -2302,7 +2302,7 @@ _efl_ui_collection_view_focus_manager_efl_ui_focus_manager_request_move(Eo *obj, new_id = efl_ui_position_manager_entity_relative_item(cpd->manager, item_id, direction); - if (new_id == -1) + if (new_id < 0) { new_item = NULL; } @@ -2326,7 +2326,7 @@ _efl_ui_collection_view_focus_manager_efl_ui_focus_manager_request_move(Eo *obj, _assert_item_available(new_item, new_id, cpd); } #else - uint64_t search_index = new_id; + uint64_t search_index = (uint64_t)new_id; lookup = (void*) eina_rbtree_inline_lookup(cpd->cache, &search_index, sizeof (new_id), _cache_tree_lookup, NULL); |