diff options
| author | Jean Guyomarc'h <jean@guyomarch.bzh> | 2016-08-12 16:20:34 +0200 |
|---|---|---|
| committer | Carsten Haitzler (Rasterman) <raster@rasterman.com> | 2016-08-13 12:31:16 +0900 |
| commit | 6a3d29e8bef083a7928a93df183c60f2e2fa429d (patch) | |
| tree | 56c7c0c743997b60161293c0b5587572d8497cf6 | |
| parent | ddc480b9710cba593b1d71ef7817c43e0e191056 (diff) | |
| download | efl-6a3d29e8bef083a7928a93df183c60f2e2fa429d.tar.gz | |
elementary: fix segmentation faults when using elm_prefs
There are several cases of failure:
- if regex is NULL, regfree(regex) may lead to segmentation fault
(undefined behaviour, as specified in POSIX.1)
- if regex is not NULL, there are cases of use-after-free.
@fix
| -rw-r--r-- | src/modules/elementary/prefs/elm_entry.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/modules/elementary/prefs/elm_entry.c b/src/modules/elementary/prefs/elm_entry.c index 99cb749aaa..7b0395eb71 100644 --- a/src/modules/elementary/prefs/elm_entry.c +++ b/src/modules/elementary/prefs/elm_entry.c @@ -207,7 +207,6 @@ elm_prefs_entry_add(const Elm_Prefs_Item_Iface *iface EINA_UNUSED, elm_entry_markup_filter_append(obj, elm_entry_filter_limit_size, &limit); elm_layout_text_set(obj, NULL, spec.s.placeholder); - regfree(regex); return obj; } |