summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCarsten Haitzler (Rasterman) <raster@rasterman.com>2019-08-05 14:38:10 +0100
committerCarsten Haitzler (Rasterman) <raster@rasterman.com>2019-08-05 15:00:29 +0100
commitb7bc6212bc5c71a9717e46f8a93467340e37abc6 (patch)
tree5915ed0ab697f9ff58b5020cef3dc6af5ff8206f
parent4c6a9520effd885682dd2c296978311f5b54dd79 (diff)
downloadefl-b7bc6212bc5c71a9717e46f8a93467340e37abc6.tar.gz
ecore drm legacy - fix dbus leaks of reply handle
fix CID 1402664
-rw-r--r--src/lib/ecore_drm/ecore_drm_dbus.c11
1 files changed, 10 insertions, 1 deletions
diff --git a/src/lib/ecore_drm/ecore_drm_dbus.c b/src/lib/ecore_drm/ecore_drm_dbus.c
index 7f333f0fc5..686c93c9eb 100644
--- a/src/lib/ecore_drm/ecore_drm_dbus.c
+++ b/src/lib/ecore_drm/ecore_drm_dbus.c
@@ -176,9 +176,11 @@ _ecore_drm_dbus_session_take(void)
if (eldbus_message_error_get(reply, &errname, &errmsg))
{
ERR("Eldbus Message Error: %s %s", errname, errmsg);
+ eldbus_message_unref(reply);
return EINA_FALSE;
}
+ eldbus_message_unref(reply);
return EINA_TRUE;
}
@@ -207,9 +209,11 @@ _ecore_drm_dbus_session_release(void)
if (eldbus_message_error_get(reply, &errname, &errmsg))
{
ERR("Eldbus Message Error: %s %s", errname, errmsg);
+ eldbus_message_unref(reply);
return EINA_FALSE;
}
+ eldbus_message_unref(reply);
return EINA_TRUE;
}
@@ -316,12 +320,17 @@ _ecore_drm_dbus_device_take_no_pending(uint32_t major, uint32_t minor, Eina_Bool
if (eldbus_message_error_get(reply, &errname, &errmsg))
{
ERR("Eldbus Message Error: %s %s", errname, errmsg);
+ eldbus_message_unref(reply);
return -1;
}
if (!eldbus_message_arguments_get(reply, "hb", &fd, &b))
- return -1;
+ {
+ eldbus_message_unref(reply);
+ return -1;
+ }
+ eldbus_message_unref(reply);
if (paused_out) *paused_out = b;
return fd;
}