summaryrefslogtreecommitdiff
path: root/lisp/image-dired.el
Commit message (Collapse)AuthorAgeFilesLines
* Merge from origin/emacs-26Paul Eggert2018-12-311-1/+1
|\ | | | | | | | | | | 2fcf2df Fix copyright years by hand 26bed8b Update copyright year to 2019 2814292 Fix value of default frame height. (Bug#33921)
| * Update copyright year to 2019Paul Eggert2019-01-011-1/+1
| | | | | | | | Run 'TZ=UTC0 admin/update-copyright $(git ls-files)'.
* | file-attributes cleanupPaul Eggert2018-09-231-5/+7
|/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Mostly, this replaces magic-number calls like (nth 4 A) with more-informative calls like (file-attribute-access-time A). It also fixes some documentation and minor timestamp coding issues that I noticed while looking into this. * doc/lispref/files.texi (File Attributes): * lisp/files.el (file-attribute-size) (file-attribute-inode-number, file-attribute-device-number): * src/dired.c (Fdirectory_files_and_attributes) (Ffile_attributes): Mention which attributes must be integers, or nonnegative integers, as opposed to merely being numbers. Remove no-longer-correct talk about representing large integers as conses of integers. * doc/lispref/files.texi (Magic File Names): * doc/misc/gnus.texi (Low-level interface to the spam-stat dictionary): * lisp/autorevert.el (auto-revert-find-file-function) (auto-revert-tail-mode, auto-revert-handler): * lisp/auth-source.el (auth-source-netrc-parse): * lisp/cedet/ede/files.el (ede--inode-for-dir): * lisp/cedet/semantic/db-file.el (object-write): * lisp/cedet/semantic/db-mode.el (semanticdb-kill-hook): * lisp/cedet/semantic/db.el (semanticdb-needs-refresh-p) (semanticdb-synchronize): * lisp/cedet/srecode/table.el (srecode-mode-table-new): * lisp/desktop.el (desktop-save, desktop-read): * lisp/dired-aux.el (dired-file-set-difference) (dired-do-chxxx, dired-do-chmod, dired-copy-file-recursive) (dired-create-files): * lisp/dired.el (dired-directory-changed-p, dired-readin): * lisp/dos-w32.el (w32-direct-print-region-helper): * lisp/emacs-lisp/autoload.el (autoload-generate-file-autoloads) (autoload-find-destination, update-directory-autoloads): * lisp/emacs-lisp/shadow.el (load-path-shadows-same-file-or-nonexistent): * lisp/epg.el (epg--start, epg-wait-for-completion): * lisp/eshell/em-ls.el (eshell-ls-filetype-p) (eshell-ls-applicable, eshell-ls-size-string) (eshell-ls-file, eshell-ls-dir, eshell-ls-files) (eshell-ls-entries): * lisp/eshell/em-pred.el (eshell-predicate-alist) (eshell-pred-file-type, eshell-pred-file-links) (eshell-pred-file-size): * lisp/eshell/em-unix.el (eshell-shuffle-files, eshell/cat) (eshell-du-sum-directory, eshell/du): * lisp/eshell/esh-util.el (eshell-read-passwd) (eshell-read-hosts): * lisp/files.el (remote-file-name-inhibit-cache) (find-file-noselect, insert-file-1, dir-locals-find-file) (dir-locals-read-from-dir, backup-buffer) (file-ownership-preserved-p, copy-directory) (read-file-modes): * lisp/find-lisp.el (find-lisp-format): * lisp/gnus/gnus-agent.el (gnus-agent-unfetch-articles) (gnus-agent-read-agentview, gnus-agent-expire-group-1) (gnus-agent-request-article, gnus-agent-regenerate-group) (gnus-agent-update-files-total-fetched-for) (gnus-agent-update-view-total-fetched-for): * lisp/gnus/gnus-cache.el (gnus-cache-read-active) (gnus-cache-update-file-total-fetched-for) (gnus-cache-update-overview-total-fetched-for): * lisp/gnus/gnus-cloud.el (gnus-cloud-file-new-p): * lisp/gnus/gnus-score.el (gnus-score-score-files): * lisp/gnus/gnus-start.el (gnus-save-newsrc-file) (gnus-master-read-slave-newsrc): * lisp/gnus/gnus-sum.el (gnus-summary-import-article): * lisp/gnus/gnus-util.el (gnus-file-newer-than) (gnus-cache-file-contents): * lisp/gnus/mail-source.el (mail-source-delete-old-incoming) (mail-source-callback, mail-source-movemail): * lisp/gnus/nneething.el (nneething-create-mapping) (nneething-make-head): * lisp/gnus/nnfolder.el (nnfolder-read-folder): * lisp/gnus/nnheader.el (nnheader-file-size) (nnheader-insert-nov-file): * lisp/gnus/nnmail.el (nnmail-activate): * lisp/gnus/nnmaildir.el (nnmaildir--group-maxnum) (nnmaildir--new-number, nnmaildir--update-nov) (nnmaildir--scan, nnmaildir-request-scan) (nnmaildir-request-update-info) (nnmaildir-request-expire-articles): * lisp/gnus/nnmh.el (nnmh-request-list-1) (nnmh-request-expire-articles, nnmh-update-gnus-unreads): * lisp/gnus/nnml.el (nnml-request-expire-articles): * lisp/gnus/spam-stat.el (spam-stat-save, spam-stat-load) (spam-stat-process-directory, spam-stat-test-directory): * lisp/ido.el (ido-directory-too-big-p) (ido-file-name-all-completions): * lisp/image-dired.el (image-dired-get-thumbnail-image) (image-dired-create-thumb-1): * lisp/info.el (info-insert-file-contents): * lisp/ls-lisp.el (ls-lisp-insert-directory) (ls-lisp-handle-switches, ls-lisp-classify-file) (ls-lisp-format): * lisp/mail/blessmail.el: * lisp/mail/feedmail.el (feedmail-default-date-generator) (feedmail-default-message-id-generator): * lisp/mail/mailabbrev.el (mail-abbrevs-sync-aliases) (mail-abbrevs-setup): * lisp/mail/mspools.el (mspools-size-folder): * lisp/mail/rmail.el (rmail-insert-inbox-text): * lisp/mail/sendmail.el (sendmail-sync-aliases): * lisp/mh-e/mh-alias.el (mh-alias-tstamp): * lisp/net/ange-ftp.el (ange-ftp-parse-netrc) (ange-ftp-write-region, ange-ftp-file-newer-than-file-p) (ange-ftp-cf1): * lisp/net/eudcb-mab.el (eudc-mab-query-internal): * lisp/net/eww.el (eww-read-bookmarks): * lisp/net/netrc.el (netrc-parse): * lisp/net/newst-backend.el (newsticker--image-get): * lisp/nxml/rng-loc.el (rng-get-parsed-schema-locating-file): * lisp/obsolete/fast-lock.el (fast-lock-save-cache): * lisp/obsolete/vc-arch.el (vc-arch-state) (vc-arch-diff3-rej-p): * lisp/org/ob-eval.el (org-babel--shell-command-on-region): * lisp/org/org-attach.el (org-attach-commit): * lisp/org/org-macro.el (org-macro-initialize-templates): * lisp/org/org.el (org-babel-load-file) (org-file-newer-than-p): * lisp/org/ox-html.el (org-html-format-spec): * lisp/org/ox-publish.el (org-publish-find-date) (org-publish-cache-ctime-of-src): * lisp/pcmpl-gnu.el (pcomplete/tar): * lisp/pcmpl-rpm.el (pcmpl-rpm-packages): * lisp/play/cookie1.el (cookie-snarf): * lisp/progmodes/cmacexp.el (c-macro-expansion): * lisp/ps-bdf.el (bdf-file-mod-time): * lisp/server.el (server-ensure-safe-dir): * lisp/simple.el (shell-command-on-region): * lisp/speedbar.el (speedbar-item-info-file-helper) (speedbar-check-obj-this-line): * lisp/thumbs.el (thumbs-cleanup-thumbsdir): * lisp/time.el (display-time-mail-check-directory) (display-time-file-nonempty-p): * lisp/url/url-cache.el (url-is-cached): * lisp/url/url-file.el (url-file-asynch-callback): * lisp/vc/diff-mode.el (diff-delete-if-empty): * lisp/vc/pcvs-info.el (cvs-fileinfo-from-entries): * lisp/vc/vc-bzr.el (vc-bzr-state-heuristic): * lisp/vc/vc-cvs.el (vc-cvs-checkout-model) (vc-cvs-state-heuristic, vc-cvs-merge-news) (vc-cvs-retrieve-tag, vc-cvs-parse-status, vc-cvs-parse-entry): * lisp/vc/vc-hg.el (vc-hg--slurp-hgignore-1) (vc-hg--ignore-patterns-valid-p) (vc-hg--cached-dirstate-search, vc-hg-state-fast): * lisp/vc/vc-hooks.el (vc-after-save): * lisp/vc/vc-rcs.el (vc-rcs-workfile-is-newer): * lisp/vc/vc-svn.el (vc-svn-merge-news, vc-svn-parse-status): * lisp/vc/vc.el (vc-checkout, vc-checkin, vc-revert-file): * lisp/xdg.el (xdg-mime-apps): Prefer (file-attribute-size A) to (nth 7 A), and similarly for other file attributes accessors. * doc/lispref/files.texi (File Attributes): * doc/lispref/intro.texi (Version Info): * doc/lispref/os.texi (Idle Timers): * lisp/erc/erc.el (erc-string-to-emacs-time): * lisp/files.el (file-attribute-access-time) (file-attribute-modification-time) (file-attribute-status-change-time): * lisp/net/tramp-compat.el: (tramp-compat-file-attribute-modification-time) (tramp-compat-file-attribute-size): * src/buffer.c (syms_of_buffer): * src/editfns.c (Fget_internal_run_time): * src/fileio.c (Fvisited_file_modtime) (Fset_visited_file_modtime): * src/keyboard.c (Fcurrent_idle_time): * src/process.c (Fprocess_attributes): Defer implementation details about timestamp format to the section that talks about timestamp format, to make it easier to change the documentation later if timestamp formats are extended. * lisp/gnus/gnus-util.el (gnus-file-newer-than): * lisp/speedbar.el (speedbar-check-obj-this-line): * lisp/vc/vc-rcs.el (vc-rcs-workfile-is-newer): Prefer time-less-p to doing it by hand. * lisp/ls-lisp.el (ls-lisp-format): Inode numbers are no longer conses. * lisp/vc/vc-bzr.el (vc-bzr-state-heuristic): Use eql, not eq, to compare integers that might be bignums. * lisp/org/ox-publish.el (org-publish-cache-ctime-of-src): Prefer float-time to doing time arithmetic by hand.
* Update copyright year to 2018Paul Eggert2018-01-011-1/+1
| | | | Run admin/update-copyright.
* Add missing :version tags revealed by cusver-checkGlenn Morris2017-12-121-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | * lisp/comint.el (comint-move-point-for-matching-input): * lisp/epa.el (epa-replace-original-text): * lisp/image-dired.el (image-dired-cmd-optipng-program) (image-dired-cmd-optipng-options): * lisp/emacs-lisp/bytecomp.el (byte-compile-cond-use-jump-table): * lisp/gnus/gnus-cloud.el (gnus-cloud-storage-method) (gnus-cloud-interactive): * lisp/net/mailcap.el (mailcap-user-mime-data): * lisp/progmodes/cc-vars.el (c-asymmetry-fontification-flag) (c-noise-macro-names, c-noise-macro-with-parens-names): * lisp/progmodes/flymake.el (flymake-start-on-flymake-mode) (flymake-wrap-around): * lisp/progmodes/grep.el (grep-use-null-filename-separator): * lisp/progmodes/js.el (js-indent-align-list-continuation): * lisp/progmodes/perl-mode.el (perl-flymake-command): * lisp/progmodes/python.el (python-flymake-command) (python-flymake-command-output-pattern, python-flymake-msg-alist): * lisp/progmodes/ruby-mode.el (ruby-flymake-use-rubocop-if-available) (ruby-rubocop-config): * lisp/textmodes/less-css-mode.el (less-css): * lisp/textmodes/tex-mode.el (tex-chktex-program) (tex-chktex-extra-flags): Add missing :version tags.
* Avoid unnecessary rounding errors in timestampsPaul Eggert2017-10-221-8/+7
| | | | | | | | | | | | | | | | | | | | | Avoid the rounding errors of float-time when it’s easy. E.g., replace (< (float-time a) (float-time b)) with (time-less-p a b). * lisp/desktop.el (desktop-save): * lisp/ecomplete.el (ecomplete-add-item): * lisp/epg.el (epg-wait-for-completion): * lisp/files.el (dir-locals-find-file, dir-locals-read-from-dir): * lisp/image-dired.el (image-dired-get-thumbnail-image) (image-dired-create-thumb-1): * lisp/info.el (info-insert-file-contents): * lisp/ls-lisp.el (ls-lisp-format-time): * lisp/net/ange-ftp.el (ange-ftp-file-newer-than-file-p) (ange-ftp-verify-visited-file-modtime): * lisp/net/rcirc.el (rcirc-ctcp-sender-PING): * lisp/textmodes/remember.el (remember-store-in-mailbox): * lisp/url/url-cookie.el (url-cookie-expired-p): Bypass float-time to avoid rounding errors. * lisp/files.el (dir-locals-find-file):
* Fix range-error in image-dired.elEli Zaretskii2017-10-161-1/+4
| | | | | * lisp/image-dired.el (image-dired-create-thumb-1): Avoid overflowing an Emacs integer on 32-bit hosts. (Bug#28809)
* Prefer HTTPS to FTP and HTTP in documentationPaul Eggert2017-09-131-1/+1
| | | | | | | | | | | | | Most of this change is to boilerplate commentary such as license URLs. This change was prompted by ftp://ftp.gnu.org's going-away party, planned for November. Change these FTP URLs to https://ftp.gnu.org instead. Make similar changes for URLs to other organizations moving away from FTP. Also, change HTTP to HTTPS for URLs to gnu.org and fsf.org when this works, as this will further help defend against man-in-the-middle attacks (for this part I omitted the MS-DOS and MS-Windows sources and the test tarballs to keep the workload down). HTTPS is not fully working to lists.gnu.org so I left those URLs alone for now.
* Nix some useless uses of looking-at, looking-backMark Oteiza2017-02-121-2/+2
| | | | | | | | | | | | | | | | | | | | * lisp/allout.el (allout-kill-topic): (allout-next-topic-pending-encryption): * lisp/bookmark.el (bookmark-kill-line): * lisp/cus-edit.el (custom-save-variables, custom-save-faces): * lisp/cus-theme.el (custom-theme-write-variables): (custom-theme-write-faces): * lisp/emacs-lisp/autoload.el (autoload-generate-file-autoloads): * lisp/emacs-lisp/bytecomp.el (byte-compile-from-buffer): * lisp/emacs-lisp/checkdoc.el (checkdoc-interactive-loop): (checkdoc-interactive-ispell-loop): (checkdoc-message-interactive-ispell-loop, checkdoc-this-string-valid): (checkdoc-this-string-valid-engine): * lisp/emacs-lisp/elint.el (elint-get-top-forms): * lisp/emulation/viper-cmd.el (viper-backward-indent): * lisp/image-dired.el (image-dired-delete-char): * lisp/simple.el (kill-visual-line): Replace instances of looking-at, looking-back with char comparisons using following-char, preceding-char.
* Prevent creating thumbnails of all gif framesMark Oteiza2017-02-011-3/+5
| | | | | | | | | | | | | | With the previous defaults, doing image-dired on a directory with an animated foo.gif would cause creation of foo.thumb-N.gif for each of N frames in foo.gif. By default image-dired looks for foo.thumb.gif, so there additionally is no usable thumbnail after all the needless effort. image-dired never handled animation, regardless. * lisp/image-dired.el: Mention limitation. (image-dired-cmd-create-thumbnail-options): (image-dired-cmd-create-temp-image-options): (image-dired-cmd-create-standard-thumbnail-options): Append [0] to filename to indicate only converting the 0th frame. (image-dired-display-image-mode): Don't show a cursor.
* Merge from origin/emacs-25Paul Eggert2017-01-011-1/+1
|\ | | | | | | | | 2e2a806 Fix copyright years by hand 5badc81 Update copyright year to 2017
| * Update copyright year to 2017Paul Eggert2016-12-311-1/+1
| | | | | | | | Run admin/update-copyright.
* | ; Spelling fixesPaul Eggert2016-12-221-4/+4
| |
* | ; Revert "Recognize graphicsmagick in image-dired"Mark Oteiza2016-12-201-33/+15
| | | | | | | | | | | | This reverts commit 5c266405f559823038dfa900aaad66605f0d5287. There are too many annoying differences between GM and IM to make this default behavior.
* | Recognize graphicsmagick in image-diredMark Oteiza2016-12-191-15/+33
| | | | | | | | | | | | | | | | | | | | | | * lisp/image-dired.el (image-dired-cmd-create-thumbnail-program): (image-dired-cmd-create-thumbnail-options): (image-dired-cmd-create-temp-image-program): (image-dired-cmd-create-temp-image-options): (image-dired-cmd-create-standard-thumbnail-options): (image-dired-cmd-rotate-thumbnail-program): (image-dired-cmd-rotate-thumbnail-options): Account for existence of gm(1) executable.
* | Implement asynchronous thumbnail generation in image-diredMark Oteiza2016-12-191-140/+285
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Additionally, all FOO-options defcustoms that were in fact shell command strings have been converted to argument lists. Another method for shrinking PNG thumbs with optipng(1) has been added. * lisp/image-dired.el: Remove TODO item in commentary. (image-dired-cmd-create-thumbnail-options): (image-dired-cmd-create-temp-image-options): (image-dired-cmd-rotate-thumbnail-options): (image-dired-cmd-rotate-original-options): (image-dired-cmd-write-exif-data-options): (image-dired-cmd-read-exif-data-options): Convert to argument lists. (image-dired-cmd-pngnq-program, image-dired-cmd-pngcrush-program): Change string type to file. (image-dired-cmd-create-standard-thumbnail-command): Remove. (image-dired-cmd-pngnq-options): (image-dired-cmd-create-standard-thumbnail-options): (image-dired-cmd-optipng-program, image-dired-cmd-optipng-options): New defcustoms. (image-dired-queue, image-dired-queue-active-jobs): (image-dired-queue-active-limit): New variables. (image-dired-pngnq-thumb, image-dired-pngcrush-thumb): (image-dired-optipng-thumb): New functions. (image-dired-create-thumb-1): Renamed from image-dired-create-thumb. Use start-process instead of call-process. Set file modes. Trigger PNG file optimization in process sentinel. (image-dired-thumb-queue-run, image-dired-create-thumb): New functions. (image-dired-display-thumbs): (image-dired-create-thumbs): Don't expect call-process return value. (image-dired-display-image, image-dired-rotate-thumbnail): Use start-process instead of call-process. (image-dired-rotate-original, image-dired-set-exif-data): (image-dired-get-exif-data): Adapt to arguments being an arg list.
* | Bind new image-mode scroll commands in image-diredMark Oteiza2016-12-181-0/+2
| | | | | | | | | | * lisp/image-dired.el (image-dired-display-image-mode-map): Add bindings to new image-mode commands.
* | Use floor of mtime instead of rounding for thumb propertyMark Oteiza2016-12-181-2/+1
| | | | | | | | | | | | | | | | | | | | This seems to be the correct thing to do, at least more in line with what at least one other implementation does. Anything using gnome-desktop [0] effectively does the same, as gnome_desktop_thumbnail_is_valid applies atol(3) to mtime for comparison and time_t on GNU/Linux is a signed int. [0] https://git.gnome.org/browse/gnome-desktop/ * lisp/image-dired.el (image-dired-create-thumb): Use floor here.
* | Be more selective clearing the image cacheMark Oteiza2016-12-161-11/+11
| | | | | | | | | | | | * lisp/image-dired.el (image-dired-create-thumbs): (image-dired-rotate-thumbnail, image-dired-refresh-thumb): Only clear the current thumbnail file from the image cache.
* | More image-dired refactoringMark Oteiza2016-12-151-14/+11
| | | | | | | | | | | | | | | | | | * lisp/image-dired.el (image-dired-thumbnail-mode): (image-dired-display-image-mode): Add :group 'image-dired so customize-mode works. (image-dired-display-image): Rearrange. (image-dired-copy-with-exif-file-name): This map is for side effect. (image-dired-dired-edit-comment-and-tags): Just use #'identity.
* | * lisp/image-dired.el: Turn on lexical-binding.Mark Oteiza2016-12-151-1/+1
| |
* | Teach image-dired to also generate large thumbsMark Oteiza2016-12-151-15/+28
| | | | | | | | | | | | | | | | | | | | * lisp/image-dired.el (image-dired-thumbnail-storage): Add standard-large option. (image-dired-thumb-size): Add condition for standard-large storage. (image-dired-insert-thumbnail): Check for new option. Change thumbnail path conditionally. (image-dired-thumb-size): New function. (image-dired-create-thumb, image-dired-line-up-dynamic): Use it.
* | Don't abuse princ and spam messagesMark Oteiza2016-12-151-12/+8
| | | | | | | | | | | | | | * lisp/image-dired.el (image-dired-format-properties-string): Nix princ. (image-dired-display-thumb-properties): (image-dired-dired-display-properties): Nix princ. Bind message-log-max to nil.
* | Inherit things from special-mode and image-modeMark Oteiza2016-12-151-4/+23
| | | | | | | | | | | | | | | | | | | | * lisp/image-dired.el: Require image-mode library. (image-dired-thumbnail-mode-map): Remove superfluous binding. (image-dired-display-image-mode-map): Remove superfluous binding. Add movement remaps from image-mode-map. (image-dired-thumbnail-mode): Derive from special-mode. (image-dired-display-image-mode): Derive from special-mode. Call image-mode-setup-winprops.
* | Fix some image-dired customization typesMark Oteiza2016-12-151-19/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * lisp/image-dired.el (image-dired): Add info link to defgroup. (image-dired-dir, image-dired-gallery-dir): Set type to directory. (image-dired-db-file, image-dired-temp-image-file): (image-dired-cmd-create-thumbnail-program): (image-dired-cmd-create-temp-image-program): (image-dired-cmd-rotate-thumbnail-program): (image-dired-cmd-rotate-original-program): (image-dired-temp-rotate-image-file): (image-dired-cmd-write-exif-data-program): (image-dired-cmd-read-exif-data-program): Set type to file. (image-dired-create-thumb, image-dired-line-up-dynamic): Check storage type at runtime, since setting image-dired-thumb-size does not automatically set image-dired-thumb-width and image-dired-thumb-height.
* | * lisp/image-dired.el (image-dired-create-thumb): Create parent directories.Mark Oteiza2016-12-141-1/+1
| |
* | Recognize pngnq or pngnq-s9Mark Oteiza2016-12-141-2/+6
| | | | | | | | | | * lisp/image-dired.el (image-dired-cmd-pngnq-program): Also consider pngnq-s9 as a possible executable.
* | Update standard image-dired thumbnail locationMark Oteiza2016-12-141-3/+6
| | | | | | | | | | * lisp/image-dired.el (image-dired-thumb-name): Conform to the latest standard: consider XDG_CACHE_HOME, falling back on ~/.cache.
* | Reset window scroll when displaying an imageMark Oteiza2016-12-141-8/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | When viewing a large image full size and scrolling, for instance, to the lower right corner, then selecting a much smaller image in the thumbnail buffer, the window stays scrolled so the new image is out of the window. One must scroll back to the "origin" to view the new displayed image, or just kill the image-dired-display-image buffer and try again. This fixes the issue. * lisp/image-dired.el (image-dired-display-window-width): (image-dired-display-window-height): Operate on a window as argument. (image-dired-display-image): Bind (image-dired-display-window) and use it. Set window vscroll and hscroll to zero when refreshing the buffer's contents.
* | More image-dired polishMark Oteiza2016-12-131-6/+14
| | | | | | | | | | | | | | | | | | | | * lisp/image-dired.el (image-dired-file-name-at-point): New function. (image-dired-thumbnail-mode, image-dired-display-image-mode): Disable undo list. Add image-dired-file-name-at-point to file-name-at-point-functions to facilitate find-file and friends. (image-dired-thumbnail-display-external): (image-dired-dired-display-external): Use start-process instead, to avoid needlessly blocking and using a shell.
* | More small fixes for image-diredMark Oteiza2016-12-131-8/+4
| | | | | | | | | | | | | | | | * lisp/image-dired.el: Fix commentary to refer to correct Emacs manual node. (image-dired--with-db-file): Add declare forms. (image-dired-hidden-p): Rewrite with cl-loop. It's not necessary to run through the whole list.
* | Remove image-dired-kill-buffer-and-windowMark Oteiza2016-12-131-13/+4
| | | | | | | | | | | | | | | | | | This breaks window layout, especially when quitting a image-dired-display-image-mode buffer. * lisp/image-dired.el (image-dired-thumbnail-mode-map): (image-dired-display-image-mode-map): Replace in keymap and menu items bindings to image-dired-kill-buffer-and-window with quit-window. (image-dired-kill-buffer-and-window): Remove.
* | Replace image-dired-setup-dired-keybindings with a minor modeMark Oteiza2016-12-131-89/+55
| | | | | | | | | | | | | | | | | | | | | | | | | | | | * lisp/image-dired.el (image-dired-thumbnail-mode): Fix docstring to remove mention of nonexistent image-dired-dired and to refer to the new minor mode. (image-dired-minor-mode-map): New keymap assimilated from image-dired-setup-dired-keybindings. In the future, the keymap parent should be removed, and perhaps also the duplicate bindings that already exist in dired-mode-map. (image-dired-setup-dired-keybindings): Remove. Replace with an obsolete function alias. (image-dired-minor-mode): New minor mode, assuming the role of image-dired-setup-dired-keybindings.
* | ; Fix previous commitMark Oteiza2016-12-071-5/+4
| |
* | More image-dired refactoringMark Oteiza2016-12-041-29/+21
| | | | | | | | | | | | | | | | | | | | | | * lisp/image-dired.el: Remove TODO comment. This appears to have been implemented in 5d7433a "image-dired: Signal an error before calling a missing executable". (image-dired-cmd-create-standard-thumbnail-command): Use %p specifier. Add :version. (image-dired-display-thumbs, image-dired-create-thumbs): Use dolist and when. Remove superfluous call to image-dired-thumb-name. Move single nil binding and setq into dolist form.
* | Clean up keymap and menu code in image-diredMark Oteiza2016-12-031-189/+111
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A function to populate these maps is not necessary, just define the maps once and for all. * lisp/image-dired.el (image-dired-show-all-from-dir): Make prompt clearer and in the spirit of dired's. (image-dired-define-display-image-mode-keymap): (image-dired-define-thumbnail-mode-keymap): Remove. (image-dired-thumbnail-mode-map): (image-dired-thumbnail-mode-line-up-map): (image-dired-thumbnail-mode-tag-map): Assimilate all define-key and mode menu code from the aforementioned removed functions. Reorder so that the definitions are inherited properly. (image-dired-display-current-image-sized): Fix erroneous message. (image-dired-thumbnail-mode): (image-dired-display-image-mode): Remove defunct call.
* | Clean up uses of cl-foo in image-diredMark Oteiza2016-12-031-13/+9
| | | | | | | | | | | | | | Both instances here are just emulating cl-find-if. * lisp/image-dired.el: Use cl-lib at compile time. (image-dired-dired-toggle-marked-thumbs): Don't need let* at the top. Replace the cl-foo instances with equivalent cl-loops.
* | Display window before calculating widthMark Oteiza2016-12-031-4/+4
| | | | | | | | | | | | | | * lisp/image-dired.el (image-dired-display-thumbs): Display the buffer before calling image-dired-line-up and friends, which in turn calculate the window width. Otherwise, the thumbnail layout will be wrong in a side-by-side split.
* | Use pop-to-buffer-same-windowMark Oteiza2016-12-031-5/+5
| | | | | | | | | | | | | | * lisp/image-dired.el (image-dired-dired-with-window-configuration): (image-dired-dired-edit-comment-and-tags): Instead of switch-to-buffer, use pop-to-buffer-same-window cf. Bug#22244. (image-dired-forward-image, image-dired-backward-image): Ignore unused.
* | image-dired: Signal an error before calling a missing executableTino Calancha2016-09-131-52/+50
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Reverts commit ca473907 Add a defun to check if an executable exists, and call it on each function using an external program: when the executable is not available signal an error. See discussion on: https://lists.gnu.org/archive/html/emacs-devel/2016-09/msg00135.html * lisp/image-dired.el (image-dired--check-executable-exists): New defun. Throw and error when the executable arg is missing. (image-dired-display-image, image-dired-rotate-thumbnail) (image-dired-rotate-original, image-dired-set-exif-data) (image-dired-get-exif-data): Use it.
* | image-dired: Report when a necessary executable is not foundTino Calancha2016-09-041-36/+56
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | See discussion on: https://lists.gnu.org/archive/html/emacs-devel/2016-08/msg00552.html * lisp/image-dired.el (image-dired-cmd-rotate-original-program) (image-dired-cmd-create-thumbnail-program) (image-dired-cmd-create-temp-image-program) (image-dired-cmd-rotate-thumbnail-program) (image-dired-cmd-write-exif-data-program) (image-dired-cmd-read-exif-data-program): Use executable-find to set the defaut value of this option. (image-dired-cmd-rotate-original-program): Idem. Search for program 'convert' if 'jpegtran' is not available. (image-dired-cmd-rotate-original-options): Set the default value consistent with the executable in image-dired-cmd-rotate-original-program. (image-dired-create-thumb, image-dired-display-image) (image-dired-rotate-thumbnail, image-dired-rotate-original) (image-dired-set-exif-data, image-dired-get-exif-data): Throw and error when the executable used in the function is missing. (image-dired-next-line, image-dired-previous-line): Use 'forward-line'.
* | image-type-from-file-name: Perform a case insensitive matchTino Calancha2016-09-041-10/+9
| | | | | | | | | | | | | | | | | | | | | | Fix Bug#24317 * lisp/image.el (image-type-from-file-name): Bind case-fold-search to a non-nil value to force a case insensitive match. * lisp/image-dired.el (image-dired-rotate-original): Use image-type (Bug#24317). (image-dired-get-exif-file-name): Idem. Set 'no-exif-data-found' and 'data' in same setq call. Use file-attribute-modification-time.
* | Preserve current column, going up/down in thumbnail view.Mathias Dahl2016-02-291-2/+4
|/
* Update copyright year to 2016Paul Eggert2016-01-011-1/+1
| | | | Run admin/update-copyright.
* Fix docstring quoting problems with ‘ '’Paul Eggert2015-11-171-2/+2
| | | | | | | | | | | | | Problem reported by Artur Malabarba in: http://lists.gnu.org/archive/html/emacs-devel/2015-11/msg01513.html Most of these fixes are to documentation; many involve fixing longstanding quoting glitches that are independent of the recent substitute-command-keys changes. The changes to code are: * lisp/cedet/mode-local.el (mode-local-augment-function-help) (describe-mode-local-overload): Substitute docstrings before displaying them. * lisp/emacs-lisp/cl-macs.el (cl--transform-lambda): Quote the generated docstring for later substitution.
* Fix several backslash typos in Elisp stringsPaul Eggert2015-09-171-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * lisp/calendar/todo-mode.el (todo-files, todo-rename-file) (todo-find-filtered-items-file, todo-reset-nondiary-marker) (todo-reset-done-string, todo-reset-comment-string) (todo-reset-highlight-item): * lisp/erc/erc-networks.el (erc-networks-alist): * lisp/gnus/gnus-art.el (gnus-button-handle-library): * lisp/gnus/gnus-group.el (gnus-read-ephemeral-gmane-group-url): * lisp/gnus/nntp.el (nntp-via-shell-prompt) (nntp-telnet-shell-prompt): * lisp/gnus/spam-report.el (spam-report-gmane-regex): * lisp/image-dired.el (image-dired-rotate-original): (image-dired-get-exif-file-name): * lisp/international/latin1-disp.el (latin1-display-ucs-per-lynx): * lisp/mail/undigest.el (rmail-digest-parse-rfc1153strict): * lisp/mh-e/mh-letter.el (mh-file-is-vcard-p): * lisp/mh-e/mh-mime.el (mh-file-mime-type-substitutions): * lisp/net/shr-color.el (shr-color->hexadecimal): * lisp/org/org-bibtex.el (org-bibtex-fields): * lisp/org/org-docview.el (org-docview-export): * lisp/org/org-entities.el (org-entities): * lisp/org/ox-icalendar.el (org-icalendar-cleanup-string): * lisp/progmodes/cperl-mode.el (cperl-indent-exp): * lisp/progmodes/ebnf2ps.el (ebnf-file-suffix-regexp) (ebnf-style-database): * lisp/progmodes/idlw-help.el (idlwave-do-context-help1): * lisp/progmodes/ruby-mode.el (ruby-imenu-create-index-in-block): * lisp/progmodes/sql.el (sql-product-alist): * lisp/progmodes/verilog-mode.el (verilog-error-regexp-emacs-alist) (verilog-error-font-lock-keywords) (verilog-assignment-operator-re): * lisp/progmodes/vhdl-mode.el (vhdl-compiler-alist): * lisp/textmodes/reftex-parse.el (reftex-parse-from-file): * lisp/vc/add-log.el (change-log-version-number-regexp-list): Fix typo by replacing ‘\’ with ‘\\’ in a string literal. For example, to get the regular expression ‘\.’ use the string literal "\\.", not "\." (which is equivalent to "."). * lisp/emulation/viper-util.el (viper-glob-unix-files): Remove stray ‘\j’ from string. * lisp/gnus/nntp.el (nntp-via-shell-prompt) (nntp-telnet-shell-prompt): Treat > like $ when matching a shell prompt. * lisp/progmodes/make-mode.el (makefile-browse): Properly quote a diagnostic.
* Update copyright year to 2015Paul Eggert2015-01-011-1/+1
| | | | Run admin/update-copyright.
* Spelling fixes.Paul Eggert2014-01-051-1/+1
| | | | | | | | | | | | | | | | * calc/calc-yank.el (calc-edit-mode, calc-edit-cancel): * emacs-lisp/debug.el (cancel-debug-on-entry): * epg.el (epg-error-to-string): * files.el (recover-file): * lpr.el (lpr-buffer, print-buffer, lpr-region, print-region): * mail/emacsbug.el (report-emacs-bug-hook): * mail/sendmail.el (mail-recover): * ses.el (ses-yank-resize): * term/ns-win.el (ns-print-buffer): Spelling fixes in diagnostics, mostly for "canceled" with one L. * epg.el (epg-key-capability-alist): Rename from misspelled version. All uses changed. * obsolete/xesam.el (xesam-all-fields): Fix misspelled field name.
* Update copyright year to 2014 by running admin/update-copyright.Paul Eggert2014-01-011-1/+1
|
* image-dired.el: use with-current-bufferGlenn Morris2013-07-201-25/+21
| | | | | | | * lisp/image-dired.el (image-dired-track-original-file): Use with-current-buffer. (image-dired-track-thumbnail): Use with-current-buffer. Avoid changing point of wrong window.
View Lorry Controller Status