diff options
author | Paul Eggert <eggert@cs.ucla.edu> | 2013-07-11 19:03:47 -0700 |
---|---|---|
committer | Paul Eggert <eggert@cs.ucla.edu> | 2013-07-11 19:03:47 -0700 |
commit | bacba3c26522ef297662bace31947d3e4f47c87a (patch) | |
tree | 7937ff9ad18bca16aff3ecf1f791632a8dec2ce3 /src/callproc.c | |
parent | 1048af7c8ff6e8a84f802fbe655b95c261a6afc0 (diff) | |
download | emacs-bacba3c26522ef297662bace31947d3e4f47c87a.tar.gz |
Fix races with threads and file descriptors.
* configure.ac (PTY_TTY_NAME_SPRINTF): Use emacs_close, not close.
* src/callproc.c (Fcall_process_region):
* src/dired.c (open_directory):
* src/emacs.c (main, Fdaemon_initialized):
* src/image.c (x_find_image_file):
* src/inotify.c (Finotify_rm_watch):
* src/lread.c (Flocate_file_internal):
* src/process.c (Fnetwork_interface_list, Fnetwork_interface_info):
* src/term.c (term_mouse_moveto, init_tty):
* src/termcap.c (tgetent):
* src/unexaix.c, src/unexcoff.c (report_error, report_error_1, adjust_lnnoptrs)
* src/unexaix.c, src/unexcoff.c, src/unexcw.c, src/unexelf.c (unexec):
* src/unexhp9k800.c, src/unexmacosx.c (unexec):
* src/callproc.c (Fcall_process_region):
Use emacs_close, not close.
* src/sysdep.c (POSIX_CLOSE_RESTART, posix_close) [!POSIX_CLOSE_RESTART]:
New macro and function, which emulates the POSIX_CLOSE_RESTART macro
and posix_close function on current platforms (which all lack them).
(emacs_close): Use it. This should fix the races on GNU/Linux and
on AIX and on future platforms that support POSIX_CLOSE_RESTART,
and it should avoid closing random victim file descriptors on
other platforms.
Diffstat (limited to 'src/callproc.c')
-rw-r--r-- | src/callproc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/callproc.c b/src/callproc.c index fc274f3d9c0..ac9477bff10 100644 --- a/src/callproc.c +++ b/src/callproc.c @@ -1052,7 +1052,7 @@ usage: (call-process-region START END PROGRAM &optional DELETE BUFFER DISPLAY &r report_file_error ("Failed to open temporary file", Fcons (build_string (tempfile), Qnil)); else - close (fd); + emacs_close (fd); } #else errno = 0; |