summaryrefslogtreecommitdiff
path: root/lisp
diff options
context:
space:
mode:
authorGlenn Morris <rgm@gnu.org>2012-08-06 00:10:27 -0700
committerGlenn Morris <rgm@gnu.org>2012-08-06 00:10:27 -0700
commite296d94b3369d05eeeeffde728a8bf5de885c720 (patch)
treeb5cddc2d9495307d823e2f08542d7ac0bfdb43d5 /lisp
parent90749b537a83a3ba623e6f6163256130575fac2f (diff)
downloademacs-e296d94b3369d05eeeeffde728a8bf5de885c720.tar.gz
* lisp/eshell/esh-ext.el (eshell/addpath): Use mapconcat.
Diffstat (limited to 'lisp')
-rw-r--r--lisp/ChangeLog2
-rw-r--r--lisp/eshell/esh-ext.el12
2 files changed, 7 insertions, 7 deletions
diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index 8867ec557e5..8088a51f591 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -21,7 +21,7 @@
2012-08-06 Glenn Morris <rgm@gnu.org>
- * eshell/esh-ext.el (eshell/addpath): Use dolist.
+ * eshell/esh-ext.el (eshell/addpath): Use dolist and mapconcat.
Do less getting and setting of environment variables.
2012-08-05 Chong Yidong <cyd@gnu.org>
diff --git a/lisp/eshell/esh-ext.el b/lisp/eshell/esh-ext.el
index c0add0443cb..52df1587d5f 100644
--- a/lisp/eshell/esh-ext.el
+++ b/lisp/eshell/esh-ext.el
@@ -226,12 +226,12 @@ causing the user to wonder if anything's really going on..."
Adds the given PATH to $PATH.")
(if args
(progn
- (setq eshell-path-env (getenv "PATH"))
- (dolist (dir (if prepend (nreverse args) args))
- (setq eshell-path-env
- (if prepend
- (concat dir path-separator eshell-path-env)
- (concat eshell-path-env path-separator dir))))
+ (setq eshell-path-env (getenv "PATH")
+ args (mapconcat 'identity args path-separator)
+ eshell-path-env
+ (if prepend
+ (concat args path-separator eshell-path-env)
+ (concat eshell-path-env path-separator args)))
(setenv "PATH" eshell-path-env))
(dolist (dir (parse-colon-path (getenv "PATH")))
(eshell-printn dir)))))