summaryrefslogtreecommitdiff
path: root/lisp/password-cache.el
diff options
context:
space:
mode:
authorPaul Eggert <eggert@cs.ucla.edu>2020-05-16 22:23:28 -0700
committerPaul Eggert <eggert@cs.ucla.edu>2020-05-16 22:25:07 -0700
commit313955110b242cd18fc19bd168032d3ddf39fe94 (patch)
tree4292cf3b216b6a76e5c28e3841c2f6fa2f56caf3 /lisp/password-cache.el
parent1fc4e3fb3f6caba6a4ca69060c7992ea5d24ff36 (diff)
downloademacs-313955110b242cd18fc19bd168032d3ddf39fe94.tar.gz
Don’t attempt to modify constant strings
* lisp/bookmark.el (bookmark-bmenu-set-header): Use copy-sequence instead of concat, for clarity. Also, the byte-compiler optimizes (concat "a" "b") into "ab". * lisp/button.el (make-text-button): * test/lisp/erc/erc-track-tests.el (erc-track--erc-faces-in): * test/lisp/password-cache-tests.el: (password-cache-tests-add-and-remove) (password-cache-tests-read-from-cache) (password-cache-tests-in-cache-p, password-cache-tests-read) (password-cache-tests-reset) (password-cache-tests-add/expires-key) (password-cache-tests-no-password-cache): Don’t attempt to modify constant strings. * lisp/progmodes/elisp-mode.el (elisp--xref-format) (elisp--xref-format-extra): Don’t attempt to modify constant strings via put-text-property. * test/lisp/emacs-lisp/cl-macs-tests.el (cl-macs-loop-across-ref): Don’t attempt to modify constant vectors or strings.
Diffstat (limited to 'lisp/password-cache.el')
-rw-r--r--lisp/password-cache.el2
1 files changed, 1 insertions, 1 deletions
diff --git a/lisp/password-cache.el b/lisp/password-cache.el
index 5e5f3240bc3..86d802f283c 100644
--- a/lisp/password-cache.el
+++ b/lisp/password-cache.el
@@ -31,7 +31,7 @@
;; ;; Minibuffer prompt for password.
;; => "foo"
;;
-;; (password-cache-add "test" "foo")
+;; (password-cache-add "test" (copy-sequence "foo"))
;; => nil
;; (password-read "Password? " "test")