summaryrefslogtreecommitdiff
path: root/lisp/org
diff options
context:
space:
mode:
authorMattias EngdegÄrd <mattiase@acm.org>2020-02-01 18:07:32 +0100
committerMattias EngdegÄrd <mattiase@acm.org>2020-02-01 22:27:23 +0100
commit32763dac46e61cc34e8fe4d19df4905d09c1a27f (patch)
treee7f831860af5d3a412dc3dcfbdb958fa23cbd5b3 /lisp/org
parentd07f177382b24945e1f579744702908b33605c3e (diff)
downloademacs-32763dac46e61cc34e8fe4d19df4905d09c1a27f.tar.gz
Replace add-to-list to lexical variable with push (bug#39373)
Since 'add-to-list', being a plain function, cannot access lexical variables, such use must be rewritten for correctness. (Some instances actually do work thanks to a compiler macro, but it's not something code should rely on.) * lisp/autoinsert.el (auto-insert-alist): * lisp/cedet/mode-local.el (mode-local-print-bindings): * lisp/net/tramp-cache.el (tramp-flush-connection-properties) (tramp-list-connections): * lisp/net/zeroconf.el (zeroconf-list-service-names) (zeroconf-list-service-types, zeroconf-list-services): * lisp/org/org.el (org-reload): * lisp/whitespace.el (whitespace-report-region): * test/lisp/emacs-lisp/map-tests.el (test-map-do): Replace add-to-list with push.
Diffstat (limited to 'lisp/org')
-rw-r--r--lisp/org/org.el5
1 files changed, 3 insertions, 2 deletions
diff --git a/lisp/org/org.el b/lisp/org/org.el
index 5c8b02b9d1f..568f5b9b873 100644
--- a/lisp/org/org.el
+++ b/lisp/org/org.el
@@ -18682,13 +18682,14 @@ With prefix arg UNCOMPILED, load the uncompiled versions."
(and (string= org-dir contrib-dir)
(org-load-noerror-mustsuffix (concat contrib-dir f)))
(and (org-load-noerror-mustsuffix (concat (org-find-library-dir f) f))
- (add-to-list 'load-uncore f 'append)
+ (push f load-uncore)
't)
f))
lfeat)))
(when load-uncore
(message "The following feature%s found in load-path, please check if that's correct:\n%s"
- (if (> (length load-uncore) 1) "s were" " was") load-uncore))
+ (if (> (length load-uncore) 1) "s were" " was")
+ (reverse load-uncore)))
(if load-misses
(message "Some error occurred while reloading Org feature%s\n%s\nPlease check *Messages*!\n%s"
(if (> (length load-misses) 1) "s" "") load-misses (org-version nil 'full))