summaryrefslogtreecommitdiff
path: root/lisp/ibuf-ext.el
diff options
context:
space:
mode:
authorGlenn Morris <rgm@gnu.org>2011-02-02 23:02:52 -0800
committerGlenn Morris <rgm@gnu.org>2011-02-02 23:02:52 -0800
commitdf27585129eda912634720f8185379de1c0de08d (patch)
treedac2d2a1bc11e80e46b6921327091c0b55e70ebb /lisp/ibuf-ext.el
parent95838641ae01abb8589c99512dfd5ed6bccf25dc (diff)
downloademacs-df27585129eda912634720f8185379de1c0de08d.tar.gz
* lisp/ibuf-ext.el (ibuffer-filter-disable): Make it work. (Bug#7969)
Details: An error in a filter would cause an infinite loop. ibuffer-update calls ibuffer-redisplay-engine which calls ibuffer-update which calls ibuffer-redisplay-engine, etc. ibuffer-generate-filter-groups calls ibuffer-included-in-filters-p. If ibuffer-included-in-filter-p-1 meets an unknown element in the filter, it calls ibuffer-filter-disable, which calls ibuffer-update. If the filters have not been properly disabled, we go round and round.
Diffstat (limited to 'lisp/ibuf-ext.el')
-rw-r--r--lisp/ibuf-ext.el3
1 files changed, 2 insertions, 1 deletions
diff --git a/lisp/ibuf-ext.el b/lisp/ibuf-ext.el
index d09a6cfa690..95a753c6add 100644
--- a/lisp/ibuf-ext.el
+++ b/lisp/ibuf-ext.el
@@ -780,7 +780,8 @@ The value from `ibuffer-saved-filter-groups' is used."
(defun ibuffer-filter-disable ()
"Disable all filters currently in effect in this buffer."
(interactive)
- (setq ibuffer-filtering-qualifiers nil)
+ (setq ibuffer-filtering-qualifiers nil
+ ibuffer-filter-groups nil)
(let ((buf (ibuffer-current-buffer)))
(ibuffer-update nil t)
(when buf