diff options
author | Chong Yidong <cyd@stupidchicken.com> | 2010-11-27 15:04:57 -0500 |
---|---|---|
committer | Chong Yidong <cyd@stupidchicken.com> | 2010-11-27 15:04:57 -0500 |
commit | 07976ae3b816dea4fd541bbba862603d3132eb2c (patch) | |
tree | 4a437b7cb3abb01fb144530a130c991882a1b7f2 /lisp/gnus | |
parent | 9610796712a3bc43730c99005906571a2c0bccbd (diff) | |
parent | 402c8a49571227f8a4e678d4a6cdd6ba7841aef9 (diff) | |
download | emacs-07976ae3b816dea4fd541bbba862603d3132eb2c.tar.gz |
Merge changes from emacs-23 branch
Diffstat (limited to 'lisp/gnus')
-rw-r--r-- | lisp/gnus/ChangeLog | 5 | ||||
-rw-r--r-- | lisp/gnus/pop3.el | 19 |
2 files changed, 15 insertions, 9 deletions
diff --git a/lisp/gnus/ChangeLog b/lisp/gnus/ChangeLog index 3ae3c5bc740..651cfef7f00 100644 --- a/lisp/gnus/ChangeLog +++ b/lisp/gnus/ChangeLog @@ -1,3 +1,8 @@ +2010-11-27 Yuri Karaban <tech@askold.net> (tiny change) + + * pop3.el (pop3-open-server): Read server greeting before starting TLS + negotiation. + 2010-11-26 Julien Danjou <julien@danjou.info> * color.el: Rename various rgb functions to srgb. diff --git a/lisp/gnus/pop3.el b/lisp/gnus/pop3.el index 327c5297492..eef53c2797d 100644 --- a/lisp/gnus/pop3.el +++ b/lisp/gnus/pop3.el @@ -327,21 +327,22 @@ Returns the process associated with the connection." ;; gnutls-cli, openssl don't accept service names (if (equal port "pop3") (setq port 110)) - (let ((process (starttls-open-stream "POP" (current-buffer) - mailhost (or port 110)))) - (pop3-send-command process "STLS") - (let ((response (pop3-read-response process t))) - (if (and response (string-match "+OK" response)) - (starttls-negotiate process) - (pop3-quit process) - (error "POP server doesn't support starttls"))) - process)) + ;; Delay STLS until server greeting is read (Bug#7438). + (starttls-open-stream "POP" (current-buffer) + mailhost (or port 110))) (t (open-network-stream "POP" (current-buffer) mailhost port)))) (let ((response (pop3-read-response process t))) (setq pop3-timestamp (substring response (or (string-match "<" response) 0) (+ 1 (or (string-match ">" response) -1))))) + (when (eq pop3-stream-type 'starttls) + (pop3-send-command process "STLS") + (let ((response (pop3-read-response process t))) + (if (and response (string-match "+OK" response)) + (starttls-negotiate process) + (pop3-quit process) + (error "POP server doesn't support starttls")))) (pop3-set-process-query-on-exit-flag process nil) process))) |