summaryrefslogtreecommitdiff
path: root/lisp/gnus/registry.el
diff options
context:
space:
mode:
authorStefan Monnier <monnier@iro.umontreal.ca>2015-03-11 11:00:25 -0400
committerStefan Monnier <monnier@iro.umontreal.ca>2015-03-11 11:00:25 -0400
commitb90f502cc18b60644ce3898699589ecd9653b397 (patch)
tree1dc961d28deff002f1100598be6725c749125e64 /lisp/gnus/registry.el
parent41bba4b40f6e07924a3681ffeabb26ca48424095 (diff)
downloademacs-b90f502cc18b60644ce3898699589ecd9653b397.tar.gz
* lisp/gnus/registry.el (registry-db): Don't oset-default an instance slot.
* lisp/gnus/gnus-registry.el (gnus-registry-handle-action) (gnus-registry-post-process-groups): Don't add-to-list on a local var. (gnus-registry-keywords): Make it do something. (gnus-registry-import-eld): Remove unused var `new-entry'. (gnus-registry-action): Remove unused var `to-name'. (gnus-registry-make-db): Prefer `make-instance' to avoid compiler warnings. (gnus-registry-load, gnus-registry-fixup-registry): Avoid `oset'.
Diffstat (limited to 'lisp/gnus/registry.el')
-rw-r--r--lisp/gnus/registry.el9
1 files changed, 6 insertions, 3 deletions
diff --git a/lisp/gnus/registry.el b/lisp/gnus/registry.el
index 881eb9f5a65..1c83b939d80 100644
--- a/lisp/gnus/registry.el
+++ b/lisp/gnus/registry.el
@@ -98,7 +98,12 @@
:type (or null float)
:documentation "The registry version.")
(max-size :initarg :max-size
- ;; :initform most-positive-fixnum ;; see below
+ ;; EIEIO's :initform is not 100% compatible with CLOS in
+ ;; that if the form is an atom, it assumes it's constant
+ ;; value rather than an expression, so in order to get the value
+ ;; of `most-positive-fixnum', we need to use an
+ ;; expression that's not just a symbol.
+ :initform (symbol-value 'most-positive-fixnum)
:type integer
:custom integer
:documentation "The maximum number of registry entries.")
@@ -123,8 +128,6 @@
(data :initarg :data
:type hash-table
:documentation "The data hashtable.")))
-;; Do this separately, since defclass doesn't allow expressions in :initform.
-(oset-default 'registry-db max-size most-positive-fixnum)
(defmethod initialize-instance :BEFORE ((this registry-db) slots)
"Check whether a registry object needs to be upgraded."