diff options
| author | Dmitry Gutov <dgutov@yandex.ru> | 2014-05-21 05:14:38 +0300 |
|---|---|---|
| committer | Dmitry Gutov <dgutov@yandex.ru> | 2014-05-21 05:14:38 +0300 |
| commit | b0df8b953533b67ffba27879b64faab65c7642a6 (patch) | |
| tree | 0a0f6881fba6ae31ef8e710141a2c4122529950c /lisp/emacs-lisp/package.el | |
| parent | 2614b25fd5bbbdbc1740b4b7d43dc1f010571fab (diff) | |
| download | emacs-b0df8b953533b67ffba27879b64faab65c7642a6.tar.gz | |
Replace uses of `save-buffer' with `write-region'
* lisp/emacs-lisp/package.el (package--download-one-archive): Use
`write-region' instead of `save-buffer' to avoid running various
hooks.
(describe-package-1): Same. Insert newline at the end of the
buffer if appropriate.
Fixes: debbugs:17155
Diffstat (limited to 'lisp/emacs-lisp/package.el')
| -rw-r--r-- | lisp/emacs-lisp/package.el | 17 |
1 files changed, 8 insertions, 9 deletions
diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el index c194e1352ac..8b5c742d4cc 100644 --- a/lisp/emacs-lisp/package.el +++ b/lisp/emacs-lisp/package.el @@ -1254,10 +1254,7 @@ similar to an entry in `package-alist'. Save the cached copy to ;; may fetch a URL redirect page). (when (listp (read (current-buffer))) (make-directory dir t) - (setq buffer-file-name (expand-file-name file dir)) - (let ((version-control 'never) - (require-final-newline nil)) - (save-buffer)))) + (write-region nil nil (expand-file-name file dir) nil 'silent))) (when good-signatures ;; Write out good signatures into archive-contents.signed file. (write-region (mapconcat #'epg-signature-to-string good-signatures "\n") @@ -1503,11 +1500,13 @@ If optional arg NO-ACTIVATE is non-nil, don't activate packages." (package--with-work-buffer (package-archive-base desc) (format "%s-readme.txt" name) - (setq buffer-file-name - (expand-file-name readme package-user-dir)) - (let ((version-control 'never) - (require-final-newline t)) - (save-buffer)) + (save-excursion + (goto-char (point-max)) + (unless (bolp) + (insert ?\n))) + (write-region nil nil + (expand-file-name readme package-user-dir) + nil 'silent) (setq readme-string (buffer-string)) t)) (error nil)) |