summaryrefslogtreecommitdiff
path: root/lisp/doc-view.el
diff options
context:
space:
mode:
authorJuri Linkov <juri@jurta.org>2007-11-11 22:23:46 +0000
committerJuri Linkov <juri@jurta.org>2007-11-11 22:23:46 +0000
commit4dd426ff259d45aa0303d4932ca493f3c22eb8ac (patch)
tree6848e0f6c6e66bb90ba0f864d1cbcda8c039a8bd /lisp/doc-view.el
parent3fa50e397a6a269cc2be9395c51c81abbcd7295f (diff)
downloademacs-4dd426ff259d45aa0303d4932ca493f3c22eb8ac.tar.gz
Add comments about isearch support.
Diffstat (limited to 'lisp/doc-view.el')
-rw-r--r--lisp/doc-view.el28
1 files changed, 26 insertions, 2 deletions
diff --git a/lisp/doc-view.el b/lisp/doc-view.el
index 89f1b009f7f..c07f5b5967a 100644
--- a/lisp/doc-view.el
+++ b/lisp/doc-view.el
@@ -97,9 +97,8 @@
;;
;; and modify them to your needs.
-;;; Code:
+;;; Todo:
-;; Todo:
;; - better menu.
;; - don't use `find-file'.
;; - Bind slicing to a drag event.
@@ -107,6 +106,31 @@
;; - get rid of the silly arrow in the fringe.
;; - improve anti-aliasing (pdf-utils gets it better).
+;;;; About isearch support
+
+;; I tried implementing isearch by setting
+;; `isearch-search-fun-function' buffer-locally, but that didn't
+;; work too good. The function doing the real search was called
+;; endlessly somehow. But even if we'd get that working no real
+;; isearch feeling comes up due to the missing match highlighting.
+;; Currently I display all lines containing a match in a tooltip and
+;; each C-s or C-r jumps directly to the next/previous page with a
+;; match. With isearch we could only display the current match. So
+;; we had to decide if another C-s jumps to the next page with a
+;; match (thus only the first match in a page will be displayed in a
+;; tooltip) or to the next match, which would do nothing visible
+;; (except the tooltip) if the next match is on the same page.
+
+;; And it's much slower than the current search facility, because
+;; isearch really searches for each step forward or backward wheras
+;; the current approach searches once and then it knows to which
+;; pages to jump.
+
+;; Anyway, if someone with better isearch knowledge wants to give it a try,
+;; feel free to do it. --Tassilo
+
+;;; Code:
+
(require 'dired)
(require 'image-mode)
(require 'jka-compr)