summaryrefslogtreecommitdiff
path: root/admin/admin.el
diff options
context:
space:
mode:
authorGlenn Morris <rgm@gnu.org>2013-12-28 00:33:44 -0800
committerGlenn Morris <rgm@gnu.org>2013-12-28 00:33:44 -0800
commitc62a19610996165c2d628154561f25e89ff05524 (patch)
tree49bd86e8a69cd794aa639461df7ce0d7b0432ff0 /admin/admin.el
parent946618bae3f84472c45d893e20e19b7422346370 (diff)
downloademacs-c62a19610996165c2d628154561f25e89ff05524.tar.gz
* admin/admin.el (cusver-scan): Warn about missing :types.
(cusver-check): Interactively, require existing directories. * admin/cus-test.el: Comment.
Diffstat (limited to 'admin/admin.el')
-rw-r--r--admin/admin.el10
1 files changed, 8 insertions, 2 deletions
diff --git a/admin/admin.el b/admin/admin.el
index 5989fb27144..13d1126a8d1 100644
--- a/admin/admin.el
+++ b/admin/admin.el
@@ -540,6 +540,12 @@ If optional argument OLD is non-nil, also scan for `defvar's."
;; Exclude macros, eg (defcustom ,varname ...).
(symbolp var))
(progn
+ ;; FIXME It should be cus-test-apropos that does this.
+ (and (not old)
+ (equal "custom" (match-string 2))
+ (not (memq :type form))
+ (display-warning 'custom
+ (format "Missing type in: `%s'" form)))
(setq ver (car (cdr-safe (memq :version form))))
(if (equal "group" (match-string 2))
;; Group :version could be old.
@@ -601,8 +607,8 @@ a :version bump.
Note that a :version tag should also be added if the value of a defcustom
changes (in a non-trivial way). This function does not check for that."
- (interactive (list (read-directory-name "New Lisp directory: ")
- (read-directory-name "Old Lisp directory: ")
+ (interactive (list (read-directory-name "New Lisp directory: " nil nil t)
+ (read-directory-name "Old Lisp directory: " nil nil t)
(number-to-string
(read-number "New version number: "
(string-to-number cusver-new-version)))))