diff options
| author | Basil L. Contovounesios <contovob@tcd.ie> | 2019-04-09 16:32:27 +0100 |
|---|---|---|
| committer | Basil L. Contovounesios <contovob@tcd.ie> | 2019-04-09 16:32:27 +0100 |
| commit | e1a457e63530cd566a1bc2957b70221bb6f76984 (patch) | |
| tree | c4f3a36f1dffd6109cdcc06e06faaaa37f610c87 | |
| parent | 90c7e363b72f0a145378314a2710ce699b659ba1 (diff) | |
| download | emacs-e1a457e63530cd566a1bc2957b70221bb6f76984.tar.gz | |
; Warn of while/dolist pitfall in gnus-sum.el
Suggested by Andy Moreton in the following thread:
https://lists.gnu.org/archive/html/emacs-devel/2019-04/msg00294.html
* lisp/gnus/gnus-sum.el (gnus-summary-move-article): Add comment
warning of common while/dolist pitfall. (bug#33653#134)
| -rw-r--r-- | lisp/gnus/gnus-sum.el | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/lisp/gnus/gnus-sum.el b/lisp/gnus/gnus-sum.el index 8959a2b3d0a..b8aa302f11a 100644 --- a/lisp/gnus/gnus-sum.el +++ b/lisp/gnus/gnus-sum.el @@ -10088,6 +10088,7 @@ ACTION can be either `move' (the default), `crosspost' or `copy'." (or (car select-method) (gnus-group-decoded-name to-newsgroup)) articles) + ;; This `while' is not equivalent to a `dolist' (bug#33653#134). (while articles (setq article (pop articles)) ;; Set any marks that may have changed in the summary buffer. |