diff options
| author | Paul Eggert <eggert@cs.ucla.edu> | 2012-11-19 15:39:28 -0800 |
|---|---|---|
| committer | Paul Eggert <eggert@cs.ucla.edu> | 2012-11-19 15:39:28 -0800 |
| commit | 8ea5c4de2a2a9d71b3877974c92def925fb26f5d (patch) | |
| tree | 7c278a931b73b5e6792c5a7b780e90759e9cdeaa | |
| parent | 141462223d6f8063bf01692c2f41ecc58baea506 (diff) | |
| download | emacs-8ea5c4de2a2a9d71b3877974c92def925fb26f5d.tar.gz | |
Improve static checking of integer overflow and stack smashing.
* configure.ac (WARN_CFLAGS): Add -Wstack-protector and
-Wstrict-overflow if using GCC 4.7.2 or later on a platform with
at least 64-bit long int. This improves static checking on these
platforms, when configured with --enable-gcc-warnings.
| -rw-r--r-- | ChangeLog | 8 | ||||
| -rw-r--r-- | configure.ac | 19 |
2 files changed, 24 insertions, 3 deletions
diff --git a/ChangeLog b/ChangeLog index 05e1a14d55d..6852069087a 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,11 @@ +2012-11-19 Paul Eggert <eggert@cs.ucla.edu> + + Improve static checking of integer overflow and stack smashing. + * configure.ac (WARN_CFLAGS): Add -Wstack-protector and + -Wstrict-overflow if using GCC 4.7.2 or later on a platform with + at least 64-bit long int. This improves static checking on these + platforms, when configured with --enable-gcc-warnings. + 2012-11-17 Paul Eggert <eggert@cs.ucla.edu> Assume POSIX 1003.1-1988 or later for fcntl.h (Bug#12881). diff --git a/configure.ac b/configure.ac index 1884cc7ccf7..2a079cad264 100644 --- a/configure.ac +++ b/configure.ac @@ -717,11 +717,24 @@ else # <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>. nw="$nw -Wshadow" - # The following lines should be removable at some point. - nw="$nw -Wstack-protector" - nw="$nw -Wstrict-overflow" + # The following line should be removable at some point. nw="$nw -Wsuggest-attribute=pure" + AC_MSG_CHECKING([whether to use -Wstack-protector -Wstrict-overflow]) + AC_PREPROC_IFELSE( + [AC_LANG_PROGRAM( + [[#if (1 <= __LONG_MAX__ >> 31 >> 31 \ + && 4 < __GNUC__ + (7 < __GNUC_MINOR__ + (2 <= __GNUC_PATCHLEVEL__))) + /* OK */ + #else + #error "Not GCC, or GCC before 4.7.2, or 'long int' has < 64 bits." + #endif + ]])], + [AC_MSG_RESULT(yes)], + [AC_MSG_RESULT(no) + nw="$nw -Wstack-protector" + nw="$nw -Wstrict-overflow"]) + gl_MANYWARN_ALL_GCC([ws]) gl_MANYWARN_COMPLEMENT([ws], [$ws], [$nw]) for w in $ws; do |