summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorStefan Monnier <monnier@iro.umontreal.ca>2012-10-09 12:37:51 -0400
committerStefan Monnier <monnier@iro.umontreal.ca>2012-10-09 12:37:51 -0400
commit238f3a587a9af8567a5a86a53e5183910526674b (patch)
treeb11f1f7c3b2fb6c569659b7facf1cb1c48fab015
parentd41b45329c4cda1696f9c1f4fd6cbbc4ff4f3fcc (diff)
downloademacs-238f3a587a9af8567a5a86a53e5183910526674b.tar.gz
* lisp/newcomment.el (comment-start-skip, comment-end-skip, comment-end):
Don't document nil as a useful value. Fixes: debbugs:12583
-rw-r--r--lisp/ChangeLog13
-rw-r--r--lisp/newcomment.el12
2 files changed, 15 insertions, 10 deletions
diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index 9ffff9d6da8..69371cec518 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,11 +1,16 @@
+2012-10-09 Stefan Monnier <monnier@iro.umontreal.ca>
+
+ * newcomment.el (comment-start-skip, comment-end-skip, comment-end):
+ Don't document nil as a useful value (bug#12583).
+
2012-10-09 Michael Albinus <michael.albinus@gmx.de>
- * net/tramp.el (tramp-debug-message): Remove
- "tramp-with-progress-reporter" from regexp of ignored functions.
+ * net/tramp.el (tramp-debug-message):
+ Remove "tramp-with-progress-reporter" from regexp of ignored functions.
(with-tramp-progress-reporter): Rename from
`tramp-with-progress-reporter'.
- (with-tramp-file-property, with-tramp-connection-property): Move
- from tramp-cache.el, rename from `with-file-property' and
+ (with-tramp-file-property, with-tramp-connection-property):
+ Move from tramp-cache.el, rename from `with-file-property' and
`with-connection-property', respectively.
* net/tramp-cache.el: Remove `with-file-property' and
diff --git a/lisp/newcomment.el b/lisp/newcomment.el
index 6d2eed71948..a754c89c4ae 100644
--- a/lisp/newcomment.el
+++ b/lisp/newcomment.el
@@ -117,20 +117,20 @@ Comments might be indented to a different value in order not to go beyond
If there are any \\(...\\) pairs, the comment delimiter text is held to begin
at the place matched by the close of the first pair.")
;;;###autoload
-(put 'comment-start-skip 'safe-local-variable 'string-or-null-p)
+(put 'comment-start-skip 'safe-local-variable 'stringp)
;;;###autoload
(defvar comment-end-skip nil
"Regexp to match the end of a comment plus everything back to its body.")
;;;###autoload
-(put 'comment-end-skip 'safe-local-variable 'string-or-null-p)
+(put 'comment-end-skip 'safe-local-variable 'stringp)
;;;###autoload
(defvar comment-end (purecopy "")
"String to insert to end a new comment.
Should be an empty string if comments are terminated by end-of-line.")
;;;###autoload
-(put 'comment-end 'safe-local-variable 'string-or-null-p)
+(put 'comment-end 'safe-local-variable 'stringp)
;;;###autoload
(defvar comment-indent-function 'comment-indent-default
@@ -327,9 +327,9 @@ terminated by the end of line (i.e. `comment-end' is empty)."
;;;###autoload
(defun comment-normalize-vars (&optional noerror)
"Check and setup the variables needed by other commenting functions.
-Any command calling functions from newcomment.el, being entry points, should
-call this function before any other, so the rest of the code can assume that
-the variables are properly set."
+Any command calling functions from newcomment.el should call this function
+before any other, so the rest of the code can assume that the variables are
+properly set."
(unless (and (not comment-start) noerror)
(unless comment-start
(let ((cs (read-string "No comment syntax is defined. Use: ")))