summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* README.eu-stacktrace: add link to discussion threadusers/serhei/eu-stacktraceSerhei Makarov2023-05-081-5/+10
| | | | Also fixed a number of incorrectly named PERF_EVENT_* constants.
* README.eu-stacktrace: fix typo in prev commitSerhei Makarov2023-05-031-1/+1
| | | | | | | Updated example usage: - mkfifo /tmp/test.fifo - eu-stacktrace </tmp/test.fifo >test.syscap & - sysprof-cli --use-fifo=/tmp/test.fifo test.syscap
* eu-stacktrace WIP: default stdin/stdout ("-") for --input/--outputSerhei Makarov2023-05-032-8/+12
| | | | | | | Updated example usage: - mkfifo /tmp/test.fifo - eu-stacktrace </tmp/test.fifo >output=test.syscap & - sysprof-cli --use-fifo=/tmp/test.fifo test.syscap
* README.eu-stacktrace: update for passthrough pipe demoSerhei Makarov2023-05-031-1/+45
|
* eu-stacktrace WIP: simple passthrough for sysprofSerhei Makarov2023-05-021-10/+47
| | | | | | | | | | | Works with the sysprof serhei/samples-via-fifo patchset [1]. Example usage: - mkfifo /tmp/test.fifo - eu-stacktrace --input=/tmp/test.fifo --output=test.syscap & - sysprof-cli --use-fifo=/tmp/test.fifo test.syscap [1]: https://git.sr.ht/~serhei/sysprof-experiments/log/serhei/samples-via-fifo
* eu-stacktrace WIP: include sysprof-capture-types.hSerhei Makarov2023-04-032-0/+31
| | | | | | This header defines the Sysprof data format; we could make it optional through configury, but for now the prototype does not support any other data format.
* eu-stacktrace WIP: command line argsSerhei Makarov2023-04-032-2/+140
| | | | | | | | eu-stacktrace is (will be) a utility to process a stream of stack samples (such as those obtained from PERF_EVENT_SAMPLE) into a stream of stack traces (such as those obtained from PERF_EVENT_CALLCHAIN), freeing various profiling utilities from having to implement their own backtracing logic.
* LoongArch: implemented a basic machine flag checkAlexey Sheplyakov2023-03-202-0/+8
| | | | | | | | | | | | | | | | | | | | With this patch I can use eu-elflint to verify LoongArch ELF binaries. Previously eu-elflint was complaining about invalid machine flags: $ ./src/elflint --gnu-ld ./src/elflint invalid machine flags: 0x43 $ echo $? 1 * backends/loongarch_symbol.c (loongarch_init): Hook machine_flag_check. * backends/loongarch_symbol.c (loongarch_machine_flag_check): New function. https://sourceware.org/bugzilla/show_bug.cgi?id=30251 Signed-off-by: Alexey Sheplyakov <asheplyakov@basealt.ru>
* debuginfod-client.c: Skip empty file creation for cancelled queriesAaron Merey2023-03-172-3/+8
| | | | | | | | | | | | | | | | | Empty files in the client cache are used to indicate that contacted servers could not find a requested resource. Future queries for this resource will not be attempted until the cache_miss_s duration has passed. Currently these empty files are also created when a query is cancelled through the client's progressfn. This can occur, for example, when a user cancels a download with ctrl-c. This prevents user-cancelled queries from being retried promptly without having to modify cache_miss_s. Fix this by skipping the creation of an empty cache file when progressfn cancels a query. Signed-off-by: Aaron Merey <amerey@redhat.com>
* tests: skip '(null)' symname frames in backtrace testsMark Wielaard2023-03-051-0/+8
| | | | | | | | | | | | Some setups might have some frames for unknown (null) functions in the thread backtrace. Skip these frames instead of failing immediately. * tests/backtrace.c (callback_verify): Check and skip nulls_seen. https://sourceware.org/bugzilla/show_bug.cgi?id=29176 Signed-off-by: Mark Wielaard <mark@klomp.org>
* configure.ac contains BashismsMark Wielaard2023-03-051-2/+2
| | | | | | | | | | | | | | | | | | | | | | | Autoconf scripts are supposed to be written in POSIX-compatible shell language. elfutils commits 0ffe2874e75d48cb88936e119e5284ff2bf664d9 and 3fa98a6f29b0f370e32549ead7eb897c839af980 introduced Bashisms to configure.ac that cause errors when /bin/sh is not Bash. Example error when /bin/sh is Dash: ./configure: 8748: test: xyes: unexpected operator The cause of the error is the use of a non-existent == operator in expressions passed to the 'test' built-in command. POSIX shell specifies only an = operator for testing string equality. * configure.ac: Replace == by = in use_msan and enable_demangler comparisons. https://sourceware.org/bugzilla/show_bug.cgi?id=30196 Reported-by: Matt Whitlock <sourceware@mattwhitlock.name> Signed-off-by: Mark Wielaard <mark@klomp.org>
* Fix static build when zstd is enabled for libelfMark Wielaard2023-03-033-3/+3
| | | | | | | | | | | | | | | | | When doing a static build (as with --enable-gcov) the build fails because the executables aren't linked with -lzstd. Also the run-debuginfod-query-retry.sh test relies on libdebuginfod.so.1 which isn't there. Fix by adding $(zstd_LIBS) to the static libelf lines and using the debuginfod-find executable itself in the testcase. * src/Makefile.am (libelf): When BUILD_STATIC add $(zstd_LIBS) * tests/Makefile.am (libelf): Likewise. * tests/run-debuginfod-query-retry.sh: Use debuginfod-find instead of libdebuginfod.so.1 Signed-off-by: Mark Wielaard <mark@klomp.org>
* Prepare for 0.189elfutils-0.189Mark Wielaard2023-03-039-3721/+3813
| | | | | | | | | Set version to 0.189 Update NEWS and elfutils.spec.in Set copyright year in configure.ac and printversion. Regenerate po/*.po files. Signed-off-by: Mark Wielaard <mark@klomp.org>
* libelf: Document and make ELFCOMPRESS_ZSTD usable with old system elf.hMark Wielaard2023-03-034-5/+25
| | | | | | | | Make sure that even if the system elf.h doesn't have ELF_COMPRESS_ZSTD defined it can still be used as constant. Also update libelf.h documentation and add new feature to NEWS. Signed-off-by: Mark Wielaard <mark@klomp.org>
* readelf: Fix use-after-free ebl pointer issueMark Wielaard2023-03-032-2/+8
| | | | | | | | | | | | | | | | | | | | | With -flto gcc 13 sees that we use the ebl pointer after closing and freeing it. In function ‘process_elf_file’, inlined from ‘process_dwflmod’ at readelf.c:818:3: readelf.c:1070:6: error: pointer ‘ebl_18’ used after ‘free’ [-Werror=use-after-free] 1070 | if (pure_ebl != ebl) | ^ In function ‘ebl_closebackend’, inlined from ‘process_elf_file’ at readelf.c:1068:3, inlined from ‘process_dwflmod’ at readelf.c:818:3: ../libebl/eblclosebackend.c:47:7: note: call to ‘free’ here 47 | free (ebl); | ^ Fix by only calling ebl_closebackend after using it in the comparison. Signed-off-by: Mark Wielaard <mark@klomp.org>
* libdw: Fix dwarf_getscopes memory leak on errorMark Wielaard2023-02-282-1/+8
| | | | | | | | | | When there is an error in dwarf_getscopes after the initial scopes have been allocated, e.g. when looking for the inlined scopes, then the scopes would leak. Fix this by explicitly free the scopes on error. https://sourceware.org/bugzilla/show_bug.cgi?id=29434 Signed-off-by: Mark Wielaard <mark@klomp.org>
* libcpu: Remove the need of NMNES by using enumYonggang Luo2023-02-235-21/+60
| | | | | Signed-off-by: Yonggang Luo <luoyonggang@gmail.com> Signed-off-by: Mark Wielaard <mark@klomp.org>
* libdw: Use elf_rawdata when checking .debug sectionMark Wielaard2023-02-232-2/+7
| | | | | | | .debug sections are raw bytes and don't need conversion even when host and file have different endian order. Signed-off-by: Mark Wielaard <mark@klomp.org>
* libelf: memmove any extra bytes left by elf_cvt_gnuhash conversionMark Wielaard2023-02-232-2/+14
| | | | | | | | Otherwise some undefined bytes might be left in the buffer. Now they might still be not useful, but at least they are as defined in the file. Signed-off-by: Mark Wielaard <mark@klomp.org>
* NEWS: Add old version code namesMark Wielaard2023-02-232-26/+30
| | | | Signed-off-by: Mark Wielaard <mark@klomp.org>
* Update m4 files from autoconf-archiveMark Wielaard2023-02-212-62/+503
| | | | | | | Update m4/ax_check_compile_flag.m4 and m4/ax_cxx_compile_stdcxx.m4 to autoconf-archive-2023.02.20. Signed-off-by: Mark Wielaard <mark@klomp.org>
* configure: Check for and -Wuse-after-free=3 when availableMark Wielaard2023-02-214-1/+27
| | | | | | | gcc already includes -Wuse-after-free=2 in -Wall. -Wuse-after-free=3 also warns for indeterminate pointers in equality expressions. Signed-off-by: Mark Wielaard <mark@klomp.org>
* libasm: Fix use-after-free issue with circular single linked list cleanupMark Wielaard2023-02-212-8/+14
| | | | | | | | | | | | | | | | Pointed out by gcc 12 with -Wuse-after-free=3 In function ‘free_section’ asm_end.c:552:17: error: pointer ‘data’ used after ‘free’ [-Werror=use-after-free] 552 | while (oldp != scnp->content); | ~~~~~^~~~~~~~~~~~~~~~ asm_end.c:550:9: note: call to ‘free’ here 550 | free (oldp); | ^~~~~~~~~~~ Fix by freeing scnp->content last. Signed-off-by: Mark Wielaard <mark@klomp.org>
* NEWS: Mention linking with libstdc++ or using --disable-demanglerMark Wielaard2023-02-171-0/+3
| | | | Signed-off-by: Mark Wielaard <mark@klomp.org>
* libdw: check that DWARF strings are null-terminatedAleksei Vetrov2023-02-173-1/+52
| | | | | | | | | | | | It is expected from libdw to return strings that are null-terminated to avoid overflowing ELF data. * Add calculation of a safe prefix inside string sections, where any string will be null-terminated. * Check if offset overflows the safe prefix in dwarf_formstring. Signed-off-by: Aleksei Vetrov <vvvvvv@google.com>
* configure: Error when demangler is enabled, but libstdc++ support isn'tMark Wielaard2023-02-172-1/+7
| | | | | | | | | There have been a couple of cases where demangler support has been accidentially been disabled because libstdc++ wasn't there/installed during build. Make it an error if --disable-demangler isn't explicitly given. Signed-off-by: Mark Wielaard <mark@klomp.org>
* doc: Add .TP before -g in debuginfod.8Mark Wielaard2023-02-142-0/+5
| | | | | | Fixes indentation of -g option. Signed-off-by: Mark Wielaard <mark@klomp.org>
* libdw: Correct data end checkfor deref_type operand in dwarf_getlocationMark Wielaard2023-02-142-1/+6
| | | | | | | | In __libdw_intern_expression we checked for one byte too many. We only need one byte for the size and (at least one) for the uleb128 DIE reference. Signed-off-by: Mark Wielaard <mark@klomp.org>
* libdw: Handle DW_OP_GNU_uninit in dwarf_getlocationMark Wielaard2023-02-144-0/+16
| | | | | | | | | | | dwarf_getlocation would return an error when it saw a DW_OP_GNU_uninit. Handle it by simply recognizing as a no argument operation. DW_OP_GNU_uninit is emitted by GCC as a marker to flag the location expression as referring to an uninitialized value. Signed-off-by: Mark Wielaard <mark@klomp.org>
* libdw, readelf, elflint: Add get_(u|s)leb128 guardsMark Wielaard2023-02-1413-1/+72
| | | | | | | | | Add sanity check making sure an leb128 isn't being read beyond the end of the current data segment. Most code already had these guards, but some were missing. This makes sure an appropriate error is generated instead. Signed-off-by: Mark Wielaard <mark@klomp.org>
* libdw: check memory access in get_(u|s)leb128Aleksei Vetrov2023-02-142-3/+36
| | | | | | | | | | __libdw_get_uleb128 and __libdw_get_sleb128 should check if addrp has already reached the end before unrolling the first step. It is done by moving __libdw_max_len to the beginning of the function, which can notice, that addrp is beyond the end. Then we just check the result of this function. Signed-off-by: Aleksei Vetrov <vvvvvv@google.com>
* backends: Handle DW_TAG_unspecified_type in dwarf_peeled_die_typeMark Wielaard2023-02-145-3/+40
| | | | | | | | | | | | | | | | binutils 2.40 introduces DW_TAG_unspecified_type for assembly functions with an unknown return type. This breaks the run-funcretval.sh testcase because dwfl_module_return_value_location returns an error for such functions because it cannot determine the return value location. Fix that by treating DW_TAG_unspecified_type as if the DIE doesn't have a DW_AT_type. Also update the testcase to explicitly checking for DW_TAG_unspecified_type and printing "returns unspecified type". https://sourceware.org/bugzilla/show_bug.cgi?id=30047 Signed-off-by: Mark Wielaard <mark@klomp.org>
* configure: Add --enable-sanitize-memoryIlya Leoshkevich2023-02-149-5/+56
| | | | | | | | | | | | | | | | | | | | Add support for clang Memory Sanitizer [1], which detects the usage of uninitialized values. While elfutils itself is already checked with valgrind, checking code that depends on elfutils requires elfutils to be built with MSan. MSan is not linked into shared libraries, and is linked into executables statically. Therefore, unlike the other sanitizers, MSan needs to be configured fairly early, since we need to drop -D_FORTIFY_SOURCE [2], -Wl,-z,defs and --no-undefined. Disable a few tests that run for more than 5 minutes due to test files being statically linked with MSan. [1] https://clang.llvm.org/docs/MemorySanitizer.html [2] https://github.com/google/sanitizers/issues/247 Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
* backends: Support returning lvalue and rvalue referencesIlya Leoshkevich2023-02-1419-43/+118
| | | | | | | | | On the low level, they are the same as pointers. The change needs to be done for all backends, so define a function and a macro to avoid repetition. Also add a native test, which has to be implemented in C++. Add the configure check for it. Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
* printversion: Fix unused variableIlya Leoshkevich2023-02-142-3/+5
| | | | | | | | | | | | | | | | | | clang complains: debuginfod.cxx:354:1: error: unused variable 'apba__' [-Werror,-Wunused-const-variable] ARGP_PROGRAM_BUG_ADDRESS_DEF = PACKAGE_BUGREPORT; ^ ../lib/printversion.h:47:21: note: expanded from macro 'ARGP_PROGRAM_BUG_ADDRESS_DEF' const char *const apba__ __asm ("argp_program_bug_address") ^ The default linkage for consts in C++ is internal, so declare them extern. While at it, remove the debuginfod workaround for argp_program_version_hook. Co-developed-by: Mark Wielaard <mark@klomp.org> Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
* tests: Ignore dwfl-report-offline-memoryIlya Leoshkevich2023-02-141-0/+1
| | | | | | It's showing up in git status when configuring in the source directory. Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
* configure: Add --disable-demanglerIlya Leoshkevich2023-02-091-1/+7
| | | | | | | __cxa_demangle is normally implemented in the C++ runtime library, instrumenting which for MSan is a hassle. Add a knob for disbling it. Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
* configure: Use -fno-addrsig if possibleIlya Leoshkevich2023-02-091-0/+8
| | | | | | | | | | | By default, clang produces .llvm_addrsig sections [1]. The GNU toolchain does not know how to handle them yet [2], so just ask clang not to generate them for the time being. [1] https://llvm.org/docs/Extensions.html#sht-llvm-addrsig-section-address-significance-table [2] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105625 Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
* readelf: Fix set but not used parameterIlya Leoshkevich2023-02-091-12/+5
| | | | | | | | | | | | | | | | | | | | | | | clang complains: readelf.c:12205:72: error: parameter 'desc' set but not used [-Werror,-Wunused-but-set-parameter] handle_bit_registers (const Ebl_Register_Location *regloc, const void *desc, ^ Mark Wielaard says: It is never really used since as far as I can see we don't have any backend with a core register sets where a register doesn't have a number of bits which isn't a multiple of 8 (only ia64 has some 1 bit registers, but those don't seem part of the core register set). If we do accidentally try to handle such a register having an abort is also not very nice. Lets just warn and return/continue. https://sourceware.org/bugzilla/show_bug.cgi?id=30084 Co-developed-by: Mark Wielaard <mark@klomp.org> Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
* libasm: Fix xdefault_pattern initializationIlya Leoshkevich2023-02-091-5/+11
| | | | | | | | | | | | | | | | | | | clang complains: asm_newscn.c:48:22: error: field 'pattern' with variable sized type 'struct FillPattern' not at the end of a struct or class is a GNU extension [-Werror,-Wgnu-variable-sized-type-not-at-end] struct FillPattern pattern; ^ Fix by using a union instead. Define the second union member to be a char array 1 byte larger than struct FillPattern. This should be legal according to 6.7.9: If an object that has static or thread storage duration is not initialized explicitly, then ... if it is a union, the first named member is initialized (recursively) according to these rules, and any padding is initialized to zero bits. Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
* addr2line: Do not test demangling in run-addr2line-i-test.shIlya Leoshkevich2023-02-081-7/+7
| | | | | | There is run-addr2line-i-demangle-test.sh for that. Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
* Initialize reglocs for VMCOREINFOIlya Leoshkevich2023-02-081-0/+1
| | | | | | | | | | | | | | | | | MSan complains: Uninitialized value was created by an allocation of 'reglocs' in the stack frame #0 0x562d35c686f0 in handle_core_note elfutils/src/readelf.c:12674:3 #const Ebl_Register_Location *reglocs; ==1006199==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x562d35c68a2a in handle_core_note elfutils/src/readelf.c:12692:11 #colno = handle_core_registers (ebl, ebl->elf, desc + regs_offset, # reglocs, nregloc); Strictly speaking, this is not a problem, because nregloc == 0, but for other note types we initialize it anyway, so do it here as well. Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
* readelf: Fix set but not used variableIlya Leoshkevich2023-02-081-2/+0
| | | | | | | | | | | | clang complains: readelf.c:10250:10: error: variable 'nculist' set but not used [-Werror,-Wunused-but-set-variable] size_t nculist = 0; ^ Fix by deleting it. Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
* debuginfod-client.c: Download section even if cached executable didn't ↵Aaron Merey2023-02-072-10/+21
| | | | | | | | | | | | | | | | | | | | | contain it. Before attempting to download a section, cache_find_section tries to extract the section from existing files in the cache. If it's determined that the section must not exist, cache_find_section returns -ENOENT to indicate that the download should be skipped. This patch fixes a bug where cache_find_section returns -ENOENT even though the section exists. If the cache contains the executable but not the debuginfo with the given build-id and the section only exists in the debuginfo (such as any of the .debug_* sections), then debuginfod_find_section returns -ENOENT even if the section could be downloaded. Fix this by having cache_find_section not return -ENOENT unless cached debuginfo was able to be read. Signed-off-by: Aaron Merey <amerey@redhat.com>
* debuginfod: Make sure there is only one typedef for debuginfod_clientMark Wielaard2023-02-064-0/+16
| | | | | | | | | | | | Both debuginfod.h and libdwfl.h have a simple typedef for struct debuginfod_client. Some compilers pedantically warn when including both headers that such typedefs are only officially supported in C11. So guard them with _ELFUTILS_DEBUGINFOD_CLIENT_TYPEDEF to make them happy. https://sourceware.org/bugzilla/show_bug.cgi?id=30077 Signed-off-by: Mark Wielaard <mark@klomp.org>
* tests: Check ELFUTILS_DISABLE_DEMANGLE in run-addr2line-C-test.shMark Wielaard2023-02-032-0/+9
| | | | | | https://sourceware.org/bugzilla/show_bug.cgi?id=30072 Signed-off-by: Mark Wielaard <mark@klomp.org>
* libdw: Search for abstract origin in the correct CUMark Wielaard2023-01-306-8/+66
| | | | | | | | | | | | | | | With gcc -flto the abstract origin of an inlined subroutine could be in a different CU. dwarf_getscopes might return an empty scope if it cannot find the abstract origin scope. So make sure to search in the We also tried to add the origin match in pc_record directly in the current inlined scope. This always failed, causing to do a needless traversal, followed by the full CU scan in dwarf_getscopes. Just always stop the pc_record search and then do the CU origin_match in dwarf_getscopes. Signed-off-by: Mark Wielaard <mark@klomp.org>
* addr2line: -C should not try to handle optional (ignored) argumentMark Wielaard2023-01-305-2/+110
| | | | | | | | | | | | | | | | The --demangle option takes an option (ignored) argument. Since -C is the short option of --demangle it also takes that optional argument. But that means that something like -Cfi is like -C got fi as argument, while the user expects -Cfi to be like -C -f -i. Separate the --demangle and -C options. --demangle still takes an optional (ignored) argument, but -C doesn't take any arguments so -Cfi acts the same as -fiC. Also fix --target, -b, so that it is properly ignored (and not accidentially enables demangling). Signed-off-by: Mark Wielaard <mark@klomp.org>
* libdwfl: add check for elf_memory return valueAleksei Vetrov2023-01-262-2/+11
| | | | | | | elf_memory call in __libdw_open_elf_memory can return NULL. It was not checked and led to the null pointer dereference. Signed-off-by: Aleksei Vetrov <vvvvvv@google.com>
* tests: run-debuginfod-query-retry.sh /bin/sh might not have a build-idMark Wielaard2023-01-192-2/+8
| | | | | | | | | If /bin/sh wasn't build with build-id the test fails because debuginfod-find will not be able to even try to fetch something. Use libdebuginfod.so.1 instead as test file because we just build that and configure makes sure we always produce a build-id. Signed-off-by: Mark Wielaard <mark@klomp.org>
View Lorry Controller Status