summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* debuginfod: add --disable-source-scan optionMichael Trapp2022-06-032-1/+14
| | | | | | | | --disable-source-scan disables scanning of the dwarf source info of debuginfo sections. The source info is not required in setups without source code access. Signed-off-by: Michael Trapp <michael.trapp@sap.com>
* PR28577: Make run-debuginfod-fd-prefetch-caches.sh test somethingNoah Sanci2022-06-032-72/+55
| | | | | | | Update to the run-debuginfod-fd-prefetch to make the test more sound. Signed-off-by: Mark Wielaard <mark@klomp.org>
* Added debuginfod.service.8 manual page.Noah Sanci2022-06-022-1/+31
| | | | Signed-off-by: Noah Sanci <nsanci@redhat.com>
* tests: Disable run-debuginfod-federation-metrics.sh for old libmicrohttpdMark Wielaard2022-06-024-1/+17
| | | | | | | | | On really old libmicrohttpd the run-debuginfod-federation-metrics.sh test will crash debuginfod after too many file descriptors have been used. libmicrohttpd looses track of the state and aborts instead of producing an error. Just disable the testcase on these very old versions. Signed-off-by: Mark Wielaard <mark@klomp.org>
* libdwfl: Update docs and nonnull attributes for dwfl_module_addrinfoMark Wielaard2022-05-272-16/+21
| | | | | | | | Make clear that both the offset and sym arguments cannot be NULL. https://bugzilla.redhat.com/show_bug.cgi?id=1986555 Signed-off-by: Mark Wielaard <mark@klomp.org>
* debuginfod: update mtime of interval_path as early as possibleMark Wielaard2022-05-152-2/+10
| | | | | | | | | | Call utime on interval_path file as soon as the thread is committed to cleanup the cache files. This will prevent other threads trying to also commit to cleaning the cache files. Having multiple threads try to clean the cache simultaniously doesn't improve cleanup speed because the threads will try to delete the files in the same order. Signed-off-by: Mark Wielaard <mark@klomp.org>
* debuginfod: Remove debuginfod_init_cacheMark Wielaard2022-05-152-52/+15
| | | | | | | | | | | debuginfod_init_cache would create all config files if they didn't exist yet. It always made two stat calls. Then debuginfod_clean_cache would call debuginfod_config_cache which did the same checks and created any missing config files. Just make sure the cache_path directory exists and remove debuginfod_init_cache before calling debuginfod_clean_cache. Signed-off-by: Mark Wielaard <mark@klomp.org>
* debuginfod: Make sure debuginfod_config_cache always returns valid statMark Wielaard2022-05-152-7/+20
| | | | | | | | | | | If the condig file which value was requested from debuginfod_config_cache didn't exist yet, stat would fail and no valid struct stat would be returned even when the file was correctly created. Fix this by always using O_CREAT to open the file, and reuse that file descriptor to call fstat and for either writing the default value or reading the config file value. Signed-off-by: Mark Wielaard <mark@klomp.org>
* debuginfod: Always request servname from getnameinfo for conninfo.Mark Wielaard2022-05-152-5/+14
| | | | | | | | | | | When getting the connection info getnameinfo is called getting the hostname and servname except when the sockaddr is a pure ipv6 address. In that last case only hostname is requested. Since servname is stack allocated and not initialized it might contain garbage which is then put in the log. Just always request both hostname and servname with NI_NUMERICHOST | NI_NUMERICSERV. Signed-off-by: Mark Wielaard <mark@klomp.org>
* strip: Add more NULL checkMark Wielaard2022-05-142-2/+15
| | | | | | | | When gelf_getshdr, gelf_getrela, gelf_getrel or gelf_getsymshndx return NULL it is an internal error which we want to report instead of crashing. Signed-off-by: Mark Wielaard <mark@klomp.org>
* libdw: Add sanity check to store_implicit_valueMark Wielaard2022-05-142-1/+8
| | | | | | | Don't just skip the block length, but check it is equal to the op->number that we are going to use as length. Signed-off-by: Mark Wielaard <mark@klomp.org>
* debuginfod: Check all curl_easy_setopt callsMark Wielaard2022-05-142-22/+44
| | | | | | | | curl_easy_setup can fail for various reasons. Add a curl_easy_setopt_ck macro to check all curl_easy_setopt calls and provides a human readable error message in verbose mode. Signed-off-by: Mark Wielaard <mark@klomp.org>
* debuginfod: Check result of curl_easy_getinfo in debuginfod_write_callbackMark Wielaard2022-05-142-2/+8
| | | | | | | This was the only place in debuginfod-client.c where we didn't check the result of curl_easy_getinfo. Just check it to make things consistent. Signed-off-by: Mark Wielaard <mark@klomp.org>
* elfcompress: Add sanity checks to make sure to not override variableMark Wielaard2022-05-142-0/+29
| | | | | | | The process_file code is a little tricky. Add sanity checks to make sure shstrtab_name, shstrtab_newname and symstrents are only set once. Signed-off-by: Mark Wielaard <mark@klomp.org>
* PR28577: run-debuginfod-fd-prefetch-caches.sh now tests somethingNoah Sanci2022-05-131-21/+126
| | | | | | | run-debuginfod-fd-prefetch-caches.sh now tests the maximum fd and mb values of prefetch and fd (least recently used) caches. Signed-off-by: Noah Sanci <nsanci@redhat.com>
* debuginfod: Use MHD_USE_EPOLL for libmicrohttpd version 0.9.51 or higherMark Wielaard2022-05-122-5/+16
| | | | | | | | Also disable MHD_USE_THREAD_PER_CONNECTION when using MHD_USE_EPOLL. https://sourceware.org/bugzilla/show_bug.cgi?id=29123 Signed-off-by: Mark Wielaard <mark@klomp.org>
* debuginfod: Try without MHD_USE_DUAL_STACK if MHD_start_daemon failsMark Wielaard2022-05-122-23/+58
| | | | | | | | | | | On a systems that have ipv6 disabled debuginfod doesn't start up anymore because libhttpd MHD_USE_DUAL_STACK only works if it can open an ipv6 socket. If MHD_start_daemon with MHD_USE_DUAL_STACK fails try again without that flag set. https://sourceware.org/bugzilla/show_bug.cgi?id=29122 Signed-off-by: Mark Wielaard <mark@klomp.org>
* debuginfod.8: Tweak wording of fdcache operation & parameters.Frank Ch. Eigler2022-05-092-17/+23
| | | | Signed-off-by: Frank Ch. Eigler <fche@redhat.com>
* PR29098: debuginfod - set default prefetch cache size to >0Noah Sanci2022-05-092-0/+11
| | | | | | | | | Added default value to fdcache_prefetch_mds and fdcache_prefetch_fds. Defaults to one half of corresponging fdcache's values. Signed-off-by: Noah Sanci <nsanci@redhat.com> foo
* PR29117: fix fd leak in debuginfod client for cache-miss filesFrank Ch. Eigler2022-05-043-8/+35
| | | | | | | | | Correct a nasty fd leak and a few less nasty leaks in the debuginfod client code. The nasty one impacts long-lived apps such as debuginfod servers. Signed-off-by: Mark Wielaard <mark@klomp.org> Signed-off-by: Frank Ch. Eigler <fche@redhat.com>
* config: Move the 2>/dev/null inside the sh -c '' quotes for profile.csh.Mark Wielaard2022-05-032-1/+5
| | | | | | | | | | | csh/tcsh would warn about "Ambiguous output redirect" if not done inside the sh -c command. Fix-by: наб <nabijaczleweli@nabijaczleweli.xyz> https://bugzilla.redhat.com/show_bug.cgi?id=2080957 Signed-off-by: Mark Wielaard <mark@klomp.org>
* configure: Don't use valgrind and sanitize-undefined for make distcheckMark Wielaard2022-05-032-1/+5
| | | | | | | | | | | | make distcheck would always run with --enable-valgrind and --enable-sanitize-undefined. Assuming the maintainer would run this just before doing a release. But this makes distcheck really, really, really slow. And we have various buildbots now that run various combinations of valgrind, undefined and/or address sanitizer over every commit now. This make make distcheck "fast" again. Signed-off-by: Mark Wielaard <mark@klomp.org>
* Prepare for 0.187elfutils-0.187Mark Wielaard2022-04-2513-2839/+2823
| | | | | | | | | Set version to 0.187 Update NEWS and elfutils.spec.in Set copyright year in configure.ac and printversion. Regenerate po/*.po files. Signed-off-by: Mark Wielaard <mark@klomp.org>
* debuginfod: ensure X-DEBUGINFOD-SIZE contains file sizeAaron Merey2022-04-252-1/+9
| | | | | | | | | | For archived files X-DEBUGINFOD-SIZE currently contains the size of the archive instead of the size of the uncompressed file. Fix this. Also add testcases to verify X-DEBUGINFOD-SIZE contains uncompressed file sizes. Signed-off-by: Aaron Merey <amerey@redhat.com>
* debuginfod: Use the debuginfod-size response headerAaron Merey2022-04-251-40/+43
| | | | | | | | | | | | | In some cases the content-length header may not be available in order to pass to a progressfn. If content-length isn't available then attempt to get the size of the download from the debuginfod-size header instead. It should be mentioned that if a compressed file (ex. gzip) is being transferred, the actual transfer length will be less than debuginfod-size. In this case debuginfod-size is a best-guess upper bound on the size of the transfer. Signed-off-by: Aaron Merey <amerey@redhat.com>
* debuginfod, libdwfl: Initialize libcurl and dlopen debuginfod-client lazilyMark Wielaard2022-04-255-20/+44
| | | | | | | | | | | | | We used to go out of our way to initialize libcurl early before any other thread/code was running. But this meant that we might pay startup cost, which under FIPS is significant, even for code that never uses libdebuginfod or TLS libcurl connections. Although curl_global_init itself isn't thread-safe we can use pthread_once to make sure we don't race against ourselves. This still means we might race against any application code that might use libcurl. But we can assume they will have called curl_global_init before calling dwfl_begin or debuginfod_begin. Signed-off-by: Mark Wielaard <mark@klomp.org>
* AUTHORS: Use generator script & git mailmapFrank Ch. Eigler2022-04-244-3/+145
| | | | | | We can compute a pretty complete list of contributors. Signed-off-by: Frank Ch. Eigler <fche@redhat.com>
* libelf: Check for mremap, elf_update needs it for ELF_C_RDWR_MMAPMark Wielaard2022-04-244-1/+14
| | | | | | | | | | | Add a AC_CHECK_FUNCS configure check for mremap. Some systems like KFreeBSD and the Hurd don't have it. Also add a configure warning because without mremap elf_update will often fail when ELF_C_RDWR_MMAP is used. ELF_C_RDWR_MMAP is an elfutils extension to libelf. https://sourceware.org/bugzilla/show_bug.cgi?id=27337 Signed-off-by: Mark Wielaard <mark@klomp.org>
* elfclassify: Fix --no-stdin flagMark Wielaard2022-04-242-1/+5
| | | | | | | | | The no-stdin option was using the wrong flag, classify_flag_stdin, instead of classify_flag_no_stdin. https://sourceware.org/bugzilla/show_bug.cgi?id=28724 Signed-off-by: Mark Wielaard <mark@klomp.org>
* debuginfod: Use MHD_USE_ITC in MHD_start_daemon flagsMark Wielaard2022-04-244-1/+14
| | | | | | | | | | | | | | | | | | | This prevents the "Server reached connection limit. Closing inbound connection." issue we have been seeing in the run-debuginfod-webapi-concurrency.sh testcase. From the manual: If the connection limit is reached, MHD’s behavior depends a bit on other options. If MHD_USE_ITC was given, MHD will stop accepting connections on the listen socket. This will cause the operating system to queue connections (up to the listen() limit) above the connection limit. Those connections will be held until MHD is done processing at least one of the active connections. If MHD_USE_ITC is not set, then MHD will continue to accept() and immediately close() these connections. https://sourceware.org/bugzilla/show_bug.cgi?id=28708 Signed-off-by: Mark Wielaard <mark@klomp.org>
* tests: Lower parallel lookups in run-debuginfod-webapi-concurrency.shMark Wielaard2022-04-232-3/+8
| | | | | | | | | With 100 parallel lookups we sometimes see: Server reached connection limit. Closing inbound connection. Lower parallel lookups to 64 Signed-off-by: Mark Wielaard <mark@klomp.org>
* config: simplify profile.*sh.inнаб via Elfutils-devel2022-04-233-12/+14
| | | | | | | | | | 1. Simplify needless sh -c "cat glob 2>/dev/null" into cat glob 2>/dev/null under sh and fix re-expansion/-e protection under csh 2. Use $( instead of ` under sh 3. Assign to DEBUGINFOD_URLS directly and either export it or unset it Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
* readelf: Define dyn_mem outside the while loop.Mark Wielaard2022-04-192-1/+5
| | | | | | | The GCC address sanitizer might complain otherwise: stack-use-after-scope src/readelf.c:1787 in get_dyn_ents Signed-off-by: Mark Wielaard <mark@klomp.org>
* readelf: Don't consider padding DT_NULL as dynamic section entryDi Chen2022-04-196-15/+43
| | | | | | | | | | | when using `$ eu-readelf -d {FILE}` to get the number of dynamic section entris, it wrongly counts the padding DT_NULLs as dynamic section entries. However, DT_NULL Marks end of dynamic section. They should not be considered as dynamic section entries. https://sourceware.org/bugzilla/show_bug.cgi?id=28928 Signed-off-by: Di Chen <dichen@redhat.com>
* libdw: Remove unused atomics.h include from libdwP.hMark Wielaard2022-04-172-1/+4
| | | | Signed-off-by: Mark Wielaard <mark@klomp.org>
* tests: Don't try to corrupt sqlite database during test.Mark Wielaard2022-04-142-8/+14
| | | | | | | | | | In run-debuginfod-federation-sqlite.sh we used to try to corrupt the sqlite database while the debuginfod server was running and check it detected errors, but that was unreliably and slightly dangerous since part of the database was already mapped into memory. Instead trigger some some random activity, then trigger a shutdown. Signed-off-by: Mark Wielaard <mark@klomp.org>
* PR29022: 000-permissions files cause problems for backupsAaron Merey2022-04-139-47/+90
| | | | | | | | | | | | | | 000-permission files currently used for negative caching can cause permission problems for some backup software and disk usage checkers. Fix this by using empty files for negative caching instead. Also use each empty file's mtime to determine the time since last download attempt instead of the cache_miss_s file's mtime. https://sourceware.org/bugzilla/show_bug.cgi?id=29022 Tested-by: Milian Wolff <mail@milianw.de> Signed-off-by: Aaron Merey <amerey@redhat.com>
* libdw: Add DWARF5 package file section identifiers, DW_SECT_*Mark Wielaard2022-04-132-0/+18
| | | | | | | | | This only adds the constants. There is no handling of DWARF package file (dwp) files for now. https://sourceware.org/bugzilla/show_bug.cgi?id=29048 Signed-off-by: Mark Wielaard <mark@klomp.org>
* config: Add versioned requires on libs/libelf for debuginfod-clientMark Wielaard2022-04-122-0/+8
| | | | | | | | | elfutils-debuginfod-client contains the debuginfod-client binary which is uses libelf and libdw. Add explicit versioned requires on elfutils-libs and elfutils-libelf so they will always be in sync like done with all other inter sub package dependencies. Signed-off-by: Mark Wielaard <mark@klomp.org>
* debuginfod: Include "IPv4 IPv6" in server startup messageAaron Merey2022-04-061-1/+1
| | | | | | | | | | | | | | | At startup debuginfod prints a message indicating the port which the server is listening to. Prior to commit 4e4082be03 this message would include "IPv4" and/or "IPv6" [...] (48671/48671): started http server on IPv4 IPv6 port=8002 As of commit 4e4082be03 the IP versions have been removed from this message. This change can cause issues in any applications that parse the message for this information. Fix this by adding "IPv4 IPv6" back to the message. Signed-off-by: Aaron Merey <amerey@redhat.com>
* libelf: Return already gotten Elf_Data from elf_getdata_rawchunkMark Wielaard2022-04-053-0/+24
| | | | | | | | | | | | | | | | | | | | | | elf_getdata_rawchunk keeps a list of Elf_Data_Chunk to track which Elf_Data structures have already been requested. This allows elf_end to clean up all internal data structures and the Elf_Data d_buf if it was malloced. But it didn't check if a chunk was already requested earlier. This meant that if for example dwelf_elf_gnu_build_id was called multiple times to lookup a build-id from the phdrs a new Elf_Data_Chunk was created. This could slowly leak memory. So also keep track of the offset from which the size and type of the rawdata was requested so we can return existing data if it is requested multiple times. Note that the current cache is a simple linked list but the chain is normally not that long. It is normally used to get chunks from the phdrs, and there are normally less than 10. Signed-off-by: Mark Wielaard <mark@klomp.org>
* debuginfod: use single ipv4+ipv6 microhttpd daemon configurationFrank Ch. Eigler2022-04-043-39/+53
| | | | | | | | | | Use a single MHD_USE_DUAL_STACK mhd daemon. This way, the thread connection pool is not doubled, saving memory and better matching user expectations. A slight tweak to logging is required to pull IPv4 remote addresses back out, and also to allow IPv6 ::-laden address forwarding through federation links. Signed-off-by: Frank Ch. Eigler <fche@redhat.com>
* PR28708: debuginfod: use MHD_USE_EPOLL for microhttpd threadsFrank Ch. Eigler2022-04-032-0/+11
| | | | | | | | | Testing on s390x and other architectures indicates that this configuration reduces thundering-herd wakeups and saturation of a small number of threads. The run-debuginfod-webapi-concurrency.sh test appears solid now. Signed-off-by: Frank Ch. Eigler <fche@redhat.com>
* libelf: Also copy/convert partial datastructures in xlate functionsMark Wielaard2022-03-302-2/+13
| | | | | | | | | | | The generated xlate functions can only convert full datastructures, dropping any trailing partial data on the floor. That means some of the data might be undefined. Just copy over the trailing bytes as is. That data isn't really usable. But at least it is defined data. https://sourceware.org/bugzilla/show_bug.cgi?id=29000 Signed-off-by: Mark Wielaard <mark@klomp.org>
* Introduce error_exit as a noreturn variant of error (EXIT_FAILURE, ...)Mark Wielaard2022-03-3014-288/+264
| | | | | | | | | | | | error (EXIT_FAILURE, ...) should be noreturn but on some systems it isn't. This may cause warnings about code that should not be reachable. So have an explicit error_exit wrapper that is noreturn (because it calls exit explicitly). Use error_exit in all tools under the src directory. https://bugzilla.redhat.com/show_bug.cgi?id=2068692 Signed-off-by: Mark Wielaard <mark@klomp.org>
* elflint: Recognize NT_FDO_PACKAGING_METADATAMark Wielaard2022-03-252-0/+11
| | | | Signed-off-by: Mark Wielaard <mark@klomp.org>
* libebl: recognize FDO Packaging Metadata ELF noteLuca Boccassi2022-03-243-0/+12
| | | | | | | | | | | | | As defined on: https://systemd.io/COREDUMP_PACKAGE_METADATA/ this note will be used starting from Fedora 36. Allow readelf --notes to pretty print it: Note section [ 3] '.note.package' of 76 bytes at offset 0x2e8: Owner Data size Type FDO 57 FDO_PACKAGING_METADATA Packaging Metadata: {"type":"deb","name":"fsverity-utils","version":"1.3-1"} Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com>
* libelf: Sync elf.h from glibc.Mark Wielaard2022-03-244-24/+94
| | | | | | | | | | | | | | Adds EM_INTELGT, NT_ARM_TAGGED_ADDR_CTRL, NT_ARM_PAC_ENABLED_KEYS, ELF_NOTE_FDO, NT_FDO_PACKAGING_METADATA and OpenRISC 1000 specific relocs. It also adds and renames some GNU_PROPERTY constants. But none of the constants the elfutils code uses was renamed or given a different constant value. dwelf_elf_e_machine_string was updated to handle EM_INTELGT. Signed-off-by: Mark Wielaard <mark@klomp.org>
* configure: Don't check whether -m64 works for 32bit host biarch checkMark Wielaard2022-03-244-3/+10
| | | | | | | | | | Running a 32bit backtrace test against a 64bit binary doesn't work. Only a 64bit binary can backtrace a 32bit binary. So disable the biarch check that inserts -m64 for a 32bit host. https://sourceware.org/bugzilla/show_bug.cgi?id=24158 Signed-off-by: Mark Wielaard <mark@klomp.org>
* tests: Check addsections test binary is 64bit for run-large-elf-file.shMark Wielaard2022-03-242-0/+15
| | | | | | | | | The test binary should be 64bit to be able to create 4GB, or larger, ELF files. https://sourceware.org/bugzilla/show_bug.cgi?id=28975 Signed-off-by: Mark Wielaard <mark@klomp.org>
View Lorry Controller Status