addr2line: Remove newline from strings returned by getline.

getline can return strings with a newline as last character when reading
from stdin. This could cause confusing symbol lookup failures like:
  addr2line: cannot find symbol 'foo
  '
So if the last character of the buf returned by getline is a newline just
null-terminate it right there. Also add a new testcase run-addr2line-test.sh.

Signed-off-by: Mark Wielaard <mjw@redhat.com>

1 files changed, 5 insertions, 1 deletions

diff --git a/src/addr2line.c b/src/addr2line.c
index c7e4629e..f2bc3255 100644
--- a/src/addr2line.c
+++ b/src/addr2line.c
@@ -152,11 +152,15 @@ main (int argc, char *argv[])
 
       char *buf = NULL;
       size_t len = 0;
+      ssize_t chars;
       while (!feof_unlocked (stdin))
 	{
-	  if (getline (&buf, &len, stdin) < 0)
+	  if ((chars = getline (&buf, &len, stdin)) < 0)
 	    break;
 
+	  if (buf[chars - 1] == '\n')
+	    buf[chars - 1] = '\0';
+
 	  result = handle_address (buf, dwfl);
 	}