diff options
| author | Omar Sandoval <osandov@fb.com> | 2019-12-11 17:29:44 -0800 |
|---|---|---|
| committer | Mark Wielaard <mark@klomp.org> | 2019-12-18 21:18:59 +0100 |
| commit | 2e75c987d591d3af313ee38a31ab677f6f4eb1ff (patch) | |
| tree | 7f2bfca702f5dca0ce5e82a34d222273fa1cfb3f /libdwfl/libdwflP.h | |
| parent | 277c2c54f5579523649a29d26966bfed35a159bf (diff) | |
| download | elfutils-2e75c987d591d3af313ee38a31ab677f6f4eb1ff.tar.gz | |
libdwfl: remove broken coalescing logic in dwfl_report_segment
dwfl_report_segment has some logic that detects when a segment is
contiguous with the previously reported segment, in which case it's
supposed to coalesce them. However, in this case, it actually returns
without updating the segment array at all. As far as I can tell, this
has always been broken. It appears that no one uses the coalescing logic
anyways, as they pass IDENT as NULL. Let's just get rid of the logic and
add a test case.
Signed-off-by: Omar Sandoval <osandov@fb.com>
Diffstat (limited to 'libdwfl/libdwflP.h')
| -rw-r--r-- | libdwfl/libdwflP.h | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/libdwfl/libdwflP.h b/libdwfl/libdwflP.h index f631f946..25753de2 100644 --- a/libdwfl/libdwflP.h +++ b/libdwfl/libdwflP.h @@ -132,12 +132,7 @@ struct Dwfl GElf_Addr *lookup_addr; /* Start address of segment. */ Dwfl_Module **lookup_module; /* Module associated with segment, or null. */ int *lookup_segndx; /* User segment index, or -1. */ - - /* Cache from last dwfl_report_segment call. */ - const void *lookup_tail_ident; - GElf_Off lookup_tail_vaddr; - GElf_Off lookup_tail_offset; - int lookup_tail_ndx; + int next_segndx; struct Dwfl_User_Core *user_core; }; |