diff options
| author | Ulf Hermann <ulf.hermann@qt.io> | 2017-08-18 14:05:10 +0200 |
|---|---|---|
| committer | Mark Wielaard <mark@klomp.org> | 2017-09-20 21:40:31 +0200 |
| commit | 17d7194d291bf91d130b78e06cbe27b290e0376d (patch) | |
| tree | 6197e445e38169e4672b80072dccabcca8d54dde /libdw/memory-access.h | |
| parent | b10d7eb74064c5906f031cd17c0f82041c6a4ca1 (diff) | |
| download | elfutils-17d7194d291bf91d130b78e06cbe27b290e0376d.tar.gz | |
Make sure packed structs follow the gcc memory layout
gcc defaults to using struct layouts that follow the native conventions,
even if __attribute__((packed)) is given. In order to get the layout we
expect, we need to tell gcc to always use the gcc struct layout, at
least for packed structs. To do this, we can use the gcc_struct
attribute.
This is important, not only for porting to windows, but also potentially
for other platforms, as the bugs resulting from struct layout
differences are rather subtle and hard to find.
Signed-off-by: Ulf Hermann <ulf.hermann@qt.io>
Diffstat (limited to 'libdw/memory-access.h')
| -rw-r--r-- | libdw/memory-access.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/libdw/memory-access.h b/libdw/memory-access.h index a749b5a9..afb651fc 100644 --- a/libdw/memory-access.h +++ b/libdw/memory-access.h @@ -170,7 +170,7 @@ union unaligned int16_t s2; int32_t s4; int64_t s8; - } __attribute__ ((packed)); + } attribute_packed; # define read_2ubyte_unaligned(Dbg, Addr) \ read_2ubyte_unaligned_1 ((Dbg)->other_byte_order, (Addr)) |