diff options
author | Yonggang Luo <luoyonggang@gmail.com> | 2022-10-21 02:25:43 +0800 |
---|---|---|
committer | Mark Wielaard <mark@klomp.org> | 2022-10-27 15:17:38 +0200 |
commit | 10f01dad96325706c746000e467e2a33197e6ea2 (patch) | |
tree | 5044cf982604c7da8c4714f3e1c9f6d556246966 | |
parent | eae6ad37f96826b1b7ddf269ee4d753079054413 (diff) | |
download | elfutils-10f01dad96325706c746000e467e2a33197e6ea2.tar.gz |
libelf/libdwfl: Remove LIB_SYSTEM_H define in lib{elf,dwfl}_crc32.c
rationale: https://sourceware.org/bugzilla/show_bug.cgi?id=21001
If we don't remove this macro, when try #include <system.h> in
libdw/memory-access.h wont' take effect because
"#define LIB_SYSTEM_H 1"
The compile error:
./../libdw/memory-access.h:390:12: error: implicit declaration of
function ‘bswap_32’ [-Werror=implicit-function-declaration]
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
-rw-r--r-- | libdwfl/ChangeLog | 4 | ||||
-rw-r--r-- | libdwfl/libdwfl_crc32.c | 1 | ||||
-rw-r--r-- | libelf/ChangeLog | 4 | ||||
-rw-r--r-- | libelf/libelf_crc32.c | 1 |
4 files changed, 8 insertions, 2 deletions
diff --git a/libdwfl/ChangeLog b/libdwfl/ChangeLog index faa97fca..5254ac45 100644 --- a/libdwfl/ChangeLog +++ b/libdwfl/ChangeLog @@ -1,3 +1,7 @@ +2022-10-21 Yonggang Luo <luoyonggang@gmail.com> + + * libdwfl_crc32.c: Remove LIB_SYSTEM_H define. + 2022-09-20 Yonggang Luo <luoyonggang@gmail.com> * dwfl_segment_report_module.c: Use BYTE_ORDER, LITTLE_ENDIAN and diff --git a/libdwfl/libdwfl_crc32.c b/libdwfl/libdwfl_crc32.c index b89d0d36..5bc7a4ad 100644 --- a/libdwfl/libdwfl_crc32.c +++ b/libdwfl/libdwfl_crc32.c @@ -30,6 +30,5 @@ #endif #define crc32 attribute_hidden __libdwfl_crc32 -#define LIB_SYSTEM_H 1 #include <libdwflP.h> #include "../lib/crc32.c" diff --git a/libelf/ChangeLog b/libelf/ChangeLog index 86b12e81..aefb31b3 100644 --- a/libelf/ChangeLog +++ b/libelf/ChangeLog @@ -1,3 +1,7 @@ +2022-10-21 Yonggang Luo <luoyonggang@gmail.com> + + * libelf_crc32.c: Remove LIB_SYSTEM_H define. + 2022-09-20 Yonggang Luo <luoyonggang@gmail.com> * elf32_checksum.c: Use BYTE_ORDER, LITTLE_ENDIAN and BIG_ENDIAN. diff --git a/libelf/libelf_crc32.c b/libelf/libelf_crc32.c index 1426faf1..f1cf4868 100644 --- a/libelf/libelf_crc32.c +++ b/libelf/libelf_crc32.c @@ -30,6 +30,5 @@ #endif #define crc32 attribute_hidden __libelf_crc32 -#define LIB_SYSTEM_H 1 #include <libelf.h> #include "../lib/crc32.c" |