diff options
| author | Mark Wielaard <mjw@redhat.com> | 2014-04-22 23:26:34 +0200 |
|---|---|---|
| committer | Mark Wielaard <mjw@redhat.com> | 2014-04-24 11:33:54 +0200 |
| commit | 7c680a24bcc1757c2b01152dd52fdbd55e7846bb (patch) | |
| tree | ced17961da18ee3ed943172ee88fdf40e5747bf7 | |
| parent | 740d1fe49758f28aad50b1d67b139a1564d73bbd (diff) | |
| download | elfutils-7c680a24bcc1757c2b01152dd52fdbd55e7846bb.tar.gz | |
readelf: handle_core_item make sure variable length array isn't zero size.
The printed array should have at least space for the terminating zero char.
Found by gcc -fsanitize=undefined while running run-readelf-vmcoreinfo.sh.
runtime error: variable length array bound evaluates to non-positive value 0
Signed-off-by: Mark Wielaard <mjw@redhat.com>
| -rw-r--r-- | src/ChangeLog | 5 | ||||
| -rw-r--r-- | src/readelf.c | 2 |
2 files changed, 6 insertions, 1 deletions
diff --git a/src/ChangeLog b/src/ChangeLog index 874e2553..28e52f94 100644 --- a/src/ChangeLog +++ b/src/ChangeLog @@ -1,5 +1,10 @@ 2014-04-22 Mark Wielaard <mjw@redhat.com> + * readelf.c (handle_core_item): Make sure variable length array + contains at least enough space for terminating zero char. + +2014-04-22 Mark Wielaard <mjw@redhat.com> + * readelf.c (print_gdb_index_section): Use unsigned int for 31 bits left shift. diff --git a/src/readelf.c b/src/readelf.c index da1bf73a..697a361b 100644 --- a/src/readelf.c +++ b/src/readelf.c @@ -8128,7 +8128,7 @@ handle_core_item (Elf *core, const Ebl_Core_Item *item, const void *desc, const unsigned int bias = item->format == 'b'; { - char printed[(negate ? nbits - pop : pop) * 16]; + char printed[(negate ? nbits - pop : pop) * 16 + 1]; char *p = printed; *p = '\0'; |