summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMark Wielaard <mark@klomp.org>2019-04-30 20:36:39 +0200
committerMark Wielaard <mark@klomp.org>2019-04-30 20:36:39 +0200
commit6978871366465aac849a303b2ea05ff5ab602261 (patch)
treeb07a282a4f16b4c7b879bc0394a2b349826e1c54
parentee7407342e4d4e7ddf97f3a28649ba44ad142550 (diff)
downloadelfutils-6978871366465aac849a303b2ea05ff5ab602261.tar.gz
tests: Don't printf a known NULL symname.
GCC9 on 32bit systems might warn about '%s' directive argument is null for symname in backtrace.c. Just check whether symname is NULL. Signed-off-by: Mark Wielaard <mark@klomp.org>
-rw-r--r--tests/ChangeLog4
-rw-r--r--tests/backtrace.c2
2 files changed, 5 insertions, 1 deletions
diff --git a/tests/ChangeLog b/tests/ChangeLog
index 71aa178d..a4f5dd3e 100644
--- a/tests/ChangeLog
+++ b/tests/ChangeLog
@@ -1,3 +1,7 @@
+2019-04-30 Mark Wielaard <mark@klomp.org>
+
+ * backtrace.c (frame_callback): Explicitly check symname is NULL.
+
2019-03-04 Mark Wielaard <mark@klomp.org>
* backtrace.c (tgkill): Remove define.
diff --git a/tests/backtrace.c b/tests/backtrace.c
index ecf55830..36c8b8c4 100644
--- a/tests/backtrace.c
+++ b/tests/backtrace.c
@@ -185,7 +185,7 @@ frame_callback (Dwfl_Frame *state, void *frame_arg)
symname = dwfl_module_addrname (mod, pc_adjusted);
printf ("#%2d %#" PRIx64 "%4s\t%s\n", *framenop, (uint64_t) pc,
- ! isactivation ? "- 1" : "", symname);
+ ! isactivation ? "- 1" : "", symname ?: "<null>");
pid_t tid = dwfl_thread_tid (thread);
callback_verify (tid, *framenop, pc, symname, dwfl);
(*framenop)++;