summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSebastiaan van Stijn <thaJeztah@users.noreply.github.com>2023-05-10 21:29:20 +0200
committerGitHub <noreply@github.com>2023-05-10 21:29:20 +0200
commitce79cd19f6be0ba07d3fa8573ebd317cc3bf7514 (patch)
tree24f761a48fdda4f1d3a21dd52f85c32409512d2b
parente9eff01dcad5d525549aa89fa13998903c911d45 (diff)
parent763d2b7996021f7dae14196649e27ddc225eaa9c (diff)
downloaddocker-ce79cd19f6be0ba07d3fa8573ebd317cc3bf7514.tar.gz
Merge pull request #45514 from laurazard/cherry-pick-dangling-history
[24.0 backport] c8d: image history – handle dangling images
-rw-r--r--daemon/containerd/image_history.go9
1 files changed, 6 insertions, 3 deletions
diff --git a/daemon/containerd/image_history.go b/daemon/containerd/image_history.go
index a99716ead7..a2d0c11425 100644
--- a/daemon/containerd/image_history.go
+++ b/daemon/containerd/image_history.go
@@ -90,13 +90,16 @@ func (i *ImageService) ImageHistory(ctx context.Context, name string) ([]*imaget
return nil, err
}
- tags := make([]string, len(tagged))
- for i, t := range tagged {
+ var tags []string
+ for _, t := range tagged {
+ if isDanglingImage(t) {
+ continue
+ }
name, err := reference.ParseNamed(t.Name)
if err != nil {
return nil, err
}
- tags[i] = reference.FamiliarString(name)
+ tags = append(tags, reference.FamiliarString(name))
}
history[0].Tags = tags
}