Add note about potential dockerignore optimization.

Signed-off-by: mefyl <quentin.hocquet@docker.com>

1 files changed, 9 insertions, 0 deletions

diff --git a/docker/utils/build.py b/docker/utils/build.py
index 09b2071..1da56fb 100644
--- a/docker/utils/build.py
+++ b/docker/utils/build.py
@@ -95,6 +95,15 @@ def walk(root, patterns, default=True):
             # be included.
             if all(not p[0] for p in sub) and not matched:
                 continue
+            # I think this would greatly speed up dockerignore handling by not
+            # recursing into directories we are sure would be entirely
+            # included, and only yielding the directory itself, which will be
+            # recursively archived anyway. However the current unit test expect
+            # the full list of subfiles and I'm not 100% sure it would make no
+            # difference yet.
+            # if all(p[0] for p in sub) and matched:
+            #     yield f
+            #     continue
             children = False
             for r in (os.path.join(f, p) for p in walk(cur, sub, matched)):
                 yield r