diff options
| author | Joffrey F <f.joffrey@gmail.com> | 2017-12-13 19:09:13 -0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-12-13 19:09:13 -0800 |
| commit | 20b5b58bb00b5cb4c4770c3fa37b64611bf79d78 (patch) | |
| tree | d4a99f552cda4bdcd69932822671901205d07543 | |
| parent | 1df979a58f7583ba23ce7b9eb6b4e06d935104a8 (diff) | |
| parent | 7db76737ca661f242f9345a2be9a317c79da7575 (diff) | |
| download | docker-py-20b5b58bb00b5cb4c4770c3fa37b64611bf79d78.tar.gz | |
Merge pull request #1835 from docker/1758-url-quote-path
Fix URL-quoting for resource names containing spaces
| -rw-r--r-- | docker/api/client.py | 2 | ||||
| -rw-r--r-- | tests/integration/api_network_test.py | 7 |
2 files changed, 8 insertions, 1 deletions
diff --git a/docker/api/client.py b/docker/api/client.py index cbe74b9..01a83ea 100644 --- a/docker/api/client.py +++ b/docker/api/client.py @@ -206,7 +206,7 @@ class APIClient( 'instead'.format(arg, type(arg)) ) - quote_f = partial(six.moves.urllib.parse.quote_plus, safe="/:") + quote_f = partial(six.moves.urllib.parse.quote, safe="/:") args = map(quote_f, args) if kwargs.get('versioned_api', True): diff --git a/tests/integration/api_network_test.py b/tests/integration/api_network_test.py index f4fefde..10e09dd 100644 --- a/tests/integration/api_network_test.py +++ b/tests/integration/api_network_test.py @@ -484,3 +484,10 @@ class TestNetworks(BaseAPIIntegrationTest): assert self.client.inspect_network(net_name_swarm, scope='swarm') with pytest.raises(docker.errors.NotFound): self.client.inspect_network(net_name_swarm, scope='local') + + @requires_api_version('1.21') + def test_create_remove_network_with_space_in_name(self): + net_id = self.client.create_network('test 01') + self.tmp_networks.append(net_id) + assert self.client.inspect_network('test 01') + assert self.client.remove_network('test 01') is None # does not raise |