summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorklarlund <klarlund@gmail.com>2008-05-29 01:57:24 +0000
committerklarlund <klarlund@gmail.com>2008-05-29 01:57:24 +0000
commitc37e5150d1d66ce3cb7f9cd68d75bfd68aea4cee (patch)
tree0917ddf0d137ad513b871c245da1ad4e12df2c4a
parent218ce6d045d52a75682178ee4dcd5a1849130779 (diff)
downloaddistcc-git-c37e5150d1d66ce3cb7f9cd68d75bfd68aea4cee.tar.gz
Add critique of pump-mode when include server shuts down.
Print a message like: __________Warning: 1 pump-mode compilation(s) failed on server, but succeeded locally. when compile discrepancies have occurred. Currently, a user may think that all is well because we do not terminate a build when discrepancies occur and the warning messages occurring in the middle of a build may easily be overlooked. REVIEW: csilvers@google.com TESTS: make linux-kernel without stat reset triggers to observe message
-rwxr-xr-xpump.in13
1 files changed, 13 insertions, 0 deletions
diff --git a/pump.in b/pump.in
index a3cabae..0618efa 100755
--- a/pump.in
+++ b/pump.in
@@ -319,7 +319,20 @@ StartIncludeServer() {
fi
}
+Critique() {
+ # The discrepancy_counter file is created when a pump-mode distcc invocation
+ # failed remotely but succeeded locally.
+ if [ -f $socket_dir/discrepancy_counter ]; then
+ echo -n '__________Warning: ' 1>&2
+ echo -n `cat $socket_dir/discrepancy_counter | wc -c`' ' 1>&2
+ echo -n 'pump-mode compilation(s) failed on server, ' 1>&2
+ echo 'but succeeded locally.' 1>&2
+ echo '__________See pump.1 manual page.' 1>&2
+ fi
+}
+
ShutDown() {
+ Critique
# Always -- at exit -- shut down include_server and remove $socket_dir
if [ -n "$include_server_pid" ] && \
ps -p "$include_server_pid" > /dev/null; then