summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* 1.6.14dbus-1.6.16Simon McVittie2013-10-082-3/+3
|
* NEWS for 1.6.xSimon McVittie2013-09-161-0/+5
|
* dbus-sysdeps-unix.c: undeclared ret2 variable if HAVE_WRITEV undefined.Vasiliy Balyasnyy2013-09-161-1/+1
| | | | | Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk> Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69409
* Fix a NULL dereference on an error code path.Sviatoslav Chagaev2013-09-161-1/+4
| | | | | Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69327 Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
* NEWSSimon McVittie2013-09-131-1/+17
|
* Check EINVAL for accept4()Chengwei Yang2013-09-131-2/+6
| | | | | | | | It was reported that accept4() will return -1 with errrno is EINVAL on arm platform, so check EINVAL for accept4() and retry accept(). Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69026 Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
* Allow EPROTOTYPE for SOCK_CLOEXEC but unsupported by socket/socketpairPino Toscano2013-09-131-3/+3
| | | | | | | | | | | If SOCK_CLOEXEC is defined (usually because accept4 is implemented), check for EPROTOTYPE (the POSIX errno for invalid socket types) in addition to EINVAL as errno indicating whether socket and socketpair do not support SOCK_CLOEXEC (and other SOCK_* flags). [adapted by Chengwei Yang to give _dbus_connect_exec() the same treatment] Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69073 Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
* Check EINVAL for socketpair and retry without SOCK_CLOEXECChengwei Yang2013-09-131-5/+16
| | | | | | | | | | | | As the same as _dbus_open_socket() and _dbus_full_duplex_pipe(), socketpair() may fail with EINVAL if call with SOCK_CLOEXEC. Check for the failure and retry without SOCK_CLOEXEC, in addition, only call _dbus_fd_set_close_on_exec() if the socketpair failure happened. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69073 [trivial coding style fixes -smcv] Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
* Use the argument of dbus_connection_set_route_peer_messages()Chengwei Yang2013-09-131-1/+1
| | | | | | | | | | The function dbus_connection_set_route_peer_messages() take a bool argument, however, in the implementation, it always hard-code to TRUE rather than take its bool argument. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69165 [amended commit message -smcv] Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
* Fix file descriptor leak in _dbus_command_for_pidSviatoslav Chagaev2013-09-131-0/+1
| | | | | | | | | Fix a file descriptor not being closed when an error codepath is taken. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69182 Reviewed-by: Chengwei Yang <chengwei.yang@intel.com> [more specific commit message -smcv] Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
* 1.6.15Simon McVittie2013-09-052-1/+6
|
* 1.6.14dbus-1.6.14Simon McVittie2013-09-052-2/+7
|
* _dbus_babysitter_unref: avoid infinite loop if waitpid() returns EINTRSimon McVittie2013-09-051-5/+8
| | | | | | | | | | | If waitpid() failed with EINTR, we'd go back for another go, but because ret is nonzero, we'd skip the waitpid() and just keep looping. Also avoid an unnecessary "goto" in favour of a proper loop, to make it more clearly correct. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=68945 Reviewed-by: Colin Walters <walters@verbum.org>
* NEWS for 1.6Simon McVittie2013-09-051-0/+5
|
* Use iface instead of interface in function parametersIvan Romanov2013-09-052-37/+37
| | | | | | Bug: https://bugs.freedesktop.org/show_bug.cgi?id=66493 Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk> (cherry picked from commit 0928169cf80bf767f7246ecaa52cc01e198bb15a)
* run-with-tmp-session-bus.sh: create a unique temporary file per processSimon McVittie2013-09-052-4/+7
| | | | | | | | This makes the regression tests OK to run in parallel. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=68852 Reviewed-by: Ralf Habacker <ralf.habacker@freenet.de> (cherry picked from commit 9d80d46a794e0770494aa517d1b94e7e6ea9e21d)
* NEWS for 1.6Simon McVittie2013-09-051-0/+3
|
* test/marshal: Ensure we use suitably aligned buffersColin Walters2013-07-251-5/+22
| | | | | | | | | This test was failing on s390; though it could fail on other platforms too. Basically we need to be sure we're passing at least word-aligned buffers to the demarshalling code. malloc() will do that for us. https://bugs.freedesktop.org/show_bug.cgi?id=67279
* NEWS for 1.6.xSimon McVittie2013-07-011-0/+3
|
* Make the test for #53499 more obviously correctSimon McVittie2013-07-011-1/+1
|
* Test: add a test case for escaping byte > 127Chengwei Yang2013-07-011-1/+3
| | | | | | Bug: https://bugs.freedesktop.org/show_bug.cgi?id=53499 Signed-off-by: Chengwei Yang <chengwei.yang@intel.com> Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
* Fix: a non ascii byte will trigger BadAddress errorChengwei Yang2013-07-013-5/+5
| | | | | | | | | | | | | | | | | | If a byte in DBusString *unescaped isn't a ascii byte, which will be cast to char (signed char on most of platform), so that's the issue unsigned char cast to signed char. e.g. "\303\266" is a valid unicode character, if everything goes right, it will be escaped to "%c3%b6". However, in fact, it escaped to "%<garbage-byte>3%<garbage-byte>6". _dbus_string_append_byte_as_hex() take an int parameter, so negative byte is valid, but cause get a negative index in array. So garbage value will get. e.g. '\303' --> hexdigits[((signed byte)(-61)) >> 4] is hexdigits[-4]. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=53499 Sgne-off-by: Chengwei Yang <chengwei.yang@intel.com> [fixed whitespace -smcv] Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
* NEWSSimon McVittie2013-06-281-0/+3
|
* Remove invoke of va_end before va_startChengwei Yang2013-06-281-2/+1
| | | | | | Signed-off-by: Chengwei Yang <chengwei.yang@intel.com> Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk> Bug: https://bugs.freedesktop.org/show_bug.cgi?id=66300
* NEWS for #65959Simon McVittie2013-06-201-1/+4
|
* DBusString: fix may crash if try to free an uninitialized strChengwei Yang2013-06-201-0/+8
| | | | | | | | | | If the str will be freed hasn't been initialized by _dbus_string_init correctly, _dbus_string_free may crash due to trying to free an undefined memory. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=65959 Signed-off-by: Chengwei Yang <chengwei.yang@intel.com> Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
* Add release name for 1.6.12Simon McVittie2013-06-131-0/+2
|
* Start 1.6.13Simon McVittie2013-06-122-1/+6
|
* Prepare embargoed release for tomorrowdbus-1.6.12Simon McVittie2013-06-122-3/+7
|
* Add a test-case for CVE-2013-2168Simon McVittie2013-06-122-0/+94
| | | | | Reviewed-by: Thiago Macieira <thiago@kde.org> [build system adjusted to compile it even if we don't have GLib -smcv]
* CVE-2013-2168: _dbus_printf_string_upper_bound: copy the va_list for each useSimon McVittie2013-06-122-5/+20
| | | | | | | | | | | | | Using a va_list more than once is non-portable: it happens to work under the ABI of (for instance) x86 Linux, but not x86-64 Linux. This led to _dbus_printf_string_upper_bound() crashing if it should have returned exactly 1024 bytes. Many system services can be induced to process a caller-controlled string in ways that end up using _dbus_printf_string_upper_bound(), so this is a denial of service. Reviewed-by: Thiago Macieira <thiago@kde.org>
* NEWS for 1.6.xSimon McVittie2013-06-121-1/+10
|
* Fix dbus-daemon crash due to invalid service fileChengwei Yang2013-06-121-0/+6
| | | | | | | | | | dbus-daemon will crash due to invalid service file which key/value starts before section. In that situation, new_line() will try to access invalid address. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=60853 Signed-off-by: Chengwei Yang <chengwei.yang@intel.com> Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
* Fix build error: unused-resultChengwei Yang2013-06-051-2/+8
| | | | | Signed-off-by: Chengwei Yang <chengwei.yang@intel.com> Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
* When "activating" systemd, handle its special case betterChengwei Yang2013-06-051-5/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | When dbus-daemon receives a request to activate a systemd service before systemd has connected to it, it enqueues a fake request to "activate" systemd itself (as a way to get a BusPendingActivationEntry to track the process of waiting for systemd). When systemd later joins the bus, dbus-daemon sends the actual activation message; any future activation messages are sent directly to systemd. In the "pending" code path, the activation messages are currently dispatched as though they had been sent by the same process that sent the original activation request, which is wrong: the bus security policy probably doesn't allow that process to talk to systemd directly. They should be dispatched as though they had been sent by the dbus-daemon itself (connection == NULL), the same as in the non-pending code path. In the worst case, if the attempt to activate systemd timed out, the dbus-daemon would crash with a (fatal) warning, because in this special case, activation_message is a signal with no serial number, whereas the code to send an error reply is expecting a method call with a serial number. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=50199 Signed-off-by: Chengwei Yang <chengwei.yang@intel.com> Tested-by: Ma Yu <yu.ma@intel.com> Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
* development versionSimon McVittie2013-04-242-1/+6
|
* Prepare release 1.6.10dbus-1.6.10Simon McVittie2013-04-242-3/+5
|
* NEWS for 1.6Simon McVittie2013-04-221-0/+4
|
* Accept non-characters when validating UnicodeSimon McVittie2013-04-222-11/+5
| | | | | | | | | | | | | Unicode Corrigendum #9 clarifies that the non-characters U+nFFFE (for n in the range 0 to 0x10), U+nFFFF (for n in the same range), and U+FDD0..U+FDEF are valid for interchange, and their presence does not make a string ill-formed. GLib 2.36 made the corresponding change in its definition of UTF-8 as used by g_utf8_validate() and similar functions. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=63072 Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
* Allow use of GLib 2.32 functionality, which we do conditionallySimon McVittie2013-04-051-1/+1
|
* Don't warn for functions deprecated since GLib 2.26Simon McVittie2013-04-051-0/+3
| | | | | | | | Also warn if we inadvertently use a function introduced since then. Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk> Bug: https://bugs.freedesktop.org/show_bug.cgi?id=59971 Reviewed-by: Colin Walters <walters@verbum.org>
* NEWS for 1.6Simon McVittie2013-04-051-0/+4
|
* Don't access random memory if data slot isn't allocated yetDan Williams2013-04-051-1/+2
| | | | | | | | | | | | If DBUS_DISABLE_ASSERTS was turned on, and a buggy program called dbus_connection_get_data() with a slot number less than zero (eg, before even allocating the data slot), random memory would be accessed and a random value returned. Anything less than zero is not a valid slot number and should be rejected by libdbus. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=63127 Signed-off-by: Dan Williams <dcbw@redhat.com> Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
* NEWS for 1.6Simon McVittie2013-04-031-0/+4
|
* If alloca.h is available it is required (e.g. on Solaris 10)Dagobert Michelsen2013-04-032-0/+5
| | | | | Bug: https://bugs.freedesktop.org/show_bug.cgi?id=63071 Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
* NEWS for 1.6Simon McVittie2013-02-121-0/+3
|
* Create missing directories in cmake <build-root>/bus/session.d and ↵Ralf Habacker2013-01-151-0/+3
| | | | | | | <build-root>/bus/system.d Bug: https://bugs.freedesktop.org/show_bug.cgi?id=41319 Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
* NEWSSimon McVittie2012-11-091-1/+7
|
* Don't leak temporary fds pointing to /dev/nullMichel HERMIER2012-11-092-0/+2
| | | | | | Bug: https://bugs.freedesktop.org/show_bug.cgi?id=56927 [commit message added -smcv] Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
* Fix building with newer ValgrindArun Raghavan2012-11-092-10/+10
| | | | | | | | | Newer valgrind (tried with 3.8.0) defines macros so that a terminating semi-colon is required. This fixes usage to follow that convention. [edited to remove comments that are no longer useful -smcv] Bug: https://bugs.freedesktop.org/show_bug.cgi?id=55932 Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
View Lorry Controller Status