summaryrefslogtreecommitdiff
path: root/dbus/dbus-spawn.h
diff options
context:
space:
mode:
authorSimon McVittie <smcv@collabora.com>2018-12-20 15:27:03 +0000
committerRalf <ralf@linux1.fritz.box>2019-01-05 11:41:58 +0100
commit88032367a960c96989a964006d28aa2f6851e4a8 (patch)
tree54cd08a9dfa702711235e2124eda2b8b8eeba12d /dbus/dbus-spawn.h
parent5b72329d7d5947e0613a69a4b2d69975bd4a5b46 (diff)
downloaddbus-88032367a960c96989a964006d28aa2f6851e4a8.tar.gz
dbus-spawn: Don't take ownership of envp
It's unexpected for a function to take ownership of its arguments without indicating that in its name, or at least documenting it. The only caller with envp != NULL is in bus_activation_activate_service(), which has been updated. Based on part of a larger commit by Ralf Habacker. Signed-off-by: Simon McVittie <smcv@collabora.com>
Diffstat (limited to 'dbus/dbus-spawn.h')
-rw-r--r--dbus/dbus-spawn.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/dbus/dbus-spawn.h b/dbus/dbus-spawn.h
index b36b1d86..03458d0a 100644
--- a/dbus/dbus-spawn.h
+++ b/dbus/dbus-spawn.h
@@ -47,7 +47,7 @@ typedef enum {
dbus_bool_t _dbus_spawn_async_with_babysitter (DBusBabysitter **sitter_p,
const char *log_name,
char * const *argv,
- char **env,
+ char * const *env,
DBusSpawnFlags flags,
DBusSpawnChildSetupFunc child_setup,
void *user_data,