summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSimon McVittie <simon.mcvittie@collabora.co.uk>2011-03-03 16:55:55 +0000
committerSimon McVittie <simon.mcvittie@collabora.co.uk>2011-03-10 19:06:20 +0000
commit1aa5aaa9e297eaed231cf0270d097fe4284dc274 (patch)
tree70db2124e600d4ed31ce5ee883a9623cdc40a89b
parentabdd6adf06ac27a5488f3e8e11570a86fab58b92 (diff)
downloaddbus-1aa5aaa9e297eaed231cf0270d097fe4284dc274.tar.gz
_dbus_marshal_write_fixed_multi: remove obsolete FIXME comment
As far as I can tell, we've never accepted out-of-range booleans and canonicalized them, ever since this was first committed in 2004. If sent, they'd be considered to be invalid by recipients, so they're unambiguously an error. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=35182 Reviewed-by: Will Thompson <will.thompson@collabora.co.uk>
-rw-r--r--dbus/dbus-marshal-basic.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/dbus/dbus-marshal-basic.c b/dbus/dbus-marshal-basic.c
index ea18dbf3..3cbc7216 100644
--- a/dbus/dbus-marshal-basic.c
+++ b/dbus/dbus-marshal-basic.c
@@ -1065,8 +1065,6 @@ _dbus_marshal_write_fixed_multi (DBusString *str,
case DBUS_TYPE_INT16:
case DBUS_TYPE_UINT16:
return marshal_fixed_multi (str, insert_at, vp, n_elements, byte_order, 2, pos_after);
- /* FIXME: we canonicalize to 0 or 1 for the single boolean case
- * should we here too ? */
case DBUS_TYPE_BOOLEAN:
case DBUS_TYPE_INT32:
case DBUS_TYPE_UINT32: