summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorWill Thompson <will.thompson@collabora.co.uk>2010-02-04 20:24:54 +0000
committerWill Thompson <will.thompson@collabora.co.uk>2010-03-19 17:47:40 +0000
commitaf95ba7c8eafaff6c5a8ab8dd2784427b168cab5 (patch)
tree9050e26cc58fcb80a95d4278aaf8d01432a7ea8a
parentaa275ff175180f9635c473bfb56912835aa488af (diff)
downloaddbus-af95ba7c8eafaff6c5a8ab8dd2784427b168cab5.tar.gz
Dispatch post-activation messages to anyone interested
Previously, if a method call activated a service, it would only be delivered to that service, and not to other services with match rules which should match. This patch replaces the improperly-duplicated dispatch code in activation.c with a call back into the normal dispatch code, fixing this bug (fd.o#26427).
-rw-r--r--bus/activation.c20
1 files changed, 6 insertions, 14 deletions
diff --git a/bus/activation.c b/bus/activation.c
index 0a28df16..2fcd85d2 100644
--- a/bus/activation.c
+++ b/bus/activation.c
@@ -25,6 +25,7 @@
#include "activation.h"
#include "activation-exit-codes.h"
#include "desktop-file.h"
+#include "dispatch.h"
#include "services.h"
#include "test.h"
#include "utils.h"
@@ -1132,21 +1133,12 @@ bus_activation_send_pending_auto_activation_messages (BusActivation *activation
addressed_recipient = bus_service_get_primary_owners_connection (service);
- /* Check the security policy, which has the side-effect of adding an
- * expected pending reply.
- */
- if (!bus_context_check_security_policy (activation->context, transaction,
- entry->connection,
- addressed_recipient,
- addressed_recipient,
- entry->activation_message, error))
+ /* Resume dispatching where we left off in bus_dispatch() */
+ if (!bus_dispatch_matches (transaction,
+ entry->connection,
+ addressed_recipient,
+ entry->activation_message, error))
goto error;
-
- if (!bus_transaction_send (transaction, addressed_recipient, entry->activation_message))
- {
- BUS_SET_OOM (error);
- goto error;
- }
}
link = next;