diff options
| author | Ralf Habacker <ralf.habacker@freenet.de> | 2015-04-22 14:47:08 +0200 |
|---|---|---|
| committer | Ralf Habacker <ralf.habacker@freenet.de> | 2015-04-28 22:57:45 +0200 |
| commit | 08e2b810622096e84e9c9099450bfadf5768e97e (patch) | |
| tree | 96eadc404d484d5e664f5f54f2f6f55a366461bb | |
| parent | 620ca3ebe4079a7944e30dc8e237578c9b6145f8 (diff) | |
| download | dbus-08e2b810622096e84e9c9099450bfadf5768e97e.tar.gz | |
dbus_server_set_auth_mechanisms: Fix returning without unlocking server->mutex->lock (CID 54749).
Reported by Coverity: CID 54749: Missing unlock (LOCK)
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=90021
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
| -rw-r--r-- | dbus/dbus-server.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/dbus/dbus-server.c b/dbus/dbus-server.c index c1d5f6e5..7b810792 100644 --- a/dbus/dbus-server.c +++ b/dbus/dbus-server.c @@ -1043,7 +1043,10 @@ dbus_server_set_auth_mechanisms (DBusServer *server, { copy = _dbus_dup_string_array (mechanisms); if (copy == NULL) - return FALSE; + { + SERVER_UNLOCK (server); + return FALSE; + } } else copy = NULL; |