summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* update NEWS, release 0.102dbus-glib_0.102Simon McVittie2014-02-122-4/+15
|
* ignore more Automake droppingsSimon McVittie2014-02-121-0/+2
|
* dbus-binding-tool: check for valid interface, member and property namesSimon McVittie2014-01-142-1/+46
| | | | | | | | | | Properties are currently allowed to be arbitrary UTF-8 since this matches dbus-glib's runtime behaviour, although ideally new interfaces should use the more restrictive member naming rules (leading to names like MyProperty) for interop with QtDBus. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=7909 Reviewed-by: Cosimo Alfarano <cosimo.alfarano@collabora.co.uk>
* dbus_g_value_build_g_variant(): Fix NULL string caseXavier Claessens2014-01-141-1/+4
| | | | | | | g_variant_new_string(NULL) is not accepted. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=71811 Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
* dbus_g_value_build_g_variant(): Fix NULL strv caseXavier Claessens2014-01-141-1/+4
| | | | | | | g_variant_new_strv(NULL, -1) is not accepted, but (NULL, 0) is good. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=71811 Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
* Fix yet another leak, this one caused by poor documentation (#29195)Simon McVittie2013-10-211-0/+7
| | | | | Bug: https://bugs.freedesktop.org/show_bug.cgi?id=41129 Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
* Add a list of Valgrind suppressions for false-positivesSimon McVittie2013-10-212-0/+361
| | | | | Bug: https://bugs.freedesktop.org/show_bug.cgi?id=41129 Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
* Add infrastructure for running tests under valgrindSimon McVittie2013-10-214-0/+39
| | | | | Bug: https://bugs.freedesktop.org/show_bug.cgi?id=41129 Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
* test-dbus-glib: free numerous leaked objects, and clean up more thoroughlySimon McVittie2013-10-211-4/+26
| | | | | Bug: https://bugs.freedesktop.org/show_bug.cgi?id=41129 Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
* Separate the test for shared-bus equivalence into its own binarySimon McVittie2013-10-215-6/+142
| | | | | | | | | When valgrinding tests it's useful to avoid using the shared bus, which cannot be closed. Move all the essential shared-bus use into a test which can be treated specially. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=41129 Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
* test-types: use a private bus, and close it afterwardsSimon McVittie2013-10-211-3/+5
| | | | | | | This frees more of the memory. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=41129 Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
* registrations test: run the connections to completion and call dbus_shutdownSimon McVittie2013-10-211-2/+6
| | | | | | | This frees more of the memory. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=41129 Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
* 30574 test: use a private bus so we can free it more thoroughlySimon McVittie2013-10-211-1/+9
| | | | | Bug: https://bugs.freedesktop.org/show_bug.cgi?id=41129 Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
* test-variant-recursion: use a private bus so we can free it more thoroughlySimon McVittie2013-10-211-2/+10
| | | | | Bug: https://bugs.freedesktop.org/show_bug.cgi?id=41129 Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
* test-variant-recursion: free our GValues and the output string correctlySimon McVittie2013-10-211-19/+26
| | | | | | | | | | | | Previously, if we'd freed the GValues, it would have crashed, because g_value_take_boxed on a value of type G_TYPE_VALUE requires that the inner GValue was g_malloc'd individually, but we were allocating them as a block. This only "worked" because *none* of them were freed... The returned string was also leaked; free it too, but only on success. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=41129 Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
* registrations test: bin some unused variablesSimon McVittie2013-10-211-3/+0
| | | | | Bug: https://bugs.freedesktop.org/show_bug.cgi?id=41129 Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
* interfaces test: don't call an undefined function on failure, just use set -eSimon McVittie2013-10-211-1/+3
| | | | | Bug: https://bugs.freedesktop.org/show_bug.cgi?id=41129 Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
* test-client: wait for disconnection, to get more state freedSimon McVittie2013-10-211-1/+14
| | | | | Bug: https://bugs.freedesktop.org/show_bug.cgi?id=41129 Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
* test-client: don't leak NodeInfo and one proxySimon McVittie2013-10-211-0/+4
| | | | | Bug: https://bugs.freedesktop.org/show_bug.cgi?id=41129 Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
* 30574 test: don't leak two messages and a pending call per runSimon McVittie2013-10-211-0/+3
| | | | | Bug: https://bugs.freedesktop.org/show_bug.cgi?id=41129 Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
* Add a regression test for CVE-2013-0292Simon McVittie2013-10-212-0/+268
| | | | | | | | Inspired by Sebastian Krahmer's 'darklena.c', which used this bug to exploit pam_fprintd. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=68603 Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
* Update HACKING for current statusSimon McVittie2013-10-211-6/+9
| | | | | Bug: https://bugs.freedesktop.org/show_bug.cgi?id=68602 Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
* Bring back NEWSSimon McVittie2013-10-211-4/+368
| | | | | | | | | I'm the only one who does dbus-glib releases these days, and I find it easier to track changes as we go along than to construct a change list during the release process. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=68602 Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
* README: replace with a deprecation warningSimon McVittie2013-10-211-28/+5
| | | | | | | Most of the README was really about libdbus anyway. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=68602 Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
* Avoid underlinking internal library libdbus-gtool.laSimon McVittie2013-10-211-1/+6
| | | | | | | | | | | | | | | | Anything that links libdbus-gtool needs to pull in GLib/GObject, and the order matters (things that libdbus-gtool depends on must appear after libdbus-gtool itself). libtool understands this, but only if you tell it the full dependencies. This broke compilation of test-dbus-glib.exe when cross-compiling for 32-bit Windows with mingw-w64 (GNU tuple: i686-w64-mingw32). The linking order used here for dependencies is "lowest in the stack first", as recommended by the GStreamer documentation. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=68601 Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
* tests: fix under-linkingSimon McVittie2013-10-211-0/+1
| | | | | | | The test for errors uses dbus_set_error() so it should link -ldbus-1. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=68601 Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
* Merge tag 'dbus-glib_0.100.2'Simon McVittie2013-02-250-0/+0
|\ | | | | | | | | | | | | dbus-glib_0.100.2 Conflicts: configure.ac
| * 0.102: respin tarballdbus-glib_0.100.2Simon McVittie2013-02-251-1/+1
| |
* | use AC_CONFIG_HEADERS, not AM_CONFIG_HEADERMarko Lindqvist2013-02-251-1/+1
| | | | | | | | | | | | | | | | | | | | Automake-1.13 removed long obsolete AM_CONFIG_HEADER completely <http://lists.gnu.org/archive/html/automake/2012-12/msg00038.html> and errors out upon seeing it. [commit message added -smcv] Bug: https://bugs.freedesktop.org/show_bug.cgi?id=59003 Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
* | Merge tag 'dbus-glib_0.100.1'Simon McVittie2013-02-151-3/+4
|\ \ | |/
| * 0.100.1 point releasedbus-glib_0.100.1Simon McVittie2013-02-151-1/+1
| |
| * CVE-2013-0292: dbus-gproxy: Verify sender of NameOwnerChanged signals to be ↵Colin Walters2013-02-151-3/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | o.f.DBus Anyone can hop on the bus and emit a signal whose interface is o.f.DBus; it's expected at the moments that clients (and notably DBus libraries) check the sender. This could previously be used to trick a system service using dbus-glib into thinking a malicious signal came from a privileged source, by claiming that ownership of the privileged source's well-known name had changed from the privileged source's real unique name to the attacker's unique name. [altered to be NULL-safe so it won't crash on peer connections -smcv] Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk> Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
* | Add a feature test for fd.o #23633, non-default main contextbaserock/morphSimon McVittie2012-12-044-0/+277
| | | | | | | | | | [rebased and added to run-test.sh -dbcw] Bug: https://bugs.freedesktop.org/show_bug.cgi?id=23633
* | test-profile: exit a bit more gracefullySimon McVittie2012-12-041-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We close the connection to ourselves, resulting in libdbus shooting us in the head unless we ask it not to. Nice to see how thoroughly this code has been tested... For future reference, it can be tested like this: DBUS_TOP_BUILDDIR=$(pwd) ./test/core/run-test.sh profile (or substitute the real absolute top build directory, if out-of-tree). Bug: https://bugs.freedesktop.org/show_bug.cgi?id=40711 Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk> Reviewed-by: Dan Williams <dcbw@redhat.com>
* | test-profile: actually initialize GLib, if requiredSimon McVittie2012-12-041-0/+4
| | | | | | | | | | | | | | | | | | It's alarming how often the phrase "I'm amazed this ever worked" comes up while maintaining dbus-glib. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=40711 Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk> Reviewed-by: Dan Williams <dcbw@redhat.com>
* | Remove check for abstract sockets, not relevant to dbus-glibSimon McVittie2012-12-043-87/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | test-profile.c was its only use, and all it was used for was to listen on an abstract or path-based socket, matching what D-Bus would do, when obtaining comparative performance figures for D-Bus vs. plain Unix sockets. test-profile.c isn't normally run, only works on Unix, and the check for abstract sockets was broken on current glibc (fd.o #29895), leading to us using the non-abstract code path anyway, so this clearly wasn't very important. I'm tempted to delete test-profile.c entirely, but until then, let's just make it use path-based sockets. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=40711 Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk> Reviewed-by: Dan Williams <dcbw@redhat.com>
* | Add DBusGMethodInvocation accessor for the DBusGConnectionDan Williams2012-12-042-0/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If you're using two connections, say a shared connection and a private connection that uses DBusServer, there's no way to figure out which DBusConnection a method invocation originates from, and thus no way to do access control based on that. Private bus setup done with eg: void new_conn_func(DBusServer *s, DBusConnection *conn, gpointer to_export) { DBusGConnection *gconn; /* set access control, eg with dbus_connection_set_unix_user_function() */ dbus_connection_setup_with_g_main(conn, NULL); gconn = dbus_connection_get_g_connection(conn); dbus_g_connection_register_object(gconn, "/foo", G_OBJECT (to_export)); } void start_server(GObject *to_export) { DBusServer *s; s = dbus_server_listen("unix:path=/var/foo", NULL); dbus_server_setup_with_g_main (s, NULL); dbus_server_set_new_connection_function (s, new_conn_func, to_export); } Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk> Bug: https://bugs.freedesktop.org/show_bug.cgi?id=55729
* | Add dbus_g_connection_open_private() for private D-Bus socketsDan Williams2012-12-042-0/+46
| | | | | | | | | | | | | | | | | | Like dbus_g_connection_open() but for private bus sockets, calling dbus_connection_open_private() and ensuring the dbus-glib types are initialized. Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk> Bug: https://bugs.freedesktop.org/show_bug.cgi?id=55730
* | Remove declaration of _dbus_gutils_test, which does not existSimon McVittie2012-11-191-1/+0
| | | | | | | | | | Bug: https://bugs.freedesktop.org/show_bug.cgi?id=40711 Reviewed-by: Dan Williams <dcbw@redhat.com>
* | Flatten _dbus_gmain_test into _dbus_gvalue_testSimon McVittie2012-11-194-47/+27
| | | | | | | | | | | | | | | | It actually only tests _dbus_gtype_from_signature and related things, and has nothing to do with main loop integration. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=40711 Reviewed-by: Dan Williams <dcbw@redhat.com>
* | Move _dbus_gvalue_utils_test into a separate binary, it only uses public APISimon McVittie2012-11-196-399/+492
| | | | | | | | | | Bug: https://bugs.freedesktop.org/show_bug.cgi?id=40711 Reviewed-by: Dan Williams <dcbw@redhat.com>
* | _dbus_gvalue_utils_test: don't call private APISimon McVittie2012-11-191-1/+0
| | | | | | | | | | | | | | dbus_g_type_specialized_init should be, and is, sufficient. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=40711 Reviewed-by: Dan Williams <dcbw@redhat.com>
* | Use more modern assertions in errors testSimon McVittie2012-11-191-3/+2
| | | | | | | | | | Bug: https://bugs.freedesktop.org/show_bug.cgi?id=40711 Reviewed-by: Dan Williams <dcbw@redhat.com>
* | Turn _dbus_glib_test into a standalone test case, since it only tests public APISimon McVittie2012-11-196-40/+111
| | | | | | | | | | Bug: https://bugs.freedesktop.org/show_bug.cgi?id=40711 Reviewed-by: Dan Williams <dcbw@redhat.com>
* | Remove --with-socket-dir, use /tmp for its only useSimon McVittie2012-11-192-11/+1
| | | | | | | | | | | | | | | | | | | | test-profile.c is not run by default anyway, and it hard-codes the use of Unix sockets which isn't portable off Unix. If you have Unix sockets but not /tmp, then your platform has worse problems than inability to run all dbus-glib tests. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=40711 Reviewed-by: Dan Williams <dcbw@redhat.com>
* | Move AC_ARG_ENABLE for checks/assertions closer to where it takes effectSimon McVittie2012-11-191-4/+9
| | | | | | | | | | | | | | The command line is parsed early on anyway. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=40711 Reviewed-by: Dan Williams <dcbw@redhat.com>
* | Remove remnants of DBUS_DISABLE_CHECKSSimon McVittie2012-11-191-1/+0
| | | | | | | | | | Bug: https://bugs.freedesktop.org/show_bug.cgi?id=40711 Reviewed-by: Dan Williams <dcbw@redhat.com>
* | Remove remnants of DBUS_DISABLE_ASSERTSimon McVittie2012-11-192-2/+1
| | | | | | | | | | Bug: https://bugs.freedesktop.org/show_bug.cgi?id=40711 Reviewed-by: Dan Williams <dcbw@redhat.com>
* | Remove unused support for "verbose mode"Simon McVittie2012-11-192-17/+1
| | | | | | | | | | Bug: https://bugs.freedesktop.org/show_bug.cgi?id=40711 Reviewed-by: Dan Williams <dcbw@redhat.com>
* | Use standard autotools @abs_top_builddir@ to replace TEST_SERVICE_BINARY etc.Simon McVittie2012-11-196-25/+5
| | | | | | | | | | Bug: https://bugs.freedesktop.org/show_bug.cgi?id=40711 Reviewed-by: Dan Williams <dcbw@redhat.com>
View Lorry Controller Status