summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* appveyor: collect libcurl.dll variants with prefix or suffixmback2k-appveyor-dllMarc Hoersken2020-07-121-1/+1
| | | | | | | | | On some platforms libcurl is build with a platform-specific prefix and/or a version number suffix. Assisted-by: Jay Satiro Closes #5659
* CURLINFO_CERTINFO.3: fix typoFilip Salomonsson2020-07-061-2/+2
| | | | Closes https://github.com/curl/curl/pull/5655
* http2: only do the *done() cleanups for HTTPDaniel Stenberg2020-07-041-1/+2
| | | | | | | Follow-up to ef86daf4d3 Closes #5650 Fixes #5646
* gnutls: repair the build with `CURL_DISABLE_PROXY`Alex Kiernan2020-07-041-3/+27
| | | | | | | | | `http_proxy`/`proxy_ssl`/`tunnel_proxy` will not be available in `conn` if `CURL_DISABLE_PROXY` is enabled. Repair the build with that configuration. Signed-off-by: Alex Kiernan <alex.kiernan@gmail.com> Closes #5645
* gnutls: Fetch backend when using proxyAlex Kiernan2020-07-031-0/+1
| | | | | Fixes: 89865c149 ("gnutls: remove the BACKEND define kludge") Signed-off-by: Alex Kiernan <alex.kiernan@gmail.com>
* http2: close the http2 connection when no more requests may be sentLaramie Leavitt2020-07-031-0/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Well-behaving HTTP2 servers send two GOAWAY messages. The first message is a warning that indicates that the server is going to stop accepting streams. The second one actually closes the stream. nghttp2 reports this state (and the other state of no more stream identifiers) via the call nghttp2_session_check_request_allowed(). In this state the client should not create more streams on the session (tcp connection), and in curl this means that the server has requested that the connection is closed. It would be also be possible to put the connclose() call into the on_http2_frame_recv() function that triggers on the GOAWAY message. This fixes a bug seen when the client sees the following sequence of frames: // advisory GOAWAY HTTP2 GOAWAY [stream-id = 0, promised-stream-id = -1] ... some additional frames // final GOAWAY HTTP2 GOAWAY [stream-id = 0, promised-stream-id = N ] Before this change, curl will attempt to reuse the connection even after the last stream, will encounter this error: * Found bundle for host localhost: 0x5595f0a694e0 [can multiplex] * Re-using existing connection! (#0) with host localhost * Connected to localhost (::1) port 10443 (#0) * Using Stream ID: 9 (easy handle 0x5595f0a72e30) > GET /index.html?5 HTTP/2 > Host: localhost:10443 > user-agent: curl/7.68.0 > accept: */* > * stopped the pause stream! * Connection #0 to host localhost left intact curl: (16) Error in the HTTP2 framing layer This error may posion the connection cache, causing future requests which resolve to the same curl connection to go through the same error path. Closes #5643
* ftpserver: don't verify SMTP MAIL FROM namesDaniel Stenberg2020-07-034-7/+11
| | | | | | | Rely on tests asking the names to get refused instead - test servers should be as dumb as possible. Edited test 914, 955 and 959 accordingly. Closes #5639
* curl_version_info.3: CURL_VERSION_KERBEROS4 is deprecatedDaniel Stenberg2020-07-031-1/+1
| | | | | | | This came up in #5640. It make sense to clarify this in the docs! Reminded-by: Kamil Dudka Closes #5642
* tool_getparam: make --krb option work againKamil Dudka2020-07-031-1/+1
| | | | | | | It was disabled by mistake in commit curl-7_37_1-23-ge38ba4301. Bug: https://bugzilla.redhat.com/1833193 Closes #5640
* http2: fix nghttp2_strerror -> nghttp2_http2_strerror in debug messagesJeremy Maitin-Shepard2020-07-021-2/+2
| | | | | | | | | Confusingly, nghttp2 has two different error code enums: - nghttp2_error, to be used with nghttp2_strerror - nghttp2_error_code, to be used with nghttp2_http2_strerror Closes #5641
* url: silence MSVC warningMarcel Raad2020-07-021-1/+1
| | | | | | | | | | | | | | Since commit f3d501dc678, if proxy support is disabled, MSVC warns: url.c : warning C4701: potentially uninitialized local variable 'hostaddr' used url.c : error C4703: potentially uninitialized local pointer variable 'hostaddr' used That could actually only happen if both `conn->bits.proxy` and `CURL_DISABLE_PROXY` were enabled. Initialize it to NULL to silence the warning. Closes https://github.com/curl/curl/pull/5638
* RELEASE-NOTES: syncedDaniel Stenberg2020-07-012-44/+11
|
* RELEASE-NOTES: curl 7.71.1curl-7_71_1Daniel Stenberg2020-06-301-8/+15
|
* THANKS: add contributors to 7.71.1Daniel Stenberg2020-06-301-0/+8
|
* scripts/copyright.pl: skip .dcignoreDaniel Stenberg2020-06-301-0/+1
|
* Revert "multi: implement wait using winsock events"Daniel Stenberg2020-06-302-122/+4
| | | | | | | | | | This reverts commit 8bc25c590e530de87595d1bb3577f699eb1309b9. That commit (from #5397) introduced a regression in 7.71.0. Reported-by: tmkk on github Fixes #5631 Closes #5632
* TODO: Add flag to specify download directoryDaniel Stenberg2020-06-291-0/+7
|
* TODO: return code to CURLMOPT_PUSHFUNCTION to fail connectionDaniel Stenberg2020-06-291-0/+8
|
* cirrus-ci: disable FreeBSD 13 (again)Daniel Stenberg2020-06-291-1/+1
| | | | | | | It has been failing for a good while again. This time we better leave it disabled until we have more reason to believe it behaves. Closes #5628
* ngtcp2: sync with current masterDaniel Stenberg2020-06-291-1/+3
| | | | | | | | ngtcp2 added two new callbacks Reported-by: Lucien Zürcher Fixes #5624 Closes #5627
* examples/multithread.c: call curl_global_cleanup()Daniel Stenberg2020-06-291-2/+2
| | | | | | Reported-by: qiandu2006 on github Fixes #5622 Closes #5623
* vtls: compare cert blob when finding a connection to reuseDaniel Stenberg2020-06-293-1/+46
| | | | | | Reported-by: Gergely Nagy Fixes #5617 Closes #5619
* RELEASE-NOTES: syncedDaniel Stenberg2020-06-281-3/+28
|
* terminology: call them null-terminated stringsDaniel Stenberg2020-06-28107-139/+139
| | | | | | | | | | | Updated terminology in docs, comments and phrases to refer to C strings as "null-terminated". Done to unify with how most other C oriented docs refer of them and what users in general seem to prefer (based on a single highly unscientific poll on twitter). Reported-by: coinhubs on github Fixes #5598 Closes #5608
* http: fix proxy auth with blank passwordDaniel Stenberg2020-06-283-2/+62
| | | | | | | | | | Regression in 7.71.0 Added test case 346 to verify. Reported-by: Kristoffer Gleditsch Fixes #5613 Closes #5616
* .dcignore: ignore tests and docs directoriesDaniel Stenberg2020-06-271-0/+3
| | | | This is a config file for deepcode.ai, a static code analyzer.
* tool_cb_hdr: Fix etag warning output and return codeJay Satiro2020-06-261-4/+4
| | | | | | | | | | - Return 'failure' on failure, to follow the existing style. - Put Warning: and the warning message on the same line. Ref: https://github.com/curl/curl/issues/5610 Closes https://github.com/curl/curl/pull/5612
* CURLOPT_READFUNCTION.3: provide the upload data size up frontDaniel Stenberg2020-06-261-1/+6
| | | | | Assisted-by: Jay Satiro Closes #5607
* test1539: do a HTTP 1.0 POST without a set size (fails)Daniel Stenberg2020-06-264-8/+58
| | | | | | | Attempt to reproduce #5593. Test case 1514 is very similar but uses HTTP/1.1 and thus switches to chunked. Closes #5595
* mbedtls: fix build with disabled proxy supportBaruch Siach2020-06-261-0/+10
| | | | | | | | | Don't reference fields that do not exist. Fixes build failure: vtls/mbedtls.c: In function 'mbed_connect_step1': vtls/mbedtls.c:249:54: error: 'struct connectdata' has no member named 'http_proxy' Closes #5615
* codeql-analysis.yml: fix the 'languages' settingDaniel Stenberg2020-06-261-2/+3
| | | | It needs a 'with:' in front of it.
* gtihub: codeql-analysis.ymlDaniel Stenberg2020-06-261-0/+49
| | | enables code security scanning with github actions
* tests: verify newline in username and password for HTTPDaniel Stenberg2020-06-255-2/+178
| | | | | | test 1296 is a simply command line test test 1910 is a libcurl test including a redirect
* url: allow user + password to contain "control codes" for HTTP(S)Daniel Stenberg2020-06-253-12/+25
| | | | | | Reported-by: Jon Johnson Jr Fixes #5582 Closes #5592
* escape: make the URL decode able to reject only %00 bytesDaniel Stenberg2020-06-2516-34/+60
| | | | | | ... or all "control codes" or nothing. Assisted-by: Nicolas Sterchele
* http2: set the correct URL in pushed transfersDaniel Stenberg2020-06-251-0/+44
| | | | | | | | | ...previously CURLINFO_EFFECTIVE_URL would report the URL of the original "mother transfer", not the actually pushed resource. Reported-by: Jonathan Cardoso Machado Fixes #5589 Closes #5591
* openssl: Fix compilation on Windows when ngtcp2 is enabledJavier Blazquez2020-06-251-4/+5
| | | | | | | - Include wincrypt before OpenSSL includes so that the latter can properly handle any conflicts between the two. Closes https://github.com/curl/curl/pull/5606
* test543: extended to verify zero length inputDaniel Stenberg2020-06-252-2/+14
| | | | As was reported in #5601
* escape: zero length input should return a zero length outputDaniel Stenberg2020-06-251-0/+3
| | | | | | | | Regression added in 7.71.0. Fixes #5601 Reported-by: Kristoffer Gleditsch Closes #5602
* Curl_inet_ntop: always check the return codeDaniel Stenberg2020-06-242-7/+13
| | | | | | Reported-by: Siva Sivaraman Fixes #5412 Closes #5597
* sendf: improve the message on client write errorsDaniel Stenberg2020-06-241-1/+1
| | | | | | | | | Replace "Failed writing body (X != Y)" with "Failure writing output to destination". Possibly slightly less cryptic. Reported-by: coinhubs on github Fixes #5594 Closes #5596
* RELEASE-NOTES: syncedDaniel Stenberg2020-06-241-274/+7
|
* curlver: start working on 7.71.1Daniel Stenberg2020-06-241-3/+3
|
* DYNBUF.md: fix a typo: trail => tailDenis Baručić2020-06-241-1/+1
| | | | Closes #5599
* RELEASE-NOTES: curl 7.71.0 releasecurl-7_71_0Daniel Stenberg2020-06-231-14/+30
|
* THANKS: curl 7.71.0 additionsDaniel Stenberg2020-06-231-0/+33
|
* url: make sure pushed streams get an allocated download bufferDaniel Stenberg2020-06-233-4/+11
| | | | | | | | | Follow-up to c4e6968127e876b0 When a new transfer is created, as a resuly of an acknowledged push, that transfer needs a download buffer allocated. Closes #5590
* openssl: Don't ignore CA paths when using Windows CA storeJay Satiro2020-06-223-15/+13
| | | | | | | | | | | | | This commit changes the behavior of CURLSSLOPT_NATIVE_CA so that it does not override CURLOPT_CAINFO / CURLOPT_CAPATH, or the hardcoded default locations. Instead the CA store can now be used at the same time. The change is due to the impending release. The issue is still being discussed. The behavior of CURLSSLOPT_NATIVE_CA is subject to change and is now documented as experimental. Ref: bc052cc (parent commit) Ref: https://github.com/curl/curl/issues/5585
* tool_operate: Don't use Windows CA store as a fallbackJay Satiro2020-06-221-8/+0
| | | | | | | | | | | | | | | | | | | | | | | Background: 148534d added CURLSSLOPT_NATIVE_CA to use the Windows OS certificate store in libcurl w/ OpenSSL on Windows. CURLSSLOPT_NATIVE_CA overrides CURLOPT_CAINFO if both are set. The curl tool will fall back to CURLSSLOPT_NATIVE_CA if it could not find a certificate bundle to set via CURLOPT_CAINFO. Problem: libcurl may be built with hardcoded paths to a certificate bundle or directory, and if CURLSSLOPT_NATIVE_CA is used then those paths are ignored. Solution: A solution is still being discussed but since there's an impending release this commit removes using CURLSSLOPT_NATIVE_CA in the curl tool. Ref: https://github.com/curl/curl/issues/5585
* openssl: Fix CA fallback logic for OpenSSL 3.0 buildJay Satiro2020-06-221-1/+1
| | | | | | | Prior to this change I assume a build error would occur when CURL_CA_FALLBACK was used. Closes https://github.com/curl/curl/pull/5587