summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* vtls: free ssl_config leftovers on out-of-memorybagder/vtls-ssl_config-cleanupDaniel Stenberg2020-03-151-0/+1
| | | | | | | Torture testing 2034 and 2037 found this. Reported-by: Marc Hörsken Fixes #5108
* ci/tests: install impacket for SMB tests on FreeBSD using CirrusCIMarc Hoersken2020-03-151-1/+2
| | | | | | Also force the package index/cache to be updated before installing. Closes #5103
* tests/README: add note about manually installing python-impacketMarc Hoersken2020-03-151-0/+9
| | | | Follow up to 4be2560
* transfer: cap retries of "dead connections" to 5Daniel Stenberg2020-03-152-1/+7
| | | | | | | | | | When libcurl retries a connection due to it being "seemingly dead" or by REFUSED_STREAM, it will now only do it up five times before giving up, to avoid never-ending loops. Reported-by: Dima Tisnek Bug: https://curl.haxx.se/mail/lib-2020-03/0044.html Closes #5074
* TODO: TLS-PSK with OpenSSLDaniel Stenberg2020-03-151-0/+10
| | | | Closes #5081
* select: add 'timeout_ms' wrap-around precaution to Curl_selectMarc Hoersken2020-03-151-0/+6
|
* select: fix 'pending_ms' is assigned a value that is never usedMarc Hoersken2020-03-151-5/+5
| | | | Detected by Codacy
* select: move duplicate select preparation code into Curl_selectMarc Hoersken2020-03-152-81/+89
| | | | | | Reviewed by Daniel Stenberg Reviewed by Marcel Raad Closes #5078
* connect: happy eyeballs cleanupDaniel Stenberg2020-03-152-53/+51
| | | | | | | | | | | | | | | Make sure each separate index in connn->tempaddr[] is used for a fixed family (and only that family) during the connection process. If family one takes a long time and family two fails immediately, the previous logic could misbehave and retry the same family two address repeatedly. Reported-by: Paul Vixie Reported-by: Jay Satiro Fixes #5083 Fixes #4954 Closes #5089
* ci/tests: fix and align setting TFLAGS for make test-nonflakyMarc Hoersken2020-03-151-18/+20
|
* ci/tests: install test suite dependencies stunnel and impacketMarc Hoersken2020-03-151-1/+16
|
* tests: remove python_dependencies for smbserver from our treeMarc Hoersken2020-03-1517-18137/+14
| | | | | | | | | | | | Users of the SMB tests will have to install impacket manually. Reasoning: our in-tree version of impacket was quite outdated and only compatible with Python 2 which is already end-of-life. Upgrading to Python 3 and a compatible impacket version would require to import additional Python-only and CPython-extension dependencies. This would have hindered portability enormously. Closes #5094
* Makefile.m32: Improve windres parameter compatibilityJay Satiro2020-03-143-3/+3
| | | | | | | | | | | | - s/COFF/coff/ Some versions of windres do not recognize uppercase COFF as a valid way to specify the COFF output format. Reported-by: Steven Penny Fixes https://github.com/curl/curl/issues/5099 Closes https://github.com/curl/curl/pull/5101
* easy: Fix curl_easy_duphandle for builds missing IPv6 that use c-aresJay Satiro2020-03-141-8/+19
| | | | | | | | | | | | | | | | | - Ignore CURLE_NOT_BUILT_IN errors returned by c-ares functions in curl_easy_duphandle. Prior to this change if c-ares was used as the resolver backend and either it was too old or libcurl was built without IPv6 support then some of our resolver functions could return CURLE_NOT_BUILT_IN to curl_easy_duphandle causing it to fail. Caused by c8f086b which shipped in 7.69.1. Reported-by: Karl Chen Fixes https://github.com/curl/curl/issues/5097 Closes https://github.com/curl/curl/pull/5100
* docs: add warnings about FILE: URLs on WindowsDaniel Stenberg2020-03-133-2/+35
| | | | | | | | - --url man page section - libcurl-security.3 gets the full text - CURLOPT_URL.3 Reported-by: Tim Sedlmeyer
* server/getpart: make the "XML-parser" stricterDaniel Stenberg2020-03-133-12/+21
| | | | | | | | | When extracting a <section> <part> and there's no </part> before </section>, this now outputs an error and returns a wrong string to make users spot the mistake. Ref: #5070 Closes #5071
* impacket: some more Python 3 code compatibility updatesMarc Hoersken2020-03-133-13/+18
| | | | This makes smbserver load on Python 3, but still not work completely.
* smbserver: pin Python version to 2 since we are not yet 3 compatibleMarc Hoersken2020-03-131-1/+1
| | | | | | | | Even though the existing code can be fixed to run on Python 3, the tests will fail due to the Unicode transition the protocol is invalid. Follow up to ee63837 Closes #5085
* cleanup: fix some text/comment typosViktor Szakats2020-03-124-5/+5
| | | | Closes #5087
* smbserver: fix Python version specific ConfigParser importMarc Hoersken2020-03-122-5/+5
| | | | | Follow up to ee63837 and 8c7c4a6 Fixes #5077
* RELEASE-NOTES: syncedDaniel Stenberg2020-03-112-63/+21
| | | | bumped to 7.69.2
* tests/data: Fix some XML formatting issues in test casesDan Fandrich2020-03-113-3/+3
| | | | This allows these test files to pass xmllint.
* Makefile: run the cd commands in a subshellMuhammad Herdiansyah2020-03-111-11/+11
| | | | | | | | | In bmake, if the directory is changed (with cd or anything else), bmake won't return to the "root directory" on the next command (in the same Makefile rule). This commit runs the cd command in a subshell so it would work in bmake. Closes #5073
* configure: convert -I to -isystem as a last stepDaniel Stenberg2020-03-112-5/+6
| | | | | | | As all the -I uses in CFLAGS at that point are for system headers and third party libraries this helps us remove/ignore warnings on those! Closes #5060
* configure: fix -pedantic-errors for GCC 5 and laterDaniel Stenberg2020-03-111-13/+13
| | | | | | | | | | | | If --enable-werror is used. Follow-up to d5c0351055d5709da which added it too early in the configure script before $compiler_num was set correctly and thus this option was never used. Reported-by: Stepan Efremov Fixes #5067 Closes #5068
* configure: document 'compiler_num' for gccDaniel Stenberg2020-03-111-3/+12
| | | | | | | | | | The CURL_CHECK_COMPILER_GNU_C function sets the number to MAJOR*100 + MINOR and ignores the patch version, and since gcc version 7 it only sets it to MAJOR*100. Reported-by: Stepan Efremov Ref: #5067 Closes #5069
* RELEASE-NOTES: 7.69.1curl-7_69_1Daniel Stenberg2020-03-111-9/+11
|
* THANKS: from the 7.69.1 releaseDaniel Stenberg2020-03-111-0/+6
|
* test1129: fix invalid case of closing XML-tag and Content-LengthMarc Hoersken2020-03-101-6/+5
| | | | | Fixes #5070 Closes #5072
* tests/data: fix static ip instead of dynamic value being usedMarc Hoersken2020-03-102-4/+4
| | | | Follow up to 94ced8e
* tests/data: fix static ip:port instead of dynamic values being usedMarc Hoersken2020-03-105-9/+9
| | | | Closes #5065
* tests/server: fix missing use of exe_ext helper functionMarc Hoersken2020-03-102-2/+10
| | | | | | Follow up to 9819984 and 3dce984 Reviewed-By: Daniel Stenberg Closes #5064
* runtests: log minimal and maximal used port numbersMarc Hoersken2020-03-101-0/+7
|
* sftp: fix segfault regression introduced by #4747Jim Fuller2020-03-093-17/+72
| | | | | | | | This fix adds a defensive check for the case where the char *name in struct libssh2_knownhost is NULL Fixes #5041 Closes #5062
* RELEASE-NOTES: syncedDaniel Stenberg2020-03-081-4/+24
|
* socks4: fix host resolve regressionDaniel Stenberg2020-03-081-2/+4
| | | | | | | | | | | | | 1. The socks4 state machine was broken in the host resolving phase 2. The code now insists on IPv4-only when using SOCKS4 as the protocol only supports that. Regression from #4907 and 4a4b63d, shipped in 7.69.0 Reported-by: amishmm on github Bug: https://github.com/curl/curl/issues/5053#issuecomment-596191594 Closes #5061
* silly web server: silent a compilation warningPatrick Monnerat2020-03-081-1/+1
| | | | | | | | | Recent gcc warns when byte count of strncpy() equals the destination buffer size. Since the destination buffer is previously cleared and the source string is always shorter, reducing the byte count by one silents the warning without affecting the result. Closes #5059
* cookie: get_top_domain() sets zero length for null domainsPatrick Monnerat2020-03-081-10/+9
| | | | This silents a compilation warning with gcc -O3.
* test 1560: avoid valgrind false positivesPatrick Monnerat2020-03-081-1/+4
| | | | | | | When using maximum code optimization level (-O3), valgrind wrongly detects uses of uninitialized values in strcmp(). Preset buffers with all zeroes to avoid that.
* sha256: Added WinCrypt implementationSteve Holme2020-03-081-0/+43
| | | | Closed #5030
* sha256: Added SecureTransport implementationSteve Holme2020-03-081-0/+31
|
* lib1564: reduce number of mid-wait wakeup callsDaniel Stenberg2020-03-071-2/+2
| | | | | | | | | | | | | | | | | | This test does A LOT of *wakeup() calls and then calls curl_multi_poll() twice. The first *poll() is then expected to return early and the second not - as the first is supposed to drain the socketpair pipe. It turns out however that when given "excessive" amounts of writes to the pipe, some operating systems (the Solaris based are known) will return EAGAIN before the pipe is drained, which in our test case causes the second *poll() call to also abort early. This change attempts to avoid the OS-specific behaviors in the test by reducing the amount of wakeup calls from 1234567 to 10. Reported-by: Andy Fiddaman Fixes #5037 Closes #5058
* mime: fix the binary encoder to handle large data properlyPatrick Monnerat2020-03-076-4/+423
| | | | | | | | | | New test 666 checks this is effective. As upload buffer size is significant in this kind of tests, shorten it in similar test 652. Fixes #4860 Closes #4833 Reported-by: RuurdBeerstra on github
* mime: do not perform more than one read in a rowPatrick Monnerat2020-03-0715-77/+679
| | | | | | | | | | | | | | | | | | | | | Input buffer filling may delay the data sending if data reads are slow. To overcome this problem, file and callback data reads do not accumulate in buffer anymore. All other data (memory data and mime framing) are considered as fast and still concatenated in buffer. As this may highly impact performance in terms of data overhead, an early end of part data check is added to spare a read call. When encoding a part's data, an encoder may require more bytes than made available by a single read. In this case, the above rule does not apply and reads are performed until the encoder is able to deliver some data. Tests 643, 644, 645, 650 and 654 have been adapted to the output data changes, with test data size reduced to avoid the boredom of long lists of 1-byte chunks in verification data. New test 667 checks mimepost using single-byte read callback with encoder. New test 668 checks the end of part data early detection. Fixes #4826 Reported-by: MrdUkk on github
* mime: latch last read callback status.Patrick Monnerat2020-03-0713-13/+628
| | | | | | | | | | | | | In case a read callback returns a status (pause, abort, eof, error) instead of a byte count, drain the bytes read so far but remember this status for further processing. Takes care of not losing data when pausing, and properly resume a paused mime structure when requested. New tests 670-673 check unpausing cases, with easy or multi interface and mime or form api. Fixes #4813 Reported-by: MrdUkk on github
* runtests: fix missing use of exe_ext helper functionMarc Hoersken2020-03-071-2/+2
|
* ares: store dns parameters for duphandleErnst Sjöstrand2020-03-073-4/+37
| | | | | | | | | | | With c-ares the dns parameters lives in ares_channel. Store them in the curl handle and set them again in easy_duphandle. Regression introduced in #3228 (6765e6d), shipped in curl 7.63.0. Fixes #4893 Closes #5020 Signed-off-by: Ernst Sjöstrand <ernst.sjostrand@verisure.com>
* version: make curl_version* thread-safe without using global contextDaniel Stenberg2020-03-076-103/+100
| | | | Closes #5010
* RELEASE-NOTES: syncedDaniel Stenberg2020-03-071-6/+27
|
* tests: use native Sleep function as fallback on WindowsMarc Hoersken2020-03-071-2/+7
| | | | | Reviewed-By: Daniel Stenberg Closes #5054
View Lorry Controller Status