summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* urldata: simplify bytecountersbagder/simplify-bytecountersDaniel Stenberg2019-02-2822-178/+113
| | | | | | | | | | | | | - no need to have them protocol specific - no need to set pointers to them with the Curl_setup_transfer() call - make Curl_setup_transfer() operate on a transfer pointer, not connection - switch some counters from long to the more proper curl_off_t type Closes #3627
* test578: make it read data from the correct testDaniel Stenberg2019-02-281-1/+1
|
* Curl_easy: remove req.maxfd - never used!Daniel Stenberg2019-02-282-3/+0
| | | | | | | Introduced in 8b6314ccfb, but not used anymore in current code. Unclear since when. Closes #3626
* http: set state.infilesize when sending formpostsDaniel Stenberg2019-02-281-1/+1
| | | | | | | | | | | | Without it set, we would unwillingly triger the "HTTP error before end of send, stop sending" condition even if the entire POST body had been sent (since it wouldn't know the expected size) which would unnecessarily log that message and close the connection when it didn't have to. Reported-by: Matt McClure Bug: https://curl.haxx.se/mail/archive-2019-02/0023.html Closes #3624
* INSTALL: refer to the current TLS library names and configure optionsDaniel Stenberg2019-02-281-3/+3
|
* FAQ: minor updates and spelling fixesDaniel Stenberg2019-02-281-15/+16
|
* GOVERNANCE.md: minor spelling fixesDaniel Stenberg2019-02-281-2/+2
|
* Secure Transport: no more "darwinssl"Daniel Stenberg2019-02-2810-125/+134
| | | | | | | | Everyone calls it Secure Transport, now we do too. Reviewed-by: Nick Zitzmann Closes #3619
* AppVeyor: add classic MinGW buildMarcel Raad2019-02-271-0/+11
| | | | | | | | But use the MSYS2 shell rather than the default MSYS shell because of POSIX path conversion issues. Classic MinGW is only available on the Visual Studio 2015 image. Closes https://github.com/curl/curl/pull/3623
* AppVeyor: add MinGW-w64 buildMarcel Raad2019-02-271-1/+30
| | | | | | | | Add a MinGW-w64 build using CMake's MSYS Makefiles generator. Use the Visual Studio 2015 image as it has GCC 8, while the Visual Studio 2017 image only has GCC 7.2. Closes https://github.com/curl/curl/pull/3623
* cookies: only save the cookie file if the engine is enabledDaniel Stenberg2019-02-275-5/+165
| | | | | | | | | | | | | | | | | | | Follow-up to 8eddb8f4259. If the cookieinfo pointer is NULL there really is nothing to save. Without this fix, we got a problem when a handle was using shared object with cookies and is told to "FLUSH" it to file (which worked) and then the share object was removed and when the easy handle was closed just afterwards it has no cookieinfo and no cookies so it decided to save an empty jar (overwriting the file just flushed). Test 1905 now verifies that this works. Assisted-by: Michael Wallner Assisted-by: Marcel Raad Closes #3621
* cacertinmem.c: use multiple certificates for loading CA-chainDaVieS2019-02-271-75/+73
| | | | Closes #3421
* urldata: convert bools to bitfields and move to endDaniel Stenberg2019-02-275-261/+235
| | | | | | | | | | | | This allows the compiler to pack and align the structs better in memory. For a rather feature-complete build on x86_64 Linux, gcc 8.1.2 makes the Curl_easy struct 4.9% smaller. From 6312 bytes to 6000. Removed an unused struct field. No functionality changes. Closes #3610
* curl.h: use __has_declspec_attribute for shared buildsDon J Olmstead2019-02-271-1/+8
| | | | Closes #3616
* curl: display --version features sorted alphabeticallyDaniel Stenberg2019-02-271-3/+23
| | | | Closes #3611
* runtests: detect "schannel" as an alias for "winssl"Daniel Stenberg2019-02-261-15/+3
| | | | | | | | Follow-up to 180501cb02 Reported-by: Marcel Raad Fixes #3609 Closes #3620
* AppVeyor: update to Visual Studio 2017Marcel Raad2019-02-261-4/+4
| | | | | | | Switch all Visual Studio 2015 builds to Visual Studio 2017. It's not a moving target anymore as the last update, Update 9, has been released. Closes https://github.com/curl/curl/pull/3606
* AppVeyor: switch VS 2015 builds to VS 2017 imageMarcel Raad2019-02-261-4/+4
| | | | | | The Visual Studio 2017 image has Visual Studio 2015 and 2017 installed. Closes https://github.com/curl/curl/pull/3606
* AppVeyor: explicitly select worker imageMarcel Raad2019-02-261-6/+12
| | | | | | | Currently, we're using the default Visual Studio 2015 image for everything. Closes https://github.com/curl/curl/pull/3606
* strerror: make the strerror function use local buffersDaniel Stenberg2019-02-2613-108/+142
| | | | | | | | | | | | | | | | Instead of using a fixed 256 byte buffer in the connectdata struct. In my build, this reduces the size of the connectdata struct by 11.8%, from 2160 to 1904 bytes with no functionality or performance loss. This also fixes a bug in schannel's Curl_verify_certificate where it called Curl_sspi_strerror when it should have called Curl_strerror for string from GetLastError. the only effect would have been no text or the wrong text being shown for the error. Co-authored-by: Jay Satiro Closes #3612
* cookies: fix NULL dereference if flushing cookies with no CookieInfo setMichael Wallner2019-02-261-2/+3
| | | | | | Regression brought by a52e46f3900fb0 (shipped in 7.63.0) Closes #3613
* AppVeyor: re-enable test 500Marcel Raad2019-02-261-1/+1
| | | | | | It's passing now. Closes https://github.com/curl/curl/pull/3615
* AppVeyor: remove redundant buildsMarcel Raad2019-02-261-14/+0
| | | | | | | Remove the Visual Studio 2012 and 2013 builds as they add little value. Ref: https://github.com/curl/curl/pull/3606 Closes https://github.com/curl/curl/pull/3614
* RELEASE-NOTES: syncedDaniel Stenberg2019-02-251-8/+26
|
* OpenSSL: add support for TLS ASYNC stateBernd Mueller2019-02-251-0/+6
| | | | Closes #3591
* acinclude: add additional libraries to check for LDAP supportMichael Felt2019-02-251-1/+3
| | | | | | | | - Add an additional check for LDAP that also checks for OpenSSL since on AIX those libraries may be required to link LDAP properly. Fixes https://github.com/curl/curl/issues/3595 Closes https://github.com/curl/curl/pull/3596
* schannel: support CALG_ECDH_EPHEM algorithmgeorgeok2019-02-252-0/+4
| | | | | | | | Add support for Ephemeral elliptic curve Diffie-Hellman key exchange algorithm option when selecting ciphers. This became available on the Win10 SDK. Closes https://github.com/curl/curl/pull/3608
* multi: call multi_done on connect timeoutsDaniel Stenberg2019-02-241-1/+2
| | | | | | | | | | Failing to do so would make the CURLINFO_TOTAL_TIME timeout to not get updated correctly and could end up getting reported to the application completely wrong (way too small). Reported-by: accountantM on github Fixes #3602 Closes #3605
* examples: remove recursive calls to curl_multi_socket_actionDaniel Stenberg2019-02-234-35/+22
| | | | | | | | | | From within the timer callbacks. Recursive is problematic for several reasons. They should still work, but this way the examples and the documentation becomes simpler. I don't think we need to encourage recursive calls. Discussed in #3537 Closes #3601
* configure: remove CURL_CHECK_FUNC_FDOPEN callMarcel Raad2019-02-231-1/+0
| | | | | | | The macro itself has been removed in commit 11974ac859c5d82def59e837e0db56fef7f6794e. Closes https://github.com/curl/curl/pull/3604
* wolfssl: stop custom-adding curvesDaniel Stenberg2019-02-232-21/+1
| | | | | | | | | since wolfSSL PR https://github.com/wolfSSL/wolfssl/pull/717 (shipped in wolfSSL 3.10.2 and later) it sends these curves by default already. Pointed-out-by: David Garske Closes #3599
* configure: remove the unused fdopen macroDaniel Stenberg2019-02-223-95/+2
| | | | | | and the two remaining #ifdefs for it Closes #3600
* url: change conn shutdown order to unlink data as last stepJay Satiro2019-02-221-15/+24
| | | | | | | | | | | | | | | | | | | - Split off connection shutdown procedure from Curl_disconnect into new function conn_shutdown. - Change the shutdown procedure to close the sockets before disassociating the transfer. Prior to this change the sockets were closed after disassociating the transfer so SOCKETFUNCTION wasn't called since the transfer was already disassociated. That likely came about from recent work started in Jan 2019 (#3442) to separate transfers from connections. Bug: https://curl.haxx.se/mail/lib-2019-02/0101.html Reported-by: Pavel Löbl Closes https://github.com/curl/curl/issues/3597 Closes https://github.com/curl/curl/pull/3598
* Fix strict-prototypes GCC warningMarcel Raad2019-02-221-1/+1
| | | | | As seen in the MinGW autobuilds. Caused by commit f26bc29cfec0be84c67cf74065cf8e5e78fd68b7.
* tests: Fixed XML validation errors in some test files.Dan Fandrich2019-02-2115-11/+13
|
* TODO: Allow SAN names in HTTP/2 server pushDaniel Stenberg2019-02-201-0/+10
| | | | Suggested-by: Nicolas Grekas
* RELEASE-NOTES: syncedDaniel Stenberg2019-02-201-7/+34
|
* curl: remove MANUAL from -M outputDaniel Stenberg2019-02-205-36/+10
| | | | | | | | | | | | | | | ... and remove it from the dist tarball. It has served its time, it barely gets updated anymore and "everything curl" is now convering all this document once tried to include, and does it more and better. In the compressed scenario, this removes ~15K data from the binary, which is 25% of the -M output. It remains in the git repo for now for as long as the web site builds a page using that as source. It renders poorly on the site (especially for mobile users) so its not even good there. Closes #3587
* http2: verify :athority in push promise requestsDaniel Stenberg2019-02-201-0/+22
| | | | | | | | | | | RFC 7540 says we should verify that the push is for an "authoritative" server. We make sure of this by only allowing push with an :athority header that matches the host that was asked for in the URL. Fixes #3577 Reported-by: Nicolas Grekas Bug: https://curl.haxx.se/mail/lib-2019-02/0057.html Closes #3581
* singlesocket: fix the 'sincebefore' placementDaniel Stenberg2019-02-201-2/+2
| | | | | | | | | | | | The variable wasn't properly reset within the loop and thus could remain set for sockets that hadn't been set before and miss notifying the app. This is a follow-up to 4c35574 (shipped in curl 7.64.0) Reported-by: buzo-ffm on github Detected-by: Jan Alexander Steffens Fixes #3585 Closes #3589
* connection: never reuse CONNECT_ONLY conectionsDaniel Stenberg2019-02-195-67/+55
| | | | | | | | and make CONNECT_ONLY conections never reuse any existing ones either. Reported-by: Pavel Löbl Bug: https://curl.haxx.se/mail/lib-2019-02/0064.html Closes #3586
* cli tool: fix mime post with --disable-libcurl-option configure optionPatrick Monnerat2019-02-198-127/+181
| | | | | | Reported-by: Marcel Raad Fixes #3576 Closes #3583
* x509asn1: cleanup and unify code layoutDaniel Stenberg2019-02-191-117/+132
| | | | | | | | | | | | | - rename 'n' to buflen in functions, and use size_t for them. Don't pass in negative buffer lengths. - move most function comments to above the function starts like we use to - remove several unnecessary typecasts (especially of NULL) Reviewed-by: Patrick Monnerat Closes #3582
* curl_multi_remove_handle.3: use at any time, just not from within callbacksDaniel Stenberg2019-02-191-1/+4
| | | | [ci skip]
* http: make adding a blank header thread-safeDaniel Stenberg2019-02-191-13/+21
| | | | | | | | | | | | Previously the function would edit the provided header in-place when a semicolon is used to signify an empty header. This made it impossible to use the same set of custom headers in multiple threads simultaneously. This approach now makes a local copy when it needs to edit the string. Reported-by: d912e3 on github Fixes #3578 Closes #3579
* unit1651: survive curl_easy_init() failsDaniel Stenberg2019-02-191-1/+3
|
* rand: Fix a mismatch between comments in source and header.Frank Gevaerts2019-02-181-2/+5
| | | | | Reported-by: Björn Stenberg <bjorn@haxx.se> Closes #3584
* x509asn1: replace single char with an arrayPatrick Monnerat2019-02-181-2/+2
| | | | | | | Although safe in this context, using a single char as an array may cause invalid accesses to adjacent memory locations. Detected by Coverity.
* examples/http2-serverpush: add some sensible error checksDaniel Stenberg2019-02-181-4/+15
| | | | | | To avoid NULL pointer dereferences etc in the case of problems. Closes #3580
* easy: fix win32 init to work without CURL_GLOBAL_WIN32Jay Satiro2019-02-181-49/+60
| | | | | | | | | | | | | | | | | | | | | | | - Change the behavior of win32_init so that the required initialization procedures are not affected by CURL_GLOBAL_WIN32 flag. libcurl via curl_global_init supports initializing for win32 with an optional flag CURL_GLOBAL_WIN32, which if omitted was meant to stop Winsock initialization. It did so internally by skipping win32_init() when that flag was set. Since then win32_init() has been expanded to include required initialization routines that are separate from Winsock and therefore must be called in all cases. This commit fixes it so that CURL_GLOBAL_WIN32 only controls the optional win32 initialization (which is Winsock initialization, according to our doc). The only users affected by this change are those that don't pass CURL_GLOBAL_WIN32 to curl_global_init. For them this commit removes the risk of a potential crash. Ref: https://github.com/curl/curl/pull/3573 Fixes https://github.com/curl/curl/issues/3313 Closes https://github.com/curl/curl/pull/3575