summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* sendf: move Curl_sendf to dict.c and make it staticbagder/sendfDaniel Stenberg2020-09-284-76/+71
| | | | | ... as the only remaining user of that function. Also fix gopher.c to rather use Curl_write()
* schannel: return CURLE_PEER_FAILED_VERIFICATION for untrusted rootDaniel Stenberg2020-09-281-0/+4
| | | | | | | | | | | | This matches what is returned in other TLS backends in the same situation. Reviewed-by: Jay Satiro Reviewed-by: Emil Engler Follow-up to 5a3efb1 Reported-by: iammrtau on github Fixes #6003 Closes #6018
* RELEASE-NOTES: syncedDaniel Stenberg2020-09-261-12/+34
|
* ftp: make a 552 response return CURLE_REMOTE_DISK_FULLDaniel Stenberg2020-09-265-3/+89
| | | | | | | | | Added test 348 to verify. Added a 'STOR' command to the test FTP server to enable test 348. Documented the command in FILEFORMAT.md Reported-by: Duncan Wilcox Fixes #6016 Closes #6017
* pause: only trigger a reread if the unpause sticksDaniel Stenberg2020-09-251-3/+4
| | | | | | | | | | | | As an unpause might itself get paused again and then triggering another reread doesn't help. Follow-up from e040146f22608fd9 (shipped since 7.69.1) Bug: https://curl.haxx.se/mail/lib-2020-09/0081.html Patch-by: Kunal Chandarana Fixes #5988 Closes #6013
* test163[12]: require http to be built-in to runDaniel Stenberg2020-09-252-0/+2
| | | | | | ... as speaking over an HTTPS proxy implies http! Closes #6014
* ngtcp2: adapt to new NGTCP2_PROTO_VER_MAX defineDaniel Stenberg2020-09-251-8/+4
| | | | Closes #6012
* strerror: honor Unicode API choice on WindowsJavier Blazquez2020-09-251-15/+7
| | | | Closes #6005
* imap: make imap_send use dynbuf for the send buffer managementDaniel Stenberg2020-09-254-20/+19
| | | | | | Reuses the buffer and thereby reduces number of mallocs over a transfer. Closes #6010
* Curl_send: return error when pre_receive_plain can't mallocDaniel Stenberg2020-09-251-3/+9
| | | | | | | ... will probably trigger some false DEAD CODE positives on non-windows code analyzers for the conditional code. Closes #6011
* ftp: separate FTPS from FTP over "HTTPS proxy"Daniel Stenberg2020-09-244-14/+7
| | | | | | | | | | When using HTTPS proxy, SSL is used but not in the view of the FTP protocol handler itself so separate the connection's use of SSL from the FTP control connection's sue. Reported-by: Mingtao Yang Fixes #5523 Closes #6006
* tests/data: Fix some mismatched XML tags in test casesDan Fandrich2020-09-234-6/+1
| | | | This allows these test files to pass xmllint.
* pingpong: use a dynbuf for the *_pp_sendf() functionDaniel Stenberg2020-09-236-31/+32
| | | | | | | | | | | | | | ... reuses the same dynamic buffer instead of doing repeated malloc/free cycles. Test case 100 (FTP dir list PASV) does 7 fewer memory allocation calls after this change in my test setup (132 => 125), curl 7.72.0 needed 140 calls for this. Test case 103 makes 9 less allocations now (130). Down from 149 in 7.72.0. Closes #6004
* dynbuf: add Curl_dyn_vaddfDaniel Stenberg2020-09-233-8/+30
| | | | Closes #6004
* dynbuf: make *addf() not require extra mallocsDaniel Stenberg2020-09-234-18/+45
| | | | | | | | | | | | ... by introducing a printf() function that appends directly into a dynbuf: Curl_dyn_vprintf(). This avoids the mandatory extra malloc so if the buffer is already big enough it can just printf directly into it. Since this less-malloc version requires tthe use of a library internal printf function, we only provide this version when building libcurl and not for the dynbuf code that is used when building the curl tool. Closes #5998
* KNOWN_BUGS: Unable to use PKCS12 certificate with Secure TransportDaniel Stenberg2020-09-231-0/+5
| | | | Closes #5403
* pingpong: remove a malloc per Curl_pp_vsendf callDaniel Stenberg2020-09-221-9/+11
| | | | | | This typically makes 7-9 fewer mallocs per FTP transfer. Closes #5997
* symbian: drop supportDaniel Stenberg2020-09-2228-1318/+18
| | | | | | | | | The OS is deprecated. I see no traces of anyone having actually built curl for Symbian after 2012. The public headers are unmodified. Closes #5989
* RELEASE-NOTES: syncedDaniel Stenberg2020-09-221-2/+16
|
* curl_krb5.h: rename from krb5.hDaniel Stenberg2020-09-224-6/+6
| | | | | | | | | Follow-up from f4873ebd0be32cf Turns out some older openssl installations go bananas otherwise. Reported-by: Tom van der Woerdt Fixes #5995 Closes #5996
* test1297: verify GOT_NOTHING with http proxy tunnelDaniel Stenberg2020-09-222-35/+97
|
* http_proxy: do not count proxy headers in the header bytecountDaniel Stenberg2020-09-221-1/+0
| | | | | | | | | | ... as that counter is subsequently used to detect if nothing was returned from the peer. This made curl return CURLE_OK when it should have returned CURLE_GOT_NOTHING. Fixes #5992 Reported-by: Tom van der Woerdt Closes #5994
* setopt: return CURLE_BAD_FUNCTION_ARGUMENT on bad argumentDaniel Stenberg2020-09-222-17/+12
| | | | | | | Fixed two return code mixups. CURLE_UNKNOWN_OPTION is saved for when the option is, yeah, not known. Clarified this in the setopt man page too. Closes #5993
* krb5: merged security.c and krb specific FTP functions in hereDaniel Stenberg2020-09-219-682/+595
| | | | | | | | | | | These two files were always tightly connected and it was hard to understand what went into which. This also allows us to make the ftpsend() function static (moved from ftp.c). Removed security.c Renamed curl_sec.h to krb5.h Closes #5987
* Curl_handler: add 'family' to each protocolDaniel Stenberg2020-09-2123-116/+63
| | | | | | | Makes get_protocol_family() faster and it moves the knowledge about the "families" to each protocol handler, where it belongs. Closes #5986
* parsedate: tune the date to epoch conversionDaniel Stenberg2020-09-211-46/+11
| | | | | | | | | By avoiding an unnecessary error check and the temp use of the tm struct, the time2epoch conversion function gets a little bit faster. When repeating test 517, the updated version is perhaps 1% faster (on one particular build on one particular architecture). Closes #5985
* cmake: remove scary warningDaniel Stenberg2020-09-211-2/+0
| | | | | | | | | | | Remove the text saying "the curl cmake build system is poorly maintained. Be aware" ... not because anything changed just now, but to encourage users to use it and subsequently improve it. Closes #5984
* docs/MQTT: remove outdated paaragraphsDaniel Stenberg2020-09-211-12/+0
|
* docs/MQTT: not experimental anymoreDaniel Stenberg2020-09-211-20/+0
| | | | Follow-up to e37e4468688d8f
* docs/RESOURCES: removeDaniel Stenberg2020-09-182-86/+0
| | | | | | | | This document is not maintained and rather than trying to refresh it, let's kill it. A more up-to-date document with relevant RFCs is this page on the curl website: https://curl.haxx.se/rfc/ Closes #5980
* docs/TheArtOfHttpScripting: convert to markdownDaniel Stenberg2020-09-183-759/+693
| | | | | | | | | | Makes it easier to browse on github etc. Offers (better) links. It should be noted that this document is already mostly outdated and "Everything curl" at https://ec.haxx.se/ is a better resource and tutorial. Closes #5981
* BUGS: convert document to markdownDaniel Stenberg2020-09-183-303/+267
| | | | Closes #5979
* --help: strdup the categoryDaniel Stenberg2020-09-183-14/+14
| | | | | | | | | | ... since it is converted and the original pointer is freed on Windows unicode handling. Follow-up to aa8777f63febc Fixes #5977 Closes #5978 Reported-by: xwxbug on github
* CHECKSRC: document two missing warningsDaniel Stenberg2020-09-181-0/+4
|
* RELEASE-NOTES: syncedDaniel Stenberg2020-09-181-6/+40
|
* ftp: avoid risk of reading uninitialized integersDaniel Stenberg2020-09-181-2/+2
| | | | | | | | | If the received PASV response doesn't match the expected pattern, we could end up reading uninitialized integers for IP address and port number. Issue pointed out by muse.dev Closes #5972
* easy_reset: clear retry counterQuentin Balland2020-09-181-0/+1
| | | | | Closes #5975 Fixes #5974
* ftp: get rid of the PPSENDF macroDaniel Stenberg2020-09-181-156/+150
| | | | | | | The use of such a macro hides some of what's actually going on to the reader and is generally disapproved of in the project. Closes #5971
* man pages: switch to https://example.com URLsDaniel Stenberg2020-09-17125-129/+129
| | | | | | | Since HTTPS is "the new normal", this update changes a lot of man page examples to use https://example.com instead of the previous "http://..." Closes #5969
* github: remove the duplicate "Security vulnerability" entryDaniel Stenberg2020-09-171-3/+0
| | | | | | ... since github adds an entry automatically by itself. Closes #5970
* github: use new issue template featureEmil Engler2020-09-172-0/+23
| | | | | | | This helps us to avoid getting feature requests as well as security bugs reported into the issue tracker. Closes #5936
* urlapi: use more Curl_safefreeEmil Engler2020-09-171-4/+2
| | | | Closes #5968
* multi: align WinSock mask variables in Curl_multi_waitMarc Hoersken2020-09-171-11/+11
| | | | | | | | | | Also skip pre-checking sockets to set timeout_ms to 0 after the first socket has been detected to be ready. Reviewed-by: rcombs on github Reviewed-by: Daniel Stenberg Follow up to #5886
* multi: reuse WinSock events variable in Curl_multi_waitMarc Hoersken2020-09-171-12/+11
| | | | | | | | | | | Since the struct is quite large (1 long and 10 ints) we declare it once at the beginning of the function instead of multiple times inside loops to avoid stack movements. Reviewed-by: Viktor Szakats Reviewed-by: Daniel Stenberg Closes #5886
* TODO: dynamically decide to use socketpairDaniel Stenberg2020-09-161-0/+9
| | | | | | Suggested-by: Anders Bakken Closes #4829
* TODO: add PR reference for native IDN support on macOSDaniel Stenberg2020-09-161-0/+2
| | | | | | As there was work started on this that never got completed. Closes #5371
* tool_help.h: update copyright year rangeDaniel Stenberg2020-09-161-1/+1
| | | | Follow-up from aa8777f63febca
* CI/azure: disable test 571 in the msys2 buildsDaniel Stenberg2020-09-161-4/+4
| | | | | | | It's just too flaky there Reviewed-by: Marc Hoersken Closes #5954
* tool_writeout: protect fputs() from NULLDaniel Stenberg2020-09-151-9/+6
| | | | | | | | | When the code was changed to do fputs() instead of fprintf() it got sensitive for NULL pointers; add checks for that. Follow-up from 0c1e767e83ec66 Closes #5963
* test3015: verify stdout "as text"Daniel Stenberg2020-09-151-1/+1
| | | | | | Follow-up from 0c1e767e83e to please win32 tests Closes #5962