summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* curl_ntlm_wb: check aprintf() return codesbagder/ntlm_wb-aprintf-checksDaniel Stenberg2018-10-071-0/+6
| | | | ... when they return NULL we're out of memory and MUST return failure.
* gskit: make sure to terminate version stringDaniel Gustafsson2018-10-071-2/+1
| | | | | | | | | | | | In case a very small buffer was passed to the version function, it could result in the buffer not being NULL-terminated since strncpy() doesn't guarantee a terminator on an overflowed buffer. Rather than adding code to terminate (and handle zero-sized buffers), move to using snprintf() instead like all the other vtls backends. Closes #3105 Reviewed-by: Daniel Stenberg <daniel@haxx.se> Reviewed-by: Viktor Szakats <commit@vszakats.net>
* TODO: add LD_PRELOAD support on macOSDaniel Gustafsson2018-10-071-0/+6
| | | | Add DYLD_INSERT_LIBRARIES support to the TODO list. Reported in #2394.
* runtests: skip ld_preload tests on macOSDaniel Gustafsson2018-10-071-1/+1
| | | | | | | | | | The LD_PRELOAD functionality doesn't exist on macOS, so skip any tests requiring it. Fixes #2394 Closes #3106 Reported-by: Github user @jakirkham Reviewed-by: Daniel Stenberg <daniel@haxx.se>
* AppVeyor: use Debug builds to run testsMarcel Raad2018-10-071-5/+6
| | | | | | This enables more tests. Closes https://github.com/curl/curl/pull/3104
* AppVeyor: add HTTP_ONLY buildMarcel Raad2018-10-071-0/+16
| | | | Closes https://github.com/curl/curl/pull/3104
* AppVeyor: add WinSSL buildsMarcel Raad2018-10-071-8/+11
| | | | | | | Use the oldest and latest Windows SDKs for them. Also, remove all but one OpenSSL build. Closes https://github.com/curl/curl/pull/3104
* AppVeyor: add remaining Visual Studio versionsMarcel Raad2018-10-071-4/+9
| | | | | | | | This adds Visual Studio 9 and 10 builds. There's no 64-bit VC9 compiler on AppVeyor, so use it as the Win32 build. Also, VC9 cannot be used for running the test suite. Closes https://github.com/curl/curl/pull/3104
* AppVeyor: break long lineMarcel Raad2018-10-071-1/+9
| | | | Closes https://github.com/curl/curl/pull/3104
* AppVeyor: remove unused BDIR variableMarcel Raad2018-10-071-7/+0
| | | | Closes https://github.com/curl/curl/pull/3104
* test2100: test DoH using IPv4-onlyDaniel Stenberg2018-10-061-0/+0
| | | | | | | | | To make it only send one DoH request and avoid the race condition that could lead to the requests getting sent in reversed order and thus making it hard to compare in the test case. Fixes #3107 Closes #3108
* tests/FILEFORMAT: mention how to use <fileN> and <stripfileN> tooDaniel Stenberg2018-10-061-0/+19
| | | | [ci skip]
* RELEASE-NOTES: syncedDaniel Stenberg2018-10-051-9/+39
|
* timeval: fix use of weak symbol clock_gettime() on Apple platformsdmitrykos2018-10-051-2/+18
| | | | Closes #3048
* doh: keep the IPv4 address in (original) network byte orderDaniel Stenberg2018-10-053-24/+19
| | | | | | | | Ideally this will fix the reversed order shown in SPARC tests: resp 8: Expected 127.0.0.1 got 1.0.0.127 Closes #3091
* INTERNALS.md: wrap lines longer than 79Jay Satiro2018-10-051-2/+5
|
* INTERNALS: escape reference to parameterDaniel Gustafsson2018-10-051-2/+2
| | | | | | | | | | The parameter reference <string> was causing rendering issues in the generated HTML page, as <string> isn't a valid HTML tag. Fix by back- tick escaping it. Closes #3099 Reviewed-by: Jay Satiro <raysatiro@yahoo.com> Reviewed-by: Daniel Stenberg <daniel@haxx.se>
* checksrc: handle zero scoped ignore commandsDaniel Gustafsson2018-10-051-1/+10
| | | | | | | | | | | | | | | | If a !checksrc! disable command specified to ignore zero errors, it was still added to the ignore block even though nothing was ignored. While there were no blocks ignored that shouldn't be ignored, the processing ended with with a warning: <filename>:<line>:<col>: warning: Unused ignore: LONGLINE (UNUSEDIGNORE) /* !checksrc! disable LONGLINE 0 */ ^ Fix by instead treating a zero ignore as a a badcommand and throw a warning for that one. Closes #3096 Reviewed-by: Daniel Stenberg <daniel@haxx.se>
* checksrc: enable strict mode and warningsDaniel Gustafsson2018-10-051-8/+18
| | | | | | | | | | | | | | | | | | Enable strict and warnings mode for checksrc to ensure we aren't missing anything due to bugs in the checking code. This uncovered a few things which are all fixed in this commit: * several variables were used uninitialized * several variables were not defined in the correct scope * the whitelist filehandle was read even if the file didn't exist * the enable_warn() call when a disable counter had expired was passing incorrect variables, but since the checkwarn() call is unlikely to hit (the counter is only decremented to zero on actual ignores) it didn't manifest a problem. Closes #3090 Reviewed-by: Daniel Stenberg <daniel@haxx.se> Reviewed-by: Marcel Raad <Marcel.Raad@teamviewer.com>
* CMake: suppress MSVC warning C4127 for libtestMarcel Raad2018-10-051-0/+4
| | | | It's issued by older Windows SDKs (prior to version 8.0).
* Merge branch 'dmitrykos-fix_missing_CMake_defines'Sergei Nikulov2018-10-053-0/+25
|\
| * cmake: test and set missed defines during configurationdmitrykos2018-10-053-0/+25
|/ | | | | | Added configuration checks for HAVE_BUILTIN_AVAILABLE and HAVE_CLOCK_GETTIME_MONOTONIC. Closes #3097
* AppVeyor: disable test 500Marcel Raad2018-10-051-1/+1
| | | | | | | | It almost always results in "starttransfer vs total: 0.000001 0.000000". I cannot reproduce this locally, so disable it for now. Closes https://github.com/curl/curl/pull/3100
* AppVeyor: set custom install prefixMarcel Raad2018-10-051-1/+1
| | | | | | | CMake's default has spaces and in 32-bit mode parentheses, which result in syntax errors in curl-config. Closes https://github.com/curl/curl/pull/3100
* AppVeyor: Remove non-SSL non-test buildsMarcel Raad2018-10-051-18/+0
| | | | | | They don't add much value. Closes https://github.com/curl/curl/pull/3100
* AppVeyor: run test suiteMarcel Raad2018-10-051-0/+4
| | | | | | | | Use the preinstalled MSYS2 bash for that. Disable test 1139 as the CMake build doesn't generate curl.1. Ref: https://github.com/curl/curl/issues/3070#issuecomment-425922224 Closes https://github.com/curl/curl/pull/3100
* AppVeyor: use in-tree buildMarcel Raad2018-10-051-3/+1
| | | | | | Required to run the tests. Closes https://github.com/curl/curl/pull/3100
* doh: make sure TTL isn't re-inited by second (discarded?) responseDaniel Stenberg2018-10-041-3/+8
| | | | Closes #3092
* test320: strip out more HTML when comparingDaniel Stenberg2018-10-041-20/+4
| | | | | | | | To make the test case work with different gnutls-serv versions better. Reported-by: Kamil Dudka Fixes #3093 Closes #3094
* runtests: use Windows paths for Windows curlMarcel Raad2018-10-041-1/+1
| | | | | curl generated by CMake's Visual Studio generator has "Windows" in the version number.
* tests/negtelnetserver.py: fix Python2-ism in neg TELNET serverColin Hogben2018-10-041-21/+12
| | | | | | | | Fix problems caused by differences in treatment of bytes objects between python2 and python3. Fixes #2929 Closes #3080
* memory: ensure to check allocation resultsDaniel Gustafsson2018-10-035-4/+17
| | | | | | | | | | | | | | | | The result of a memory allocation should always be checked, as we may run under memory pressure where even a small allocation can fail. This adds checking and error handling to a few cases where the allocation wasn't checked for success. In the ftp case, the freeing of the path variable is moved ahead of the allocation since there is little point in keeping it around across the strdup, and the separation makes for more readable code. In nwlib, the lock is aslo freed in the error path. Also bumps the copyright years on affected files. Closes #3084 Reviewed-by: Jay Satiro <raysatiro@yahoo.com> Reviewed-by: Daniel Stenberg <daniel@haxx.se>
* comment: Fix multiple typos in function parametersDaniel Gustafsson2018-10-0312-18/+18
| | | | | | | | Ensure that the parameters in the comment match the actual names in the prototype. Closes #3079 Reviewed-by: Daniel Stenberg <daniel@haxx.se>
* CURLOPT_SSLVERSION.3: fix typos and consistent spellingDaniel Gustafsson2018-10-031-4/+4
| | | | | | | | | Use TLS vX.Y throughout the document, instead of TLS X.Y, as that was already done in all but a few cases. Also fix a few typos. Closes #3076 Reviewed-by: Marcel Raad <Marcel.Raad@teamviewer.com> Reviewed-by: Daniel Stenberg <daniel@haxx.se>
* SECURITY-PROCESS: make links into hyperlinksDaniel Gustafsson2018-10-031-3/+4
| | | | | | | | | Use proper Markdown hyperlink format for the Bountygraph links in order for the generated website page to be more user friendly. Also link to the sponsors to give them a little extra credit. Closes #3082 Reviewed-by: Daniel Stenberg <daniel@haxx.se>
* CURLOPT_HEADER.3: fix typoJay Satiro2018-10-031-1/+1
|
* nss: fix nssckbi module loading on WindowsJay Satiro2018-10-031-2/+7
| | | | | | | | | | | - Use .DLL extension instead of .so to load modules on Windows. Bug: https://curl.haxx.se/mail/lib-2018-09/0077.html Reported-by: Maxime Legros Ref: https://github.com/curl/curl/pull/3016/#issuecomment-423069442 Closes https://github.com/curl/curl/pull/3086
* data-binary.d: clarify default content-type is x-www-form-urlencodedJay Satiro2018-10-031-0/+5
| | | | | | | | | | - Advise user that --data-binary sends a default content type of x-www-form-urlencoded, and to have the data treated as arbitrary binary data by the server set the content-type header to octet-stream. Ref: https://github.com/curl/curl/pull/2852#issuecomment-426465094 Closes https://github.com/curl/curl/pull/3085
* test1299: use single quotes around asteriskMarcel Raad2018-10-021-1/+1
| | | | Ref: https://github.com/curl/curl/issues/1751#issuecomment-321522580
* docs/CIPHERS: mention the colon separation for OpenSSLDaniel Stenberg2018-10-021-0/+2
| | | | Bug: #3077
* runtests: ignore disabled even when ranges are givenDaniel Stenberg2018-10-021-8/+17
| | | | | | | | | | | runtests.pl support running a range of tests, like "44 to 127". Starting now, the code makes sure that even such given ranges will ignore tests that are marked as disabled. Disabled tests can still be run by explictly specifying that test number. Closes #3075
* urlapi: starting with a drive letter on win32 is not an abs urlDaniel Stenberg2018-10-021-14/+18
| | | | | | | | | | ... and libcurl doesn't support any single-letter URL schemes (if there even exist any) so it should be fairly risk-free. Reported-by: Marcel Raad Fixes #3070 Closes #3071
* doh: fix curl_easy_setopt argument typeMarcel Raad2018-10-021-1/+1
| | | | | CURLOPT_POSTFIELDSIZE is long. Fixes a compiler warning on 64-bit MinGW.
* RELEASE-NOTES: syncedDaniel Stenberg2018-10-021-17/+37
|
* CMake: Improve config installationRuslan Baratov2018-10-014-90/+32
| | | | | | | | | | | | | | | | | | | | | | Use 'GNUInstallDirs' standard module to set destinations of installed files. Use uppercase "CURL" names instead of lowercase "curl" to match standard 'FindCURL.cmake' CMake module: * https://cmake.org/cmake/help/latest/module/FindCURL.html Meaning: * Install 'CURLConfig.cmake' instead of 'curl-config.cmake' * User should call 'find_package(CURL)' instead of 'find_package(curl)' Use 'configure_package_config_file' function to generate 'CURLConfig.cmake' file. This will make 'curl-config.cmake.in' template file smaller and handle components better. E.g. current configuration report no error if user specified unknown components (note: new configuration expects no components, report error if user will try to specify any). Closes https://github.com/curl/curl/pull/2849
* test1650: make it depend on http/2Daniel Stenberg2018-10-012-0/+12
| | | | | | | Follow-up to 570008c99da0ccbb as it gets link errors. Reported-by: Michael Kaufmann Closes #3068
* MANUAL: minor grammar fixNate Prewitt2018-10-011-1/+1
| | | | | | Noticed a typo reading through the docs. Closes #3069
* doh: only build if h2 enabledDaniel Stenberg2018-09-301-1/+29
| | | | | | | | The DoH spec says "HTTP/2 [RFC7540] is the minimum RECOMMENDED version of HTTP for use with DoH". Reported-by: Marcel Raad Closes #3066
* test2100: require http2 to runDaniel Stenberg2018-09-292-1/+1
| | | | | | Reported-by: Marcel Raad Fixes #3064 Closes #3065
* multi: fix memory leak in content encoding related error pathDaniel Stenberg2018-09-291-3/+7
| | | | | | | | ... a missing multi_done() call. Credit to OSS-Fuzz Bug: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=10728 Closes #3063