summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* fixup make test 1559 require HTTP to runbagder/limit-string-lengthsDaniel Stenberg2019-04-251-0/+5
|
* CURL_MAX_INPUT_LENGTH: largest acceptable string input sizeDaniel Stenberg2019-04-257-3/+141
| | | | | | | | | | | | | This limits all accepted input strings passed to libcurl to be less than CURL_MAX_INPUT_LENGTH (1000000) bytes, for these API calls: curl_easy_setopt() and curl_url_set(). The 1000000 number is arbitrary picked and is meant to detect mistakes or abuse, not to limit actual practical use cases. By limiting the acceptable string lengths we also reduce the risk of integer overflows all over. NOTE_ This does not apply to `CURLOPT_POSTFIELDS`.
* ntlm: Missed pre-processor || (or) during rebase for cd15acd0Steve Holme2019-04-231-1/+1
|
* ntlm: Support the NT response in the type-3 when OpenSSL doesn't include MD4Steve Holme2019-04-234-6/+16
| | | | | | Just like we do for mbed TLS, use our local implementation of MD4 when OpenSSL doesn't support it. This allows a type-3 message to include the NT response.
* INTERNALS: fix misindentation of ToC itemDaniel Gustafsson2019-04-231-1/+1
| | | | | | | Kerberos was incorrectly indented as a subsection under FTP, which is incorrect as they are both top level sections. A fix for this was first attempted in commit fef38a0898322f285401c5ff2f5e7c90dbf3be63 but that was a few paddles short of being complete.
* INTERNALS: Add structs to ToCAron Bergman2019-04-231-0/+14
| | | | | | | Add the subsections under "Structs in libcurl" to the table of contents. Reviewed-by: Daniel Stenberg <daniel@haxx.se> Reviewed-by: Daniel Gustafsson <daniel@yesql.se>
* INTERNALS: Add code highlightingAron Bergman2019-04-231-9/+9
| | | | | | | | | Make all struct members under the Curl_handler section print in monospace font. Closes #3801 Reviewed-by: Daniel Stenberg <daniel@haxx.se> Reviewed-by: Daniel Gustafsson <daniel@yesql.se>
* docs/BUG-BOUNTY: bug bounty time [skip ci]Daniel Stenberg2019-04-226-32/+130
| | | | | | | | | | Introducing the curl bug bounty program on hackerone. We now recommend filing security issues directly in the hackerone ticket system which only is readable to curl security team members. Assisted-by: Daniel Gustafsson Closes #3488
* sasl: Don't send authcid as authzid for the PLAIN mechanism as per RFC 4616Steve Holme2019-04-2216-29/+29
| | | | | | | RFC 4616 specifies the authzid is optional in the client authentication message and that the server will derive the authorisation identity (authzid) from the authentication identity (authcid) when not specified by the client.
* memdebug: fix variable nameGisle Vanem2019-04-221-2/+2
| | | | | | Follow-up to 76b6348 which renamed logfile as curl_dbg_logfile. Ref: https://github.com/curl/curl/commit/76b6348#r33259088
* vauth/cleartext: Don't send the authzid if it is emptySteve Holme2019-04-211-2/+3
| | | | Follow up to 762a292f.
* test 196,197,198: add 'retry' keyword [skip ci]Daniel Stenberg2019-04-213-0/+3
|
* RELEASE-NOTES: syncedDaniel Stenberg2019-04-211-4/+15
|
* CURLOPT_MAXAGE_CONN: set the maximum allowed age for conn reuseDaniel Stenberg2019-04-2110-14/+106
| | | | | | | | | ... and disconnect too old ones instead of trying to reuse. Default max age is set to 118 seconds. Ref: #3722 Closes #3782
* altsvc: Fix building with cookies disablesPo-Chuan Hsieh2019-04-206-31/+88
| | | | | | | | | | | ALTSVC requires Curl_get_line which is defined in lib/cookie.c inside a #if check of HTTP and COOKIES. That makes Curl_get_line undefined if COOKIES is disabled. Fix by splitting out the function into a separate file which can be included where needed. Closes #3717 Reviewed-by: Daniel Gustafsson <daniel@yesql.se> Reviewed-by: Marcel Raad <Marcel.Raad@teamviewer.com>
* test1002: correct the name [skip ci]Daniel Stenberg2019-04-201-1/+1
|
* test660: verify CONNECT_ONLY with IMAPDaniel Stenberg2019-04-202-1/+35
| | | | which basically just makes sure LOGOUT is *not* issued on disconnect
* Curl_disconnect: treat all CONNECT_ONLY connections as "dead"Daniel Stenberg2019-04-201-0/+4
| | | | | | | | | Since the connection has been used by the "outside" we don't know the state of it anymore and curl should not use it anymore. Bug: https://curl.haxx.se/mail/lib-2019-04/0052.html Closes #3795
* multi: fix the statenames (follow-up fix from 2f44e94efb3df8e)Daniel Stenberg2019-04-191-2/+0
| | | | | The list of names must be in sync with the defined states in the header file!
* openvms: Remove pre-processors for Windows as VMS cannot support themSteve Holme2019-04-161-6/+0
|
* openvms: Remove pre-processor for SecureTransport as VMS cannot support itSteve Holme2019-04-161-3/+0
| | | | | Fixes #3768 Closes #3785
* TODO: Add issue link to an existing entryJay Satiro2019-04-161-0/+2
|
* RELEASE-NOTES: syncedDaniel Stenberg2019-04-161-4/+23
|
* tool_help: Warn if curl and libcurl versions do not matchJay Satiro2019-04-162-8/+4
| | | | | | | | | | | .. because functionality may be affected if the versions differ. This commit implements TODO 18.7 "warning if curl version is not in sync with libcurl version". Ref: https://github.com/curl/curl/blob/curl-7_64_1/docs/TODO#L1028-L1033 Closes https://github.com/curl/curl/pull/3774
* md5: Update the function signature following d84da52dSteve Holme2019-04-161-5/+5
|
* md5: Forgot to update the code alignment in d84da52dSteve Holme2019-04-151-2/+2
|
* md5: Return CURLcode from the internally accessible functionsSteve Holme2019-04-151-2/+2
| | | | Following 28f826b3 to return CURLE_OK instead of numeric 0.
* tests: Run global cleanup at end of testsDaniel Gustafsson2019-04-154-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | Make sure to run curl_global_cleanup() when shutting down the test suite to release any resources allocated in the SSL setup. This is clearly visible when running tests with PolarSSL where the thread lock calloc() memory which isn't released when not running cleanup. Below is an excerpt from the autobuild logs: ==12368== 96 bytes in 1 blocks are possibly lost in loss record 1 of 2 ==12368== at 0x4837B65: calloc (vg_replace_malloc.c:752) ==12368== by 0x11A76E: curl_dbg_calloc (memdebug.c:205) ==12368== by 0x145CDF: Curl_polarsslthreadlock_thread_setup (polarssl_threadlock.c:54) ==12368== by 0x145B37: Curl_polarssl_init (polarssl.c:865) ==12368== by 0x14129D: Curl_ssl_init (vtls.c:171) ==12368== by 0x118B4C: global_init (easy.c:158) ==12368== by 0x118BF5: curl_global_init (easy.c:221) ==12368== by 0x118D0B: curl_easy_init (easy.c:299) ==12368== by 0x114E96: test (lib1906.c:32) ==12368== by 0x115495: main (first.c:174) Closes #3783 Reviewed-by: Marcel Raad <Marcel.Raad@teamviewer.com> Reviewed-by: Daniel Stenberg <daniel@haxx.se>
* travis: use mbedtls from XenialMarcel Raad2019-04-151-13/+1
| | | | | | No need to build it from source anymore. Closes https://github.com/curl/curl/pull/3779
* travis: use libpsl from XenialMarcel Raad2019-04-151-29/+46
| | | | | | | This makes building libpsl and libidn2 from source unnecessary and removes the need for the autopoint and libunistring-dev packages. Closes https://github.com/curl/curl/pull/3779
* runtests: start socksd like other serversDaniel Stenberg2019-04-151-1/+1
| | | | | | | ... without a $srcdir prefix. Triggered by the failures in several autobuilds. Closes #3781
* socksd: Fix typosDaniel Gustafsson2019-04-141-2/+2
| | | | Reviewed-by: Daniel Stenberg <daniel@haxx.se>
* socksd: Properly decorate static variablesDaniel Gustafsson2019-04-141-4/+4
| | | | | | | | Mark global variables static to avoid compiler warning in Clang when using -Wmissing-variable-declarations. Closes #3778 Reviewed-by: Daniel Stenberg <daniel@haxx.se>
* md(4|5): Fixed indentation oddities with the importation of replacement codeSteve Holme2019-04-142-114/+114
| | | | | | | The indentation from 211d5329 and 57d6d253 was a little strange as parts didn't align correctly, uses 4 spaces rather than 2. Checked the indentation of the original source so it aligns, albeit, using curl style.
* md5: Code style to return CURLE_OK rather than numeric 0Steve Holme2019-04-141-2/+2
|
* md5: Corrected code style for some pointer argumentsSteve Holme2019-04-141-6/+6
|
* travis: update some builds to xenialMarcel Raad2019-04-131-26/+26
| | | | | | | | | Xenial comes with more up-to-date software versions and more available packages, some of which we currently build from source. Unfortunately, some builds would fail with Xenial because of assertion failures in Valgrind when using OpenSSL, so leave these at Trusty. Closes https://github.com/curl/curl/pull/3777
* test: make tests and test scripts use socksd for SOCKSDaniel Stenberg2019-04-139-142/+149
| | | | Make all SOCKS tests use socksd instead of ssh.
* socksd: new SOCKS 4+5 server for testsDaniel Stenberg2019-04-133-1/+1174
| | | | Closes #3752
* singleipconnect: show port in the verbose "Trying ..." messageDaniel Stenberg2019-04-131-1/+1
| | | | To aid debugging better.
* CURLOPT_ADDRESS_SCOPE: fix range check and moretmilburn2019-04-134-25/+26
| | | | | | | | | | | | | | | | | Commit 9081014 fixed most of the confusing issues between scope id and scope however 844896d added bad limits checking assuming that the scope is being set and not the scope id. I have fixed the documentation so it all refers to scope ids. In addition Curl_if2ip refered to the scope id as remote_scope_id which is incorrect, so I renamed it to local_scope_id. Adjusted-by: Daniel Stenberg Closes #3655 Closes #3765 Fixes #3713
* urlapi: stricter CURLUPART_PORT parsingDaniel Stenberg2019-04-133-33/+80
| | | | | | | | | | | Only allow well formed decimal numbers in the input. Document that the number MUST be between 1 and 65535. Add tests to test 1560 to verify the above. Ref: https://github.com/curl/curl/issues/3753 Closes #3762
* winbuild: Support MultiSSL buildsJan-E2019-04-132-6/+6
| | | | | | | | | | - Remove the lines in winbuild/Makefile.vc that generate an error with multiple SSL backends. - Add /DCURL_WITH_MULTI_SSL in winbuild/MakefileBuild.vc if multiple SSL backends are set. Closes https://github.com/curl/curl/pull/3772
* travis: remove mesalink builds (temporarily?)Daniel Stenberg2019-04-121-29/+0
| | | | | | | | Since the mesalink build started to fail on travis, even though we build a fixed release version, we disable it to prevent it from blocking progress. Closes #3767
* openssl: mark connection for close on TLS close_notifyDaniel Stenberg2019-04-121-0/+3
| | | | | | | | | Without this, detecting and avoid reusing a closed TLS connection (without a previous GOAWAY) when doing HTTP/2 is tricky. Reported-by: Tom van der Woerdt Fixes #3750 Closes #3763
* RELEASE-NOTES: syncedDaniel Stenberg2019-04-121-3/+31
|
* vauth/cleartext: Update the PLAIN login function signature to match RFC 4616Steve Holme2019-04-113-23/+27
| | | | | | | Functionally this doesn't change anything as we still use the username for both the authorisation identity and the authentication identity. Closes #3757
* test1906: verify CURLOPT_CURLU + CURLOPT_PORT usageDaniel Stenberg2019-04-114-2/+129
| | | | Based-on-code-by: Poul T Lomholt
* url: always clone the CUROPT_CURLU handleDaniel Stenberg2019-04-111-3/+2
| | | | | | | | | Since a few code paths actually update that data. Fixes #3753 Closes #3761 Reported-by: Poul T Lomholt
* CURLOPT_DNS_USE_GLOBAL_CACHE: removeDaniel Stenberg2019-04-119-119/+35
| | | | | | | | Remove the code too. The functionality has been disabled in code since 7.62.0. Setting this option will from now on simply be ignored and have no function. Closes #3654
View Lorry Controller Status